https://bugzilla.redhat.com/show_bug.cgi?id=872320
Bug ID: 872320 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: maven-patch-plugin - Maven Patch Plugin Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: mattias.ellert@fysast.uu.se Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://www.grid.tsl.uu.se/review/maven-patch-plugin.spec SRPM URL: http://www.grid.tsl.uu.se/review/maven-patch-plugin-1.1.1-1.fc17.src.rpm
Description: The Patch Plugin is used to apply patches to source files. Fedora Account System Username: ellert
https://bugzilla.redhat.com/show_bug.cgi?id=872320
Mattias Ellert mattias.ellert@fysast.uu.se changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |652183 (FE-JAVASIG)
https://bugzilla.redhat.com/show_bug.cgi?id=872320
Mattias Ellert mattias.ellert@fysast.uu.se changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |652183 (FE-JAVASIG) Depends On|652183 (FE-JAVASIG) |
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872320
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mizdebsk@redhat.com Assignee|nobody@fedoraproject.org |mizdebsk@redhat.com Flags| |fedora-review?
--- Comment #1 from Mikolaj Izdebski mizdebsk@redhat.com --- I am taking this review.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872320
--- Comment #2 from Mikolaj Izdebski mizdebsk@redhat.com --- It fails to build in rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=4720875
It looks like antlr dependency is missing. Please make sure the package builds in rawhide.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872320
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(mattias.ellert@fy | |sast.uu.se)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872320
Mattias Ellert mattias.ellert@fysast.uu.se changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(mattias.ellert@fy | |sast.uu.se) |
--- Comment #3 from Mattias Ellert mattias.ellert@fysast.uu.se --- It built in rawhide three weeks ago:
https://koji.fedoraproject.org/koji/taskinfo?taskID=4649093
Something has happened since then with the dependencies that has made maven more picky about dependency resolution.
The antlr.jar is not missing - antlr-tool is dragged in as a dependency. However, tha antlr-tool package does not provide any maven-fragment and maven-pom files, and the groovy package states a dependency on antlr in its pom file.
The maven version in rawhide now complains about this. It didn't do this three weeks ago, and it still doesn't complain about it in f17 and f18.
I have filed a bug on groovy about the unsatisfiable dependency: https://bugzilla.redhat.com/show_bug.cgi?id=879885
In the mean time, since the broken groovy package is not used to build the package, but only during running the test suite, I have disabled running the tests on fedora 19.
New version:
Spec URL: http://www.grid.tsl.uu.se/review/maven-patch-plugin.spec SRPM URL: http://www.grid.tsl.uu.se/review/maven-patch-plugin-1.1.1-2.fc17.src.rpm
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872320
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |879885
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872320
Bug 872320 depends on bug 879885, which changed state.
Bug 879885 Summary: antlr-tool: POM and depmap installed in wrong subpackage https://bugzilla.redhat.com/show_bug.cgi?id=879885
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872320
--- Comment #4 from Mikolaj Izdebski mizdebsk@redhat.com --- Package Review ==============
Key: - = N/A x = Pass ! = Fail
==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package contains desktop file if it is a GUI application. [x]: MUST Development files must be in a -devel package [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Package complies to the Packaging Guidelines [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [!]: MUST License file installed when any subpackage combination is installed. [x]: MUST Package consistently uses macro is (instead of hard-coded directory names). [x]: MUST Package is named using only allowed ascii characters. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Package is not relocatable. [x]: MUST Requires correct, justified where necessary. [x]: MUST Rpmlint is run on all rpms the build produces. [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: MUST Package contains systemd file(s) if in need. [x]: MUST File names are valid UTF-8. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD Buildroot is not present [x]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX tarball generation or download is documented. [x]: SHOULD SourceX / PatchY prefixed with %{name}. [x]: SHOULD SourceX is a working URL. [x]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [-]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define.
==== Java ==== [x]: MUST If source tarball includes bundled jar/class files these need to be removed prior to building [x]: MUST Packages have proper BuildRequires/Requires on jpackage-utils [x]: MUST Fully versioned dependency in subpackages, if present. [x]: MUST Javadoc documentation files are generated and included in -javadoc subpackage [x]: MUST Javadoc subpackages have Requires: jpackage-utils [x]: MUST Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) [x]: SHOULD Package has BuildArch: noarch (if possible) [x]: SHOULD Package uses upstream build method (ant/maven/etc.)
==== Maven ==== [x]: MUST Pom files have correct add_maven_depmap call [x]: MUST Old add_to_maven_depmap macro is not being used [x]: MUST Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-utils for %update_maven_depmap macro [x]: MUST If package contains pom.xml files install it (including depmaps) even when building with ant [x]: MUST Package DOES NOT use %update_maven_depmap in %post/%postun [x]: MUST Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms
Rpmlint ------- Checking: maven-patch-plugin-1.1.1-2.fc19.noarch.rpm maven-patch-plugin-javadoc-1.1.1-2.fc19.noarch.rpm maven-patch-plugin-1.1.1-2.fc19.src.rpm maven-patch-plugin.noarch: I: enchant-dictionary-not-found en_US 3 packages and 0 specfiles checked; 0 errors, 0 warnings.
Issues ------ [!]: MUST License file installed when any subpackage combination is installed. NOTICE file is not installed with javadoc subpackage.
Notes ----- The antlr-related bug should be fixed now, so you should be able to reenable tests now.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872320
--- Comment #5 from Mattias Ellert mattias.ellert@fysast.uu.se --- Thanks for fixing antlr, Running the tests on rawhide work now:
https://koji.fedoraproject.org/koji/taskinfo?taskID=4725218
New version:
Spec URL: http://www.grid.tsl.uu.se/review/maven-patch-plugin.spec SRPM URL: http://www.grid.tsl.uu.se/review/maven-patch-plugin-1.1.1-3.fc17.src.rpm
Regarding the LICENSE file in the javadoc package - that was already there:
$ rpm -qlp maven-patch-plugin-javadoc-1.1.1-2.fc17.noarch.rpm | grep LIC /usr/share/doc/maven-patch-plugin-javadoc-1.1.1/LICENSE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872320
--- Comment #6 from Mikolaj Izdebski mizdebsk@redhat.com --- The NOTICE file is still not installed with javadoc package. Once you do that I can approve the package.
Installing this file is required to satisfy requirements of the Apache License [1]. Point 4(d) of the license says "If the Work includes a "NOTICE" text file as part of its distribution, then any Derivative Works that You distribute must include a readable copy of the attribution notices contained within such NOTICE file".
[1] http://www.apache.org/licenses/LICENSE-2.0.txt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872320
--- Comment #7 from Mattias Ellert mattias.ellert@fysast.uu.se --- New version:
Spec URL: http://www.grid.tsl.uu.se/review/maven-patch-plugin.spec SRPM URL: http://www.grid.tsl.uu.se/review/maven-patch-plugin-1.1.1-4.fc17.src.rpm
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872320
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #8 from Mikolaj Izdebski mizdebsk@redhat.com --- Approved.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872320
Mattias Ellert mattias.ellert@fysast.uu.se changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #9 from Mattias Ellert mattias.ellert@fysast.uu.se --- Many thanks for the review.
New Package SCM Request ======================= Package Name: maven-patch-plugin Short Description: Maven Patch Plugin Owners: ellert Branches: f17 f18 master InitialCC: java-sig
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872320
--- Comment #10 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872320
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|652183 (FE-JAVASIG) |
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872320
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872320
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- maven-patch-plugin-1.1.1-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/maven-patch-plugin-1.1.1-4.fc17
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872320
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- maven-patch-plugin-1.1.1-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/maven-patch-plugin-1.1.1-4.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872320
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872320
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- maven-patch-plugin-1.1.1-4.fc17 has been pushed to the Fedora 17 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872320
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2012-12-01 04:51:41
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872320
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- maven-patch-plugin-1.1.1-4.fc18 has been pushed to the Fedora 18 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872320
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- maven-patch-plugin-1.1.1-4.fc17 has been pushed to the Fedora 17 stable repository.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla