[Bug 755069] New: Review Request: SpliX - Driver for QPDL/SPL2 printers (Samsung and several Xerox printers)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: SpliX - Driver for QPDL/SPL2 printers (Samsung and several Xerox printers)

https://bugzilla.redhat.com/show_bug.cgi?id=755069

Summary: Review Request: SpliX - Driver for QPDL/SPL2 printers
                    (Samsung and several Xerox printers)
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],
                    [e-mail]
    Classification: Fedora
      Story Points: ---
              Type: ---

Spec URL: http://jpopelka.fedorapeople.org/splix.spec
SRPM URL: http://jpopelka.fedorapeople.org/splix-2.0.1-0.1.20111118svn.src.rpm
Description:

SpliX is GPLv2 licensed set of drivers usable by all printer devices which
understand the QPDL (Quick Page Description Language) also known as SPL2
(Samsung Printer Language) language. It covers several Samsung, Xerox and Dell
printers.

Earlier it was possible to get RPM from
http://www.openprinting.org/download/printdriver/components/lsb3.2/contrib/R...
or build from source
http://sourceforge.net/projects/splix/files/splix/2.0.0/splix-2.0.0.tar.bz2/...

I decided to create Fedora package because the openprinting repo has been down
for quite a long time and the 2.0.0 source is not possible to build with
gcc-4.6 as shipped with Fedora-16 so there's no easy way for Fedora users how
to get SpliX working. I'm packaging the SVN nightly snapshot that has the gcc
compilation problem fixed.
See also bug #674619

[Bug 755069] Review Request: SpliX - Driver for QPDL/SPL2 printers (Samsung and several Xerox printers)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=755069

Hedayat Vatankhah  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]

[Bug 755069] Review Request: SpliX - Driver for QPDL/SPL2 printers (Samsung and several Xerox printers)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=755069

--- Comment #1 from Jiri Popelka  2011-11-21 09:46:43 EST ---
I updated the spec and srpm. The comment to source tarball contains correct
URL.
Spec URL: http://jpopelka.fedorapeople.org/splix.spec
SRPM URL: http://jpopelka.fedorapeople.org/splix-2.0.1-0.2.20111121svn.src.rpm

[Bug 755069] Review Request: SpliX - Driver for QPDL/SPL2 printers (Samsung and several Xerox printers)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=755069

Hedayat Vatankhah  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?

--- Comment #2 from Hedayat Vatankhah  2011-11-21 11:39:18 EST ---
My Review:

MUST Items:
=================== 
rpmlint output:
splix.src: W: invalid-url Source0: splix-2.0.1.20111121svn.tar.gz
splix.x86_64: E: incorrect-fsf-address /usr/share/doc/splix-2.0.1/COPYING
splix.src: W: non-coherent-filename splix-2.0.1-0.2.20111121svn.src.rpm
splix-2.0.1-0.2.20111121svn.fc16.src.rpm
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/src/ppdfile.cpp
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/src/algo0x0d.cpp
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/src/compress.cpp
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/include/rendering.h
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/src/printer.cpp
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/src/bandplane.cpp
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/src/page.cpp
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/include/colors.h
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/src/algo0x0e.cpp
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/src/document.cpp
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/src/colors.cpp
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/src/semaphore.cpp
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/src/cache.cpp
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/include/request.h
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/src/request.cpp
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/include/algorithm.h
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/include/band.h
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/include/compress.h
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/src/pstoqpdl.cpp
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/include/printer.h
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/include/algo0x11.h
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/src/algorithm.cpp
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/include/document.h
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/src/algo0x11.cpp
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/include/qpdl.h
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/src/qpdl.cpp
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/include/ppdfile.h
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/src/band.cpp
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/include/semaphore.h
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/include/bandplane.h
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/include/algo0x0d.h
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/include/cache.h
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/include/algo0x0e.h
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/src/rendering.cpp
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/src/rastertoqpdl.cpp
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/include/options.h
splix-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/splix/include/page.h
splix.spec: W: invalid-url Source0: splix-2.0.1.20111121svn.tar.gz
4 packages and 1 specfiles checked; 38 errors, 4 warnings.
---------------------------------------------------------------------
Remarks: 
- invalid url errors are fine since it is a pre-release package
- src.rpm file name doesn't match the release tag inside the package. IMO,
since new src.rpms will be generated after importing the package, it should be
fine.
- COPYING file is a bit out-dated. It would be preferred if upstream is
notified about this and update it. But doesn't look like to block the review.

Naming: OK (pre-release snapshot)
Spec file naming: OK
Maybe including ChangeLog,TODO and Thanks files as doc is appropriate
(specially Thanks file)

Licensing: OK (GPLv2, spec matches)
include license file as %doc: OK
SPEC in American English: OK
SPEC legibility: OK
Builds fine: Koji Build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3529728 OK
Locale handling: it is not handled conventionally and is included in ppd files.
No dynamic libraries OK
No external libs included OK
Directory ownership: OK
No duplicate file listing: OK
Proper permissions for files: OK
Consistency use macros: OK
Permissable code or content: OK
No large docs: OK
Doc files not required for running: OK
No header files in non-devel package: OK
No static libraries: OK
No .so files: OK
No -devel packages needed. OK
No .la files: OK
Not a GUI application, so no .desktop file. OK
No duplicate file ownership OK
Valid UTF-8 file names OK

Should Items
=============
Package includes license text
Package built in Koji
Cannot test if package functions properly
No scriptlets
No subpackages
No -devel subpackage
No file based dependency
No binaries which would need man pages

Result
========
The package looks fine and can be accepted. Only a few notes/questions:
1. Can you ask upstream to update its COPYING file and also FSF address in
copyright header in .h and .cpp files? But as far as I can see, it is not
required to be done before acceptance.

2. Maybe adding these files as %doc makes sense: ChangeLog, TODO and Thanks ?!
Specially the last one.

[Bug 755069] Review Request: SpliX - Driver for QPDL/SPL2 printers (Samsung and several Xerox printers)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=755069

Hedayat Vatankhah  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #3 from Hedayat Vatankhah  2011-11-21 12:28:02 EST ---
Considering that there is no blocking problems, it is APPROVED.

[Bug 755069] Review Request: SpliX - Driver for QPDL/SPL2 printers (Samsung and several Xerox printers)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=755069

--- Comment #4 from Jiri Popelka  2011-11-22 05:26:59 EST ---
Thanks !
I've added ChangeLog and Thanks files as doc and I'll ask upstream to update
the FSF address.

[Bug 755069] Review Request: splix - Driver for QPDL/SPL2 printers (Samsung and several Xerox printers)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=755069

Jiri Popelka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: SpliX -     |Review Request: splix -
                   |Driver for QPDL/SPL2        |Driver for QPDL/SPL2
                   |printers (Samsung and       |printers (Samsung and
                   |several Xerox printers)     |several Xerox printers)
               Flag|                            |fedora-cvs?

--- Comment #5 from Jiri Popelka  2011-11-22 05:42:12 EST ---
New Package SCM Request
=======================
Package Name: splix
Short Description: Driver for QPDL/SPL2 printers (Samsung and several Xerox
printers)
Owners: jpopelka twaugh
Branches: f15 f16

[Bug 755069] Review Request: splix - Driver for QPDL/SPL2 printers (Samsung and several Xerox printers)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=755069

--- Comment #6 from Jon Ciesla  2011-11-22 08:21:03 EST ---
Git done (by process-git-requests).

[Bug 755069] Review Request: splix - Driver for QPDL/SPL2 printers (Samsung and several Xerox printers)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=755069

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

[Bug 755069] Review Request: splix - Driver for QPDL/SPL2 printers (Samsung and several Xerox printers)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=755069

--- Comment #7 from Fedora Update System  2011-11-22 09:38:47 EST ---
splix-2.0.1-0.3.20111121svn.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/splix-2.0.1-0.3.20111121svn.fc16

[Bug 755069] Review Request: splix - Driver for QPDL/SPL2 printers (Samsung and several Xerox printers)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=755069

--- Comment #8 from Fedora Update System  2011-11-22 09:39:08 EST ---
splix-2.0.1-0.3.20111121svn.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/splix-2.0.1-0.3.20111121svn.fc15

[Bug 755069] Review Request: splix - Driver for QPDL/SPL2 printers (Samsung and several Xerox printers)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=755069

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #9 from Fedora Update System  2011-11-22 20:00:20 EST ---
splix-2.0.1-0.3.20111121svn.fc15 has been pushed to the Fedora 15 testing
repository.

[Bug 755069] Review Request: splix - Driver for QPDL/SPL2 printers (Samsung and several Xerox printers)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=755069

--- Comment #10 from Raphael Groner  2011-11-24 10:48:12 EST ---
Wow! That was fast reaction. Thanks.

[Bug 755069] Review Request: splix - Driver for QPDL/SPL2 printers (Samsung and several Xerox printers)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=755069

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |splix-2.0.1-0.3.20111121svn
                   |                            |.fc16
         Resolution|                            |ERRATA
        Last Closed|                            |2011-11-25 18:22:16

--- Comment #11 from Fedora Update System  2011-11-25 18:22:16 EST ---
splix-2.0.1-0.3.20111121svn.fc16 has been pushed to the Fedora 16 stable
repository.

[Bug 755069] Review Request: splix - Driver for QPDL/SPL2 printers (Samsung and several Xerox printers)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=755069

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|splix-2.0.1-0.3.20111121svn |splix-2.0.1-0.3.20111121svn
                   |.fc16                       |.fc15

--- Comment #12 from Fedora Update System  2011-12-10 14:36:27 EST ---
splix-2.0.1-0.3.20111121svn.fc15 has been pushed to the Fedora 15 stable
repository.

[Bug 755069] Review Request: splix - Driver for QPDL/SPL2 printers (Samsung and several Xerox printers)

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=755069

Jiri Popelka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1167731
              Flags|fedora-cvs+                 |fedora-cvs?

--- Comment #13 from Jiri Popelka  ---
Package Change Request
======================
Package Name: splix
New Branches: epel7
Owners: jpopelka twaugh

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1167731
[Bug 1167731] EPEL package request - splix

[Bug 755069] Review Request: splix - Driver for QPDL/SPL2 printers (Samsung and several Xerox printers)

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=755069

Jon Ciesla  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-cvs?                 |fedora-cvs+

[Bug 755069] Review Request: splix - Driver for QPDL/SPL2 printers (Samsung and several Xerox printers)

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=755069

--- Comment #14 from Jon Ciesla  ---
Git done (by process-git-requests).