[Bug 729972] New: Review Request: perl-Test-Mojibake - Check your source for encoding misbehavior - package-review

List overview All Threads
Download

newer

[Bug 729972] New: Review Request: perl-Test-Mojibake - Check your source for encoding misbehavior

older

[Bug 729653] New: Review Request:...

[Bug 433228] New: Review Request:...

Red Hat Bugzilla

11 Aug 2011 11 Aug '11

2:37 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

Summary: Review Request: perl-Test-Mojibake - Check your source for encoding misbehavior

https://bugzilla.redhat.com/show_bug.cgi?id=729972

Summary: Review Request: perl-Test-Mojibake - Check your source for encoding misbehavior Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: paul@city-fan.org QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---

Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Test-Mojibake/branches/fe... SRPM URL: http://www.city-fan.org/~paul/extras/perl-Test-Mojibake/perl-Test-Mojibake-0...

Description:

Many modern text editors automatically save files using UTF-8 codification. However, the perl interpreter does not expect it by default. Whilst this does not represent a big deal on (most) backend-oriented programs, Web framework (Catalyst, Mojolicious) based applications will suffer so-called Mojibake (literally: "unintelligible sequence of characters"). Even worse: if an editor saves BOM (Byte Order Mark, U+FEFF character in Unicode) at the start of a script with the executable bit set (on Unix systems), it won't execute at all, due to shebang corruption.

Avoiding codification problems is quite simple:

* Always use utf8/use common::sense when saving source as UTF-8 * Always specify =encoding utf8 when saving POD as UTF-8 * Do neither of above when saving as ISO-8859-1 * Never save BOM (not that it's wrong; just avoid it as you'll barely notice its presence when in trouble)

However, if you find yourself upgrading old code to use UTF-8 or trying to standardize a big project with many developers, each one using a different platform/editor, reviewing all files manually can be quite painful, especially in cases where some files have multiple encodings (note: it all started when I realized that gedit and derivatives are unable to open files with character conversion tables).

Enter the Test::Mojibake ;)

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

11 Aug 11 Aug

4:57 p.m.

New subject: [Bug 729972] Review Request: perl-Test-Mojibake - Check your source for encoding misbehavior

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=729972

Paul Howarth paul@city-fan.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |728329(perl-Test-Version)

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

12 Aug 12 Aug

6:17 a.m.

New subject: [Bug 729972] Review Request: perl-Test-Mojibake - Check your source for encoding misbehavior

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=729972

Iain Arnell iarnell@gmail.com changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:17 a.m.

New subject: [Bug 729972] Review Request: perl-Test-Mojibake - Check your source for encoding misbehavior

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=729972

Iain Arnell iarnell@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:20 a.m.

New subject: [Bug 729972] Review Request: perl-Test-Mojibake - Check your source for encoding misbehavior

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=729972

--- Comment #1 from Iain Arnell iarnell@gmail.com 2011-08-12 00:20:46 EDT --- Koji (success) http://koji.fedoraproject.org/koji/taskinfo?taskID=3267315

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:26 a.m.

New subject: [Bug 729972] Review Request: perl-Test-Mojibake - Check your source for encoding misbehavior

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=729972

--- Comment #2 from Iain Arnell iarnell@gmail.com 2011-08-12 00:26:12 EDT --- A very nicely documented spec. No issues at all. APPROVED.

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3267315

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic); make test passes cleanly.

Source tarballs match upstream (sha1sum): 96b654a0b0dd15c6ad327e4e59864bfd9c3c5af5 Test-Mojibake-0.3.tar.gz 96b654a0b0dd15c6ad327e4e59864bfd9c3c5af5 Test-Mojibake-0.3.tar.gz.srpm

Final provides / requires are sane:

======> perl-Test-Mojibake-0.3-2.fc17.noarch.rpm <====== ====> rpmlint perl-Test-Mojibake.noarch: W: spelling-error %description -l en_US backend -> backed, back end, back-end perl-Test-Mojibake.noarch: W: spelling-error %description -l en_US encodings -> encoding, encoding s, recordings perl-Test-Mojibake.noarch: W: spelling-error %description -l en_US gedit -> edit, geddit, g edit perl-Test-Mojibake.noarch: E: incorrect-fsf-address /usr/share/doc/perl-Test-Mojibake-0.3/LICENSE 1 packages and 0 specfiles checked; 1 errors, 3 warnings. ====> provides perl(Test::Mojibake) = 0.3 perl-Test-Mojibake = 0.3-2.fc17 ====> requires perl >= 0:5.008 perl(bytes) perl(File::Spec) perl(:MODULE_COMPAT_5.14.1) perl(strict) perl(Test::Builder) perl(utf8) perl(warnings) ====> obsoletes ====> conflicts

======> perl-Test-Mojibake-0.3-2.fc17.src.rpm <====== ====> rpmlint perl-Test-Mojibake.src: W: spelling-error %description -l en_US backend -> backed, back end, back-end perl-Test-Mojibake.src: W: spelling-error %description -l en_US encodings -> encoding, encoding s, recordings perl-Test-Mojibake.src: W: spelling-error %description -l en_US gedit -> edit, geddit, g edit perl-Test-Mojibake.src:66: W: mixed-use-of-spaces-and-tabs (spaces: line 66, tab: line 17) 1 packages and 0 specfiles checked; 0 errors, 4 warnings. ====> provides ====> requires perl(ExtUtils::MakeMaker) perl(File::Spec) perl(Pod::Coverage::TrustPod) perl(Test::Builder) perl(Test::Builder::Tester) perl(Test::CPAN::Changes) perl(Test::CPAN::Meta) perl(Test::DistManifest) perl(Test::HasVersion) perl(Test::Kwalitee) perl(Test::MinimumVersion) perl(Test::More) perl(Test::NoTabs) perl(Test::Perl::Critic) perl(Test::Pod) perl(Test::Pod::Coverage) perl(Test::Portability::Files) perl(Test::Synopsis) perl(Test::Vars) ====> obsoletes ====> conflicts

====> mock install INFO: mock.py version 1.1.12 starting... State Changed: init plugins INFO: selinux enabled State Changed: start Mock Version: 1.1.12 INFO: Mock Version: 1.1.12 State Changed: lock buildroot INFO: installing package(s): perl-Test-Mojibake-0.3-2.fc17.noarch.rpm INFO: Ignored option -c (probably due to merging -yc != -y -c)

================================================================================ Package Arch Version Repository Size ================================================================================ Installing: perl-Test-Mojibake noarch 0.3-2.fc17 /perl-Test-Mojibake-0.3-2.fc17.noarch 43 k Installing for dependencies: perl-CPAN noarch 1.9600-185.fc17 fedora 259 k perl-Digest-SHA x86_64 1:5.61-185.fc17 fedora 67 k perl-ExtUtils-MakeMaker noarch 6.57.5-185.fc17 fedora 303 k perl-ExtUtils-ParseXS noarch 1:2.2210-185.fc17 fedora 52 k perl-HTTP-Tiny noarch 0.012-185.fc17 fedora 40 k perl-Test-Harness noarch 3.23-185.fc17 fedora 287 k perl-Test-Simple noarch 0.98-185.fc17 fedora 118 k perl-devel x86_64 4:5.14.1-185.fc17 fedora 450 k python x86_64 2.7.2-4.fc16 fedora 74 k systemtap-sdt-devel x86_64 1.6-1.fc16 fedora 46 k

Transaction Summary ================================================================================ Install 11 Package(s)

Total size: 1.7 M Total download size: 1.7 M Installed size: 4.3 M

Installed: perl-Test-Mojibake.noarch 0:0.3-2.fc17

Dependency Installed: perl-CPAN.noarch 0:1.9600-185.fc17 perl-Digest-SHA.x86_64 1:5.61-185.fc17 perl-ExtUtils-MakeMaker.noarch 0:6.57.5-185.fc17 perl-ExtUtils-ParseXS.noarch 1:2.2210-185.fc17 perl-HTTP-Tiny.noarch 0:0.012-185.fc17 perl-Test-Harness.noarch 0:3.23-185.fc17 perl-Test-Simple.noarch 0:0.98-185.fc17 perl-devel.x86_64 4:5.14.1-185.fc17 python.x86_64 0:2.7.2-4.fc16 systemtap-sdt-devel.x86_64 0:1.6-1.fc16

State Changed: unlock buildroot State Changed: end

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:26 a.m.

New subject: [Bug 729972] Review Request: perl-Test-Mojibake - Check your source for encoding misbehavior

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=729972

Iain Arnell iarnell@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

10:52 a.m.

New subject: [Bug 729972] Review Request: perl-Test-Mojibake - Check your source for encoding misbehavior

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=729972

Paul Howarth paul@city-fan.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

--- Comment #3 from Paul Howarth paul@city-fan.org 2011-08-12 04:52:17 EDT --- New Package SCM Request ======================= Package Name: perl-Test-Mojibake Short Description: Check your source for encoding misbehavior Owners: pghmcfc Branches: EL-4 EL-5 EL-6 F-14 F-15 F-16 InitialCC: perl-sig

Thanks for the review Iain. I'll fix the mixed-use-of-spaces-and-tabs on import.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:01 a.m.

New subject: [Bug 729972] Review Request: perl-Test-Mojibake - Check your source for encoding misbehavior

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=729972

--- Comment #4 from Iain Arnell iarnell@gmail.com 2011-08-12 05:01:42 EDT ---

...

Thanks for the review Iain. I'll fix the mixed-use-of-spaces-and-tabs on import.

Well spotted - I lost that in all the "spelling errors". Must remember to tweak my script to make real warnings more obvious.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:41 p.m.

New subject: [Bug 729972] Review Request: perl-Test-Mojibake - Check your source for encoding misbehavior

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=729972

--- Comment #5 from Jon Ciesla limb@jcomserv.net 2011-08-12 08:41:28 EDT --- Git done (by process-git-requests).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4:53 p.m.

New subject: [Bug 729972] Review Request: perl-Test-Mojibake - Check your source for encoding misbehavior

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=729972

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4:53 p.m.

New subject: [Bug 729972] Review Request: perl-Test-Mojibake - Check your source for encoding misbehavior

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=729972

--- Comment #6 from Fedora Update System updates@fedoraproject.org 2011-08-12 10:53:36 EDT --- perl-Test-Mojibake-0.3-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-Test-Mojibake-0.3-2.fc16

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

9:20 p.m.

New subject: [Bug 729972] Review Request: perl-Test-Mojibake - Check your source for encoding misbehavior

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=729972

--- Comment #7 from Paul Howarth paul@city-fan.org 2011-08-12 15:20:20 EDT --- Rawhide and F-16 builds done. Others are waiting on perl-Test-DistManifest, which I can't do buildroot overrides for (Bug #672543).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

20 Aug 20 Aug

10:12 a.m.

New subject: [Bug 729972] Review Request: perl-Test-Mojibake - Check your source for encoding misbehavior

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=729972

--- Comment #8 from Fedora Update System updates@fedoraproject.org 2011-08-20 04:12:19 EDT --- perl-Test-Mojibake-0.3-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-Test-Mojibake-0.3-2.fc14

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

10:12 a.m.

New subject: [Bug 729972] Review Request: perl-Test-Mojibake - Check your source for encoding misbehavior

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=729972

--- Comment #9 from Fedora Update System updates@fedoraproject.org 2011-08-20 04:12:27 EDT --- perl-Test-Mojibake-0.3-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-Test-Mojibake-0.3-2.fc15

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

23 Aug 23 Aug

10:27 p.m.

New subject: [Bug 729972] Review Request: perl-Test-Mojibake - Check your source for encoding misbehavior

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=729972

--- Comment #10 from Fedora Update System updates@fedoraproject.org 2011-08-23 16:27:06 EDT --- perl-Test-Mojibake-0.3-2.fc16 has been pushed to the Fedora 16 stable repository.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

27 Aug 27 Aug

12:43 a.m.

New subject: [Bug 729972] Review Request: perl-Test-Mojibake - Check your source for encoding misbehavior

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=729972

--- Comment #11 from Fedora Update System updates@fedoraproject.org 2011-08-26 18:43:34 EDT --- perl-Test-Mojibake-0.3-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-Test-Mojibake-0.3-2.el5

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

12:43 a.m.

New subject: [Bug 729972] Review Request: perl-Test-Mojibake - Check your source for encoding misbehavior

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=729972

--- Comment #12 from Fedora Update System updates@fedoraproject.org 2011-08-26 18:43:42 EDT --- perl-Test-Mojibake-0.3-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Test-Mojibake-0.3-2.el6

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

12:43 a.m.

New subject: [Bug 729972] Review Request: perl-Test-Mojibake - Check your source for encoding misbehavior

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=729972

--- Comment #13 from Fedora Update System updates@fedoraproject.org 2011-08-26 18:43:51 EDT --- perl-Test-Mojibake-0.3-2.el4 has been submitted as an update for Fedora EPEL 4. https://admin.fedoraproject.org/updates/perl-Test-Mojibake-0.3-2.el4

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

7 Sep 7 Sep

2:02 a.m.

New subject: [Bug 729972] Review Request: perl-Test-Mojibake - Check your source for encoding misbehavior

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=729972

--- Comment #14 from Fedora Update System updates@fedoraproject.org 2011-09-06 20:02:30 EDT --- perl-Test-Mojibake-0.3-2.fc15 has been pushed to the Fedora 15 stable repository.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:24 a.m.

New subject: [Bug 729972] Review Request: perl-Test-Mojibake - Check your source for encoding misbehavior

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=729972

--- Comment #15 from Fedora Update System updates@fedoraproject.org 2011-09-06 20:24:40 EDT --- perl-Test-Mojibake-0.3-2.fc14 has been pushed to the Fedora 14 stable repository.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

14 Sep 14 Sep

2:26 a.m.

New subject: [Bug 729972] Review Request: perl-Test-Mojibake - Check your source for encoding misbehavior

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=729972

--- Comment #16 from Fedora Update System updates@fedoraproject.org 2011-09-13 20:26:55 EDT --- perl-Test-Mojibake-0.3-2.el6 has been pushed to the Fedora EPEL 6 stable repository.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:27 a.m.

New subject: [Bug 729972] Review Request: perl-Test-Mojibake - Check your source for encoding misbehavior

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=729972

--- Comment #17 from Fedora Update System updates@fedoraproject.org 2011-09-13 20:27:56 EDT --- perl-Test-Mojibake-0.3-2.el4 has been pushed to the Fedora EPEL 4 stable repository.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:28 a.m.

New subject: [Bug 729972] Review Request: perl-Test-Mojibake - Check your source for encoding misbehavior

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=729972

--- Comment #18 from Fedora Update System updates@fedoraproject.org 2011-09-13 20:28:39 EDT --- perl-Test-Mojibake-0.3-2.el5 has been pushed to the Fedora EPEL 5 stable repository.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

15 Sep 15 Sep

10:13 a.m.

New subject: [Bug 729972] Review Request: perl-Test-Mojibake - Check your source for encoding misbehavior

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=729972

Paul Howarth paul@city-fan.org changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

4670

Age (days ago)

4705

Last active (days ago)

package-review@lists.fedoraproject.org

24 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla