[Bug 837686] New: Review Request: python-tablib - Format agnostic tabular data library (XLS, JSON, YAML, CSV)
https://bugzilla.redhat.com/show_bug.cgi?id=837686
Bug ID: 837686 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: python-tablib - Format agnostic tabular data library (XLS, JSON, YAML, CSV) Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: rbean@redhat.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://threebean.org/rpm/python-tablib.spec SRPM URL: http://threebean.org/rpm/python-tablib-0.9.11.20120702git752443f-1.fc17.src.... Description: Tablib is a format-agnostic tabular dataset library, written in Python.
Output formats supported:
- Excel (Sets + Books) - JSON (Sets + Books) - YAML (Sets + Books) - HTML (Sets) - TSV (Sets) - CSV (Sets)
Fedora Account System Username: ralph
rpmlint output -------------- --- ~/rpmbuild » rpmlint {SRPMS,SPECS}/python-tablib* python-tablib.src: W: spelling-error %description -l en_US dataset -> data set, data-set, database python-tablib.src: W: invalid-url Source0: tablib-0.9.11.20120702git752443f.tar.gz SPECS/python-tablib.spec: W: invalid-url Source0: tablib-0.9.11.20120702git752443f.tar.gz 1 packages and 1 specfiles checked; 0 errors, 3 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=837686
Ralph Bean rbean@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |837688
https://bugzilla.redhat.com/show_bug.cgi?id=837686
Luke Macken lmacken@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |lmacken@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=837686
Luke Macken lmacken@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(rbean@redhat.com)
--- Comment #1 from Luke Macken lmacken@redhat.com --- Package Review ==============
Key: - = N/A x = Pass ! = Fail ? = Not evaluated
==== Generic ==== [x]: EXTRA Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: EXTRA Spec file according to URL is the same as in SRPM. [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [!]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package contains desktop file if it is a GUI application. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Fully versioned dependency in subpackages, if present. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [x]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GENERATED FILE", "*No copyright* UNKNOWN", "UNKNOWN", "LGPL (v2.1 or later) (with incorrect FSF address)", "GPL (v2 or later)", "*No copyright* Public domain", "BSD (4 clause)", "LGPL (v2.1 or later) GENERATED FILE", "MIT/X11 (BSD like)", "LGPL (v2.1 or later)" For detailed output of licensecheck see file: /home/lmacken/code/github.com/FedoraReview/837686-python- tablib/licensecheck.txt [x]: MUST License file installed when any subpackage combination is installed. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package is named using only allowed ascii characters. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Requires correct, justified where necessary. [x]: MUST Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [x]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [!]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise justified. [!]: SHOULD SourceX / PatchY prefixed with %{name}. Note: Patch0: 0001-Py3-support.patch (0001-Py3-support.patch) [x]: SHOULD SourceX is a working URL. [x]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [!]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define.
Rpmlint ------- Checking: python-tablib-0.9.11.20120702git752443f-1.fc17.src.rpm python3-tablib-0.9.11.20120702git752443f-1.fc17.noarch.rpm python-tablib-0.9.11.20120702git752443f-1.fc17.noarch.rpm python-tablib.src: W: spelling-error %description -l en_US dataset -> data set, data-set, database python-tablib.src: W: invalid-url Source0: tablib-0.9.11.20120702git752443f.tar.gz python3-tablib.noarch: W: spelling-error %description -l en_US dataset -> data set, data-set, database python3-tablib.noarch: E: incorrect-fsf-address /usr/lib/python3.2/site-packages/tablib/packages/xlwt3/Utils.py python3-tablib.noarch: E: non-executable-script /usr/lib/python3.2/site-packages/tablib/packages/xlwt3/Formatting.py 0644L /usr/bin/env python3-tablib.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python3.2/site-packages/tablib/packages/xlwt3/Formatting.py python-tablib.noarch: W: spelling-error %description -l en_US dataset -> data set, data-set, database python-tablib.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/tablib/packages/xlwt/Formatting.py 0644L /usr/bin/env python-tablib.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/tablib/packages/xlwt/Utils.py 3 packages and 0 specfiles checked; 5 errors, 4 warnings.
Rpmlint (installed packages) ---------------------------- # rpmlint python-tablib python3-tablib python-tablib.noarch: I: enchant-dictionary-not-found en_US python-tablib.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/tablib/packages/xlwt/Formatting.py 0644L /usr/bin/env python-tablib.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/tablib/packages/xlwt/Utils.py python3-tablib.noarch: E: incorrect-fsf-address /usr/lib/python3.2/site-packages/tablib/packages/xlwt3/Utils.py python3-tablib.noarch: E: non-executable-script /usr/lib/python3.2/site-packages/tablib/packages/xlwt3/Formatting.py 0644L /usr/bin/env python3-tablib.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python3.2/site-packages/tablib/packages/xlwt3/Formatting.py 2 packages and 0 specfiles checked; 5 errors, 0 warnings. # echo 'rpmlint-done:'
Requires -------- python3-tablib-0.9.11.20120702git752443f-1.fc17.noarch.rpm (rpmlib, GLIBC filtered):
python(abi) = 3.2 python3-PyYAML
python-tablib-0.9.11.20120702git752443f-1.fc17.noarch.rpm (rpmlib, GLIBC filtered):
PyYAML python(abi) = 2.7
Provides -------- python3-tablib-0.9.11.20120702git752443f-1.fc17.noarch.rpm:
python3-tablib = 0.9.11.20120702git752443f-1.fc17
python-tablib-0.9.11.20120702git752443f-1.fc17.noarch.rpm:
python-tablib = 0.9.11.20120702git752443f-1.fc17
MD5-sum check -------------
Generated by fedora-review 0.2.0git External plugins:
https://bugzilla.redhat.com/show_bug.cgi?id=837686
Ralph Bean rbean@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(rbean@redhat.com) |
--- Comment #2 from Ralph Bean rbean@redhat.com --- Spec URL: http://threebean.org/rpm/python-tablib.spec SRPM URL: http://threebean.org/rpm/python-tablib-0.9.11.20120702git752443f-2.fc17.src....
^^ updated spec with a comment pointing to the upstream bug for the patch.
Note that upstream considers their bundling to be full forks and a part of their project. https://github.com/dreamhost/cliff/issues/13
https://bugzilla.redhat.com/show_bug.cgi?id=837686
--- Comment #3 from Luke Macken lmacken@redhat.com --- Assuming those forked packages are kosher, then all of the MUST items are taken care of. The SHOULD's aren't a big deal, but there are a few simple rpmlint complaints that should probably get taken care of.
https://bugzilla.redhat.com/show_bug.cgi?id=837686
--- Comment #4 from Ralph Bean rbean@redhat.com --- Spec URL: http://threebean.org/rpm/python-tablib.spec SRPM URL: http://threebean.org/rpm/python-tablib-0.9.11.20120702git752443f-3.fc17.src....
Updated with a sed blurb to remove the shebangs.
https://bugzilla.redhat.com/show_bug.cgi?id=837686
Luke Macken lmacken@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #5 from Luke Macken lmacken@redhat.com --- Looks good!
APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=837686
Ralph Bean rbean@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #6 from Ralph Bean rbean@redhat.com --- New Package SCM Request ======================= Package Name: python-tablib Short Description: Format agnostic tabular data library (XLS, JSON, YAML, CSV) Owners: ralph Branches: f17 f16 el6 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=837686
--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Luke, please take ownership of review BZs. Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=837686
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=837686
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- python-tablib-0.9.11.20120702git752443f-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-tablib-0.9.11.20120702git7524...
https://bugzilla.redhat.com/show_bug.cgi?id=837686
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- python-tablib-0.9.11.20120702git752443f-3.el6 has been pushed to the Fedora EPEL 6 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=837686
Ralph Bean rbean@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2012-07-05 22:46:39
https://bugzilla.redhat.com/show_bug.cgi?id=837686
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- python-tablib-0.9.11.20120702git752443f-5.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-tablib-0.9.11.20120702git7524...
https://bugzilla.redhat.com/show_bug.cgi?id=837686
Haïkel Guémar karlthered@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |karlthered@gmail.com Flags|fedora-cvs+ |fedora-cvs?
--- Comment #11 from Haïkel Guémar karlthered@gmail.com --- Package Change Request ====================== Package Name: python-tablib New Branches: epel7 Owners: hguemar apevec
This package is needed to fix CentOS/RHEL 7 gates in OpenStack infra http://logs.openstack.org/89/209289/1/check/gate-puppet-glance-puppet-beaker...
https://bugzilla.redhat.com/show_bug.cgi?id=837686
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=837686
--- Comment #12 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla