Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: exe - eXe eLearning XHTML editor
https://bugzilla.redhat.com/show_bug.cgi?id=432205
------- Additional Comments From j.w.r.degoede(a)hhs.nl 2008-03-16 10:18 EST -------
(In reply to comment #3)
1.) You install the .desktop file with desktop-file-install;
Please add BuildRequires: desktop-file-utils
Will do (once other points below are clear).
2.) Requires: firefox
This doesn't seem correct to me. It doesn't work with seamonkey or konqueror?
Wouldn't requiring webclient be better?
No it needs firefox (maybe now xulrunner) its an application written in Xul,
deriving from the firefox xul code, some error dialogs etc, still clearly show this.
3.) This could possibly be conditionally present for fedora < 9
%{python_sitelib}/%{name}*.egg-info
Good point.
4.) RPMLint:
Needs some love; either address those or explain why are they harmless:
exe.noarch: W: devel-file-in-non-devel-package
/usr/share/exe/twisted/internet/iocpreactor/_iocp.c
exe.noarch: W: devel-file-in-non-devel-package
/usr/share/exe/twisted/spread/cBanana.c
I'll fix these, it looks like the included copy of twisted is a full copy, I'll
strip it down to only the needed parts.
exe.noarch: E: arch-independent-package-contains-binary-or-object
/usr/share/exe/templates/mimetex.cgi
Hmm, how weird, I'll ask upstream why thats there (and in the mean time remove it).
exe.noarch: W: class-path-in-manifest
/usr/share/exe/templates/geogebra.jar
By the way -- java file? You don't depend on java.
Yes, exe is an editor for eleanring material, which is meant to be viewed with a
webbrowser, I guess this is an applet for one of the elearning template's which
are part of one eXe.
exe.src:37: W: rpm-buildroot-usage %build rm -rf $RPM_BUILD_ROOT
exe.src: E: no-cleaning-of-buildroot %install
Move "rm -rf $RPM_BUILD_ROOT" from %build to %install
Will do.
5.) Did you check the functionality? The package seemed to be
problematic with
my Firefox setup; I couldn't close the window, etc. I'll be more specific if it
worked for you.
I packaged this because a college of mine asked for it (I recently converted him
from Ubuntu to Fedora), he has been using it for a while. The window not closing
part is "normal", you should get a dialoge saying that you should use the menu
to exit instead though, do you get that dialog?
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.