[Bug 1901114] New: Review Request: rust-pam - wrappers for PAM

https://bugzilla.redhat.com/show_bug.cgi?id=1901114

Bug ID: 1901114
           Summary: Review Request: rust-pam - wrappers for PAM
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: http://www.usenix.org.uk/rpm/rust-pam.spec
SRPM URL: http://www.usenix.org.uk/rpm/rust-pam-0.7.0-1.fc34.src.rpm
Description: Safe Rust wrappers for PAM authentication
Fedora Account System Username: eneville

Safe Rust wrappers for PAM authentication. Requires rust-pam-sys, which is my
first review request.

[Bug 1901114] Review Request: rust-pam - wrappers for PAM

https://bugzilla.redhat.com/show_bug.cgi?id=1901114

[e-mail]  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841 (FE-NEEDSPONSOR)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1901114] Review Request: rust-pam - wrappers for PAM

https://bugzilla.redhat.com/show_bug.cgi?id=1901114

--- Comment #1 from Robert-André Mauchin 🐧  ---

- Please explain your patches in a comment and provide upstream PR you have
made

# Initial patched metadata
# Bump X to X, link to upstream PR
Patch0:         pam-fix-metadata.diff
# Fix XXX
Patch1:         pam-fix-authenticator.diff

- You must include the license files with %license in %files devel:

%files          devel
%license LICENSE-APACHE LICENSE-MIT

- You should include CHANGELOG.md in %doc

%doc CHANGELOG.md README.md

- Build fails:

Error: 
 Problem: nothing provides requested (crate(rpassword/default) >= 4.0.0 with
crate(rpassword/default) < 5.0.0~)

[Bug 1901114] Review Request: rust-pam - wrappers for PAM

https://bugzilla.redhat.com/show_bug.cgi?id=1901114

Robert-André Mauchin 🐧  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1901118

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1901118
[Bug 1901118] Review Request: rust-pleaser - user execution with regex
configuration

[Bug 1901114] Review Request: rust-pam - wrappers for PAM

https://bugzilla.redhat.com/show_bug.cgi?id=1901114

--- Comment #2 from Robert-André Mauchin 🐧  ---
You should bump the dep to rpassword to 5 if possible

[Bug 1901114] Review Request: rust-pam - wrappers for PAM

https://bugzilla.redhat.com/show_bug.cgi?id=1901114

--- Comment #3 from [e-mail]  ---
Hello, I believe the changes requested are now ready in the following:

Spec URL: http://www.usenix.org.uk/rpm/rust-pam.spec
SRPM URL: http://www.usenix.org.uk/rpm/rust-pam-0.7.0-1.fc35.src.rpm

Thanks

[Bug 1901114] Review Request: rust-pam - wrappers for PAM

https://bugzilla.redhat.com/show_bug.cgi?id=1901114

Robert-André Mauchin 🐧  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review+

--- Comment #4 from Robert-André Mauchin 🐧  ---
Package approved. You still need to find a sponsor as described in
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group

[Bug 1901114] Review Request: rust-pam - wrappers for PAM

https://bugzilla.redhat.com/show_bug.cgi?id=1901114

Robert-André Mauchin 🐧  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841 (FE-NEEDSPONSOR)     |
              Flags|fedora-review+              |fedora-review?

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1901114] Review Request: rust-pam - wrappers for PAM

https://bugzilla.redhat.com/show_bug.cgi?id=1901114

Robert-André Mauchin 🐧  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+

--- Comment #5 from Robert-André Mauchin 🐧  ---
Sponsored.

[Bug 1901114] Review Request: rust-pam - wrappers for PAM

https://bugzilla.redhat.com/show_bug.cgi?id=1901114

--- Comment #6 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-pam

[Bug 1901114] Review Request: rust-pam - wrappers for PAM

https://bugzilla.redhat.com/show_bug.cgi?id=1901114
Bug 1901114 depends on bug 1901106, which changed state.

Bug 1901106 Summary: Review Request: rust-pam-sys - FFI rust crate
https://bugzilla.redhat.com/show_bug.cgi?id=1901106

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |CURRENTRELEASE