[Bug 727155] New: Review Request: rubygem-fast_gettext - A simple, fast, memory-efficient and threadsafe implementation of GetText

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: rubygem-fast_gettext - A simple, fast, memory-efficient and threadsafe implementation of GetText

https://bugzilla.redhat.com/show_bug.cgi?id=727155

Summary: Review Request: rubygem-fast_gettext - A simple, fast,
                    memory-efficient and threadsafe implementation of
                    GetText
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],
                    [e-mail]
    Classification: Fedora
      Story Points: ---
              Type: ---

Spec URL: http://people.redhat.com/vondruch/rubygem-fast_gettext.spec
SRPM URL:
http://people.redhat.com/vondruch/rubygem-fast_gettext-0.5.13-1.fcf17.src.rp...
Description: A simple, fast, memory-efficient and threadsafe implementation of
GetText

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3243249

Please pay special attention to %{geminstdir}/lib/fast_gettext/vendor folder,
since this folder contains some slightly modified files from original gettext
rubygem. I am not 100% convinced that is it possible to bundle such files with
such license.

[Bug 727155] Review Request: rubygem-fast_gettext - A simple, fast, memory-efficient and threadsafe implementation of GetText

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=727155

Vít Ondruch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |705519

[Bug 727155] Review Request: rubygem-fast_gettext - A simple, fast, memory-efficient and threadsafe implementation of GetText

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=727155

Bohuslav Kabrda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |738590

[Bug 727155] Review Request: rubygem-fast_gettext - A simple, fast, memory-efficient and threadsafe implementation of GetText

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=727155

Bohuslav Kabrda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Bohuslav Kabrda  2011-09-23 06:33:53 EDT ---
* Licensing: The mentioned files in lib/vendor directory are not Ruby or
GPLv2+, but Ruby or LGPLv2+ -- see
https://github.com/mutoh/gettext/blob/master/README.rdoc (the library, where
the files are from).

* It would be good to query upstream not to bundle the gettext library, but use
it as a separate dependency.

* I would consider moving readme.md into the main package, as it contains
information about licensing, which I think should be present in the main
package.

Otherwise, the package seems to be ok, but I would like to get the three points
above clear.

[Bug 727155] Review Request: rubygem-fast_gettext - A simple, fast, memory-efficient and threadsafe implementation of GetText

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=727155

Bohuslav Kabrda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]

[Bug 727155] Review Request: rubygem-fast_gettext - A simple, fast, memory-efficient and threadsafe implementation of GetText

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=727155

Bohuslav Kabrda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Bug 727155] Review Request: rubygem-fast_gettext - A simple, fast, memory-efficient and threadsafe implementation of GetText

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=727155

Vít Ondruch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |719908

[Bug 727155] Review Request: rubygem-fast_gettext - A simple, fast, memory-efficient and threadsafe implementation of GetText

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=727155

--- Comment #2 from Vít Ondruch  2011-10-19 09:40:58 EDT ---
(In reply to comment #1)
> Licensing: The mentioned files in lib/vendor directory are not Ruby or
>
> GPLv2+, but Ruby or LGPLv2+ -- see
> https://github.com/mutoh/gettext/blob/master/README.rdoc (the library, where
> the files are from).

The file you are referring says: "This program is licenced under the same
licence as Ruby", i.e. GPLv2 or Ruby => I am going to remove the "+", with the
exception of 'setup.rb' file which is not present in the folder. So it is not
LGPLv2+ IMO.
> It would be good to query upstream not to bundle the gettext library, but use
>
> it as a separate dependency.

I have checked the files once more. Although the files are coming from gettext
library, it seems that they are more or less modified. Moreover, the original
gettext package seems to be death, so it makes no sense IMO.
> I would consider moving readme.md into the main package, as it contains
>
> information about licensing, which I think should be present in the main
> package.

DONE.
> Otherwise, the package seems to be ok, but I would like to get the three points
> above clear.

Please note that I have also updated the package to the latest upstream
version.

Spec URL: http://people.redhat.com/vondruch/rubygem-fast_gettext.spec
SRPM URL:
http://people.redhat.com/vondruch/rubygem-fast_gettext-0.6.1-1.fcf17.src.rpm

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3443784

[Bug 727155] Review Request: rubygem-fast_gettext - A simple, fast, memory-efficient and threadsafe implementation of GetText

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=727155

Vít Ondruch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|719908                      |

[Bug 727155] Review Request: rubygem-fast_gettext - A simple, fast, memory-efficient and threadsafe implementation of GetText

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=727155

--- Comment #3 from Bohuslav Kabrda  2011-10-20 04:34:01 EDT ---
(In reply to comment #2)
> (In reply to comment #1)
> > Licensing: The mentioned files in lib/vendor directory are not Ruby or
> >
> > GPLv2+, but Ruby or LGPLv2+ -- see
> > https://github.com/mutoh/gettext/blob/master/README.rdoc (the library, where
> > the files are from).
>
> The file you are referring says: "This program is licenced under the same
> licence as Ruby", i.e. GPLv2 or Ruby => I am going to remove the "+", with the
> exception of 'setup.rb' file which is not present in the folder. So it is not
> LGPLv2+ IMO.

I was refering to "... same licence as Ruby(See COPYING) or LGPL ...". So the
whole license tag should be something like

License: Public Domain and ((GPLv2+ or Ruby) or LGPLv2+)
> > It would be good to query upstream not to bundle the gettext library, but use
> >
> > it as a separate dependency.
>
> I have checked the files once more. Although the files are coming from gettext
> library, it seems that they are more or less modified. Moreover, the original
> gettext package seems to be death, so it makes no sense IMO.

I agree that the modifications made to files from gettext are non-trivial and
that gettext is more or less dead. So it is not a problem for this package.
> > I would consider moving readme.md into the main package, as it contains
> >
> > information about licensing, which I think should be present in the main
> > package.
>
> DONE.
> > Otherwise, the package seems to be ok, but I would like to get the three points
> > above clear.
>
> Please note that I have also updated the package to the latest upstream
> version.
>
> Spec URL: http://people.redhat.com/vondruch/rubygem-fast_gettext.spec
> SRPM URL:
> http://people.redhat.com/vondruch/rubygem-fast_gettext-0.6.1-1.fcf17.src.rpm
>
> Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3443784

Before this package is approved, I would certainly like to make the License
clear, otherwise everything is ok.

[Bug 727155] Review Request: rubygem-fast_gettext - A simple, fast, memory-efficient and threadsafe implementation of GetText

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=727155

--- Comment #4 from Vít Ondruch  2011-10-20 05:37:45 EDT ---
(In reply to comment #3)
> I was refering to "... same licence as Ruby(See COPYING) or LGPL ...". So the
> whole license tag should be something like

Please could you be more specific? The only reference to LGPL is in file
"usr/lib/ruby/gems/1.8/gems/fast_gettext-0.6.1/lib/fast_gettext/vendor/README.rdoc"
on line 155. This refers to file which is not included in the gem an will never
be. Am I missing something?

[Bug 727155] Review Request: rubygem-fast_gettext - A simple, fast, memory-efficient and threadsafe implementation of GetText

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=727155

Bohuslav Kabrda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #5 from Bohuslav Kabrda  2011-10-20 06:31:11 EDT ---
(In reply to comment #4)
> (In reply to comment #3)
> > I was refering to "... same licence as Ruby(See COPYING) or LGPL ...". So the
> > whole license tag should be something like
>
> Please could you be more specific? The only reference to LGPL is in file
> "usr/lib/ruby/gems/1.8/gems/fast_gettext-0.6.1/lib/fast_gettext/vendor/README.rdoc"
> on line 155. This refers to file which is not included in the gem an will never
> be. Am I missing something?

Sorry, my mistake. I was looking at a newer license of the forked gettext
library. The version that was forked was licensed under Ruby at the time, so
your License field is OK.

This package is APPROVED.

[Bug 727155] Review Request: rubygem-fast_gettext - A simple, fast, memory-efficient and threadsafe implementation of GetText

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=727155

Vít Ondruch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #6 from Vít Ondruch  2011-10-20 06:42:27 EDT ---
Thank you for your review!

New Package SCM Request
=======================
Package Name: rubygem-fast_gettext
Short Description: A simple, fast, memory-efficient and threadsafe
implementation of GetText
Owners: vondruch
Branches: 
InitialCC:

[Bug 727155] Review Request: rubygem-fast_gettext - A simple, fast, memory-efficient and threadsafe implementation of GetText

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=727155

--- Comment #7 from Jon Ciesla  2011-10-20 08:10:15 EDT ---
Git done (by process-git-requests).

[Bug 727155] Review Request: rubygem-fast_gettext - A simple, fast, memory-efficient and threadsafe implementation of GetText

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=727155

Vít Ondruch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE
        Last Closed|                            |2011-10-20 08:59:49

[Bug 727155] Review Request: rubygem-fast_gettext - A simple, fast, memory-efficient and threadsafe implementation of GetText

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=727155

Vít Ondruch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs+                 |fedora-cvs?

--- Comment #8 from Vít Ondruch  2011-11-29 08:22:39 EST ---
Package Change Request
======================
Package Name: rubygem-fast_gettext
New Branches: f16
Owners: vondruch
InitialCC:

[Bug 727155] Review Request: rubygem-fast_gettext - A simple, fast, memory-efficient and threadsafe implementation of GetText

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=727155

--- Comment #9 from Jon Ciesla  2011-11-29 08:35:55 EST ---
Git done (by process-git-requests).