[Bug 2132701] New: Review Request: libloc Library to determine a location of someone on the Internet
https://bugzilla.redhat.com/show_bug.cgi?id=2132701
Bug ID: 2132701 Summary: Review Request: libloc Library to determine a location of someone on the Internet Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ppisar@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://ppisar.fedorapeople.org/libloc/libloc.spec SRPM URL: https://ppisar.fedorapeople.org/libloc/libloc-0.9.15-1.fc38.src.rpm Description: This is a lightweight library which can be used to query the IPFire Location database.
Fedora Account System Username: ppisar
https://bugzilla.redhat.com/show_bug.cgi?id=2132701
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: libloc |Review Request: libloc - |Library to determine a |Library to determine a |location of someone on the |location of someone on the |Internet |Internet
https://bugzilla.redhat.com/show_bug.cgi?id=2132701
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? CC| |benson_muite@emailplus.org Assignee|nobody@fedoraproject.org |benson_muite@emailplus.org Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=2132701
--- Comment #1 from Benson Muite benson_muite@emailplus.org --- Issues from fedora-review
Issues: ======= - Package contains the mandatory BuildRequires and Requires:. Note: Explicit dependency on perl-devel is not allowed See: https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/ - systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in libloc-tools See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_scriptlets
Unversioned so-files -------------------- perl-libloc: /usr/lib64/perl5/vendor_perl/auto/Location/Location.so python3-libloc: /usr/lib64/python3.11/site-packages/_location.so
https://bugzilla.redhat.com/show_bug.cgi?id=2132701
--- Comment #2 from Petr Pisar ppisar@redhat.com --- (In reply to Benson Muite from comment #1)
- Package contains the mandatory BuildRequires and Requires:. Note: Explicit dependency on perl-devel is not allowed See: https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/
fedora-review lies. A build-time dependency on perl-devel is perfectly fine. It must be there because the package builds an XS Perl module, a module written in C which includes Perl header files and which links to libperl.so library. The guidelines says so https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/#_build_dependencies.
- systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in libloc-tools See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_scriptlets
Thanks for noticing it. I though that systemd sciptlets were already replaced with file triggers. I added the scriptlets.
Unversioned so-files
perl-libloc: /usr/lib64/perl5/vendor_perl/auto/Location/Location.so python3-libloc: /usr/lib64/python3.11/site-packages/_location.so
This is another imperfection of fedora-review. Both files are plugins into the respective language interpreters, installed into a path not known to a dynamic linker. Both Perl and Python expect unversioned SO files.
An updates spec file is located on the same address.
https://bugzilla.redhat.com/show_bug.cgi?id=2132701
--- Comment #3 from Benson Muite benson_muite@emailplus.org --- Ok on versioning Location.so and _location.so link to versioned libloc https://docs.fedoraproject.org/en-US/packaging-guidelines/#_downstream_so_na...
https://bugzilla.redhat.com/show_bug.cgi?id=2132701
--- Comment #4 from Benson Muite benson_muite@emailplus.org --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Package contains the mandatory BuildRequires and Requires:. Note: Explicit dependency on perl-devel is not allowed See: https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GNU Lesser General Public License, Version 2.1", "Unknown or generated", "FSF Unlimited License (with License Retention) FSF All Permissive License Artistic License GNU Lesser General Public License, Version 2.1 GNU General Public License, Version 2 Creative Commons Attribution-ShareAlike 4.0", "GNU General Public License v2.0 or later", "GNU Lesser General Public License v2.1 or later". 50 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/libloc/review-libloc/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/pkgconfig(ignition-transport-devel, libmodsecurity-devel, nexus-devel, uid_wrapper, ignition-math-devel, pkgconf-pkg-config, dontpanic-devel, bemenu-devel, xalan-c-devel, openshadinglanguage- devel) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [?]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in libloc-tools [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in perl- libloc , python3-libloc , libloc-tools [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Scriptlets must be sane, if used. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [?]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define default_database_file %{_sharedstatedir}/location/database.db [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Cannot parse rpmlint output:
Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output:
Rpmlint (installed packages) ---------------------------- /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 7
python3-libloc.x86_64: W: unused-direct-shlib-dependency /usr/lib64/python3.11/site-packages/_location.so /lib64/libresolv.so.2 python3-libloc.x86_64: W: unused-direct-shlib-dependency /usr/lib64/python3.11/site-packages/_location.so /lib64/libcrypto.so.3 libloc.x86_64: E: unused-direct-shlib-dependency /usr/lib64/libloc.so.1.0.2 /lib64/libresolv.so.2 libloc-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/.dwz/libloc-0.9.15-1.fc38.x86_64 libloc-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/libloc.so.1.0.2-0.9.15-1.fc38.x86_64.debug python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyExc_ValueError (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so _Py_TrueStruct (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyExc_IndexError (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyList_Type (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so _Py_NoneStruct (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyExc_IOError (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyExc_OSError (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so _Py_NotImplementedStruct (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyExc_StopIteration (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyExc_TypeError (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so _Py_FalseStruct (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyExc_SystemError (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyObject_SelfIter (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyType_GenericAlloc (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyLong_AsLong (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyModule_AddObject (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyErr_SetFromErrno (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyUnicode_FromFormat (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyList_Append (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyBytes_FromStringAndSize (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyArg_ParseTupleAndKeywords (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyList_Size (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyErr_Format (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so _Py_Dealloc (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyModule_AddIntConstant (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyList_New (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyUnicode_FromString (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyObject_AsFileDescriptor (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyList_GetItem (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyErr_SetString (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyArg_ParseTuple (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyUnicode_AsUTF8 (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyModule_AddStringConstant (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyType_Ready (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyErr_SetNone (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyLong_FromLong (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyModule_Create2 (/usr/lib64/python3.11/site-packages/_location.so) python3-libloc.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_location.so PyLong_FromUnsignedLong (/usr/lib64/python3.11/site-packages/_location.so) libloc-debuginfo.x86_64: E: statically-linked-binary /usr/lib/debug/.dwz/libloc-0.9.15-1.fc38.x86_64 libloc-tools.noarch: W: only-non-binary-in-usr-lib libloc-tools.noarch: W: no-manual-page-for-binary location libloc-tools.noarch: W: no-manual-page-for-binary location-importer libloc-debugsource.x86_64: E: no-binary libloc.x86_64: E: missing-hash-section /usr/lib64/libloc.so.1.0.2 libloc-debuginfo.x86_64: E: missing-PT_GNU_STACK-section /usr/lib/debug/.dwz/libloc-0.9.15-1.fc38.x86_64 libloc-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/lib64/libloc.so.1.0.2-0.9.15-1.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/lib64/libloc.so.1.0.2-0.9.15-1.fc38.x86_64.debug'
libloc-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz libloc-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz libloc-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/4c/d144e604ac2ee289f50d91bbcdd6573ea8997d ../../../.build-id/4c/d144e604ac2ee289f50d91bbcdd6573ea8997d 7 packages and 0 specfiles checked; 6 errors, 48 warnings, 6 badness; has taken 2.9 s
Unversioned so-files -------------------- perl-libloc: /usr/lib64/perl5/vendor_perl/auto/Location/Location.so python3-libloc: /usr/lib64/python3.11/site-packages/_location.so
Source checksums ---------------- https://source.ipfire.org/releases/libloc/libloc-0.9.15.tar.gz : CHECKSUM(SHA256) this package : 934a66d9f88234e0c609c4b117d33dcddd7160b3ea3767ec0324a55a3d090252 CHECKSUM(SHA256) upstream package : 934a66d9f88234e0c609c4b117d33dcddd7160b3ea3767ec0324a55a3d090252
Requires -------- libloc (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libresolv.so.2()(64bit) rtld(GNU_HASH)
libloc-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libloc(x86-64) libloc.so.1()(64bit)
perl-libloc (rpmlib, GLIBC filtered): libc.so.6()(64bit) libloc.so.1()(64bit) libloc.so.1(LIBLOC_1)(64bit) libperl.so.5.36()(64bit) perl(:MODULE_COMPAT_5.36.0) perl(:VERSION) perl(Exporter) perl(XSLoader) perl(strict) perl(warnings) rtld(GNU_HASH)
python3-libloc (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcrypto.so.3()(64bit) libloc.so.1()(64bit) libloc.so.1(LIBLOC_1)(64bit) libresolv.so.2()(64bit) python(abi) python3.11dist(psycopg2) rtld(GNU_HASH)
libloc-tools (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python3 python3-libloc
libloc-debuginfo (rpmlib, GLIBC filtered):
libloc-debugsource (rpmlib, GLIBC filtered):
Provides -------- libloc: libloc libloc(x86-64) libloc.so.1()(64bit) libloc.so.1(LIBLOC_1)(64bit)
libloc-devel: libloc-devel libloc-devel(x86-64) pkgconfig(libloc)
perl-libloc: perl(Location) perl-libloc perl-libloc(x86-64)
python3-libloc: python-libloc python-location python3-libloc python3-libloc(x86-64) python3-location python3.11-libloc python3.11-location python3.11dist(libloc) python3dist(libloc)
libloc-tools: libloc-tools
libloc-debuginfo: debuginfo(build-id) libloc-debuginfo libloc-debuginfo(x86-64) libloc.so.1.0.2-0.9.15-1.fc38.x86_64.debug()(64bit)
libloc-debugsource: libloc-debugsource libloc-debugsource(x86-64)
Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -n libloc Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, C/C++, Perl, Shell-api Disabled plugins: Ruby, Java, Haskell, PHP, fonts, SugarActivity, R, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Comments : a) Bug for fedora-review https://bugzilla.redhat.com/show_bug.cgi?id=2134376 , associated pull request https://pagure.io/FedoraReview/pull-request/459 b) Builds seem ok https://copr.fedorainfracloud.org/coprs/fed500/libloc/build/4912517/ c) Assume the line "# ??? psycopg2" is in the spec file and not "Requires: python3-psycopg2" because the package is only available for EPEL https://packages.fedoraproject.org/pkgs/python3-psycopg2/python3-psycopg2/ - if so, maybe Python RPM should not be built initially? The package seems to be needed for src/python/location/database.py though tests seem to pass. d) Python package has examples/python as documentation. Should doc/private-key.pem doc/public-key.pem also be included in documentation? e) Why differentiate between %define and %global for database location? f) Have not checked German locale handling
https://bugzilla.redhat.com/show_bug.cgi?id=2132701
--- Comment #5 from Benson Muite benson_muite@emailplus.org --- g) psycopg3 is also available https://www.psycopg.org/ - maybe worth checking if upstream will upgrade to this h) Perhaps the description can be updated to "determine the approximate physical location corresponding to a requesting ip address", which is probably more accurate than "location of someone on the internet"
https://bugzilla.redhat.com/show_bug.cgi?id=2132701
--- Comment #6 from Petr Pisar ppisar@redhat.com ---
c) Assume the line "# ??? psycopg2" is in the spec file and not "Requires: python3-psycopg2" because the package is only available for EPEL https://packages.fedoraproject.org/pkgs/python3-psycopg2/python3-psycopg2/ - if so, maybe Python RPM should not be built initially? The package seems to be needed for src/python/location/database.py though tests seem to pass.
The comment is a remnant of a notice to myself the check whether the dependency on psycopg2 is needed. The dependency is needed. I will remove the comment. The dependency is expressed with "python3.11dist(psycopg2)". The dependency is satisfied in Fedora 38. Yes, the dependency is not used when running the tests. It's noticed in "# Run-time" section if BuildRequires.
d) Python package has examples/python as documentation. Should doc/private-key.pem doc/public-key.pem also be included in documentation?
Those are cryptographical keys. I think keys should not be in a documentation. Keys should be unique to a user. I left them out intentionally. It minimizes a chance that someone will use them in a production.
e) Why differentiate between %define and %global for database location?
There are subtle differences between global and define. It does not matter here. I will changed it into %global the guidelines recommends it https://docs.fedoraproject.org/en-US/packaging-guidelines/#_global_preferred_over_define.
f) Have not checked German locale handling
It's just a translation of program messages into German language.
g) psycopg3 is also available https://www.psycopg.org/ - maybe worth checking if upstream will upgrade to this
I will tell it to the upstream and point to https://www.varrazzo.com/blog/2020/11/07/psycopg3-adaptation/.
h) Perhaps the description can be updated to "determine the approximate physical location corresponding to a requesting ip address", which is probably more accurate than "location of someone on the internet"
I took the summary from the upstream. I will rephrase it to speak about an IP address rather than about someone. I do not want to use "physical" location since the database returns country codes and autonomous system numbers. It does not speak geographical coordinates. Maybe "locality" could be a better word.
An updates spec file is available on the same address.
https://bugzilla.redhat.com/show_bug.cgi?id=2132701
--- Comment #7 from Petr Pisar ppisar@redhat.com --- (In reply to Petr Pisar from comment #6)
g) psycopg3 is also available https://www.psycopg.org/ - maybe worth checking if upstream will upgrade to this
I will tell it to the upstream and point to https://www.varrazzo.com/blog/2020/11/07/psycopg3-adaptation/.
https://bugzilla.ipfire.org/show_bug.cgi?id=12953
https://bugzilla.redhat.com/show_bug.cgi?id=2132701
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #8 from Benson Muite benson_muite@emailplus.org --- Found https://packages.fedoraproject.org/pkgs/python-psycopg2/python3-psycopg2/ Using Requires-Dist: psycopg2 instead of Requires: python3dist(psycopg2) seems ok according to https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/#_auto...
Thanks for your patience. Approved.
https://bugzilla.redhat.com/show_bug.cgi?id=2132701
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: libloc - |Review Request: libloc - |Library to determine a |Library to determine a |location of someone on the |location of an IP address |Internet |in the Internet
--- Comment #9 from Petr Pisar ppisar@redhat.com --- Thanks for the review.
https://bugzilla.redhat.com/show_bug.cgi?id=2132701
--- Comment #10 from Petr Pisar ppisar@redhat.com --- https://pagure.io/releng/fedora-scm-requests/issue/48180
https://bugzilla.redhat.com/show_bug.cgi?id=2132701
--- Comment #11 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libloc
https://bugzilla.redhat.com/show_bug.cgi?id=2132701
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED Fixed In Version| |libloc-0.9.15-1.fc38
https://bugzilla.redhat.com/show_bug.cgi?id=2132701
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2022-10-13 15:18:28
https://bugzilla.redhat.com/show_bug.cgi?id=2132701
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-4091e204d7 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-4091e204d7
https://bugzilla.redhat.com/show_bug.cgi?id=2132701
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-34b42842af has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-34b42842af
https://bugzilla.redhat.com/show_bug.cgi?id=2132701
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-34b42842af has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-34b42842af *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-34b42842af
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2132701
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-2c11531f9e has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-2c11531f9e
https://bugzilla.redhat.com/show_bug.cgi?id=2132701
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-4091e204d7 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-4091e204d7 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-4091e204d7
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2132701
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-2c11531f9e has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-2c11531f9e *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-2c11531f9e
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2132701
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|RAWHIDE |ERRATA
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-34b42842af has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2132701
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-2c11531f9e has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2132701
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-4091e204d7 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com