[Bug 1668387] New: Review Request: poetry - Python dependency management and packaging made easy
https://bugzilla.redhat.com/show_bug.cgi?id=1668387
Bug ID: 1668387 Summary: Review Request: poetry - Python dependency management and packaging made easy Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: decathorpe@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://decathorpe.fedorapeople.org/packages/poetry.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/poetry-0.12.11-1.fc29.src.rpm
Description: Poetry helps you declare, manage and install dependencies of Python projects, ensuring you have the right stack everywhere.
Fedora Account System Username: decathorpe
koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=32193963
Note: This package does probably still require some additional work before it can be accepted.
- It includes a self-update function that probably has to be patched out for the fedora package.
- poetry seems to produce "setup.py" files that are possibly broken (because they use distutils.core::setup instead of setuptools::setup, but the former doesn't support all the same expected keyword arguments, for example for extra or optional dependencies).
This package also depends on my pending reviews for the pylev, pastel, clikit, and cleo python packages.
https://bugzilla.redhat.com/show_bug.cgi?id=1668387
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1666293, 1666294, 1666306, | |1666311
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1666293 [Bug 1666293] Review Request: python-pastel - Bring colors to your terminal https://bugzilla.redhat.com/show_bug.cgi?id=1666294 [Bug 1666294] Review Request: python-pylev - Liberally licensed, pure Python Levenshtein implementation https://bugzilla.redhat.com/show_bug.cgi?id=1666306 [Bug 1666306] Review Request: python-clikit - Utilities to build beautiful and testable CLIs https://bugzilla.redhat.com/show_bug.cgi?id=1666311 [Bug 1666311] Review Request: python-cleo - Create beautiful and testable command-line interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=1668387 Bug 1668387 depends on bug 1666294, which changed state.
Bug 1666294 Summary: Review Request: python-pylev - Liberally licensed, pure Python Levenshtein implementation https://bugzilla.redhat.com/show_bug.cgi?id=1666294
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1668387
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Flags| |fedora-review?
--- Comment #1 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=1668387
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |projects.rg@smart.ms
--- Comment #2 from Raphael Groner projects.rg@smart.ms --- What's the benefit towards PyPI and setuptools?
https://bugzilla.redhat.com/show_bug.cgi?id=1668387
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- (In reply to Raphael Groner from comment #2)
What's the benefit towards PyPI and setuptools?
poetry manages the python package metadata in a machine-readable format (TOML), and allows exporting to the usual "setup.py", i.e. for uploading to PyPI. So it can be used as a "convenience wrapper" around the standard tools. (Neal, please correct me if I'm wrong here.)
https://bugzilla.redhat.com/show_bug.cgi?id=1668387
--- Comment #4 from Neal Gompa ngompa13@gmail.com --- (In reply to Fabio Valentini from comment #3)
(In reply to Raphael Groner from comment #2)
What's the benefit towards PyPI and setuptools?
poetry manages the python package metadata in a machine-readable format (TOML), and allows exporting to the usual "setup.py", i.e. for uploading to PyPI. So it can be used as a "convenience wrapper" around the standard tools. (Neal, please correct me if I'm wrong here.)
That's basically correct. It replaces conventional setup.py, requirements.txt, Pipfile, Pipfile.lock, etc. with a PEP 518 compliant configuration in pyproject.toml and a simple poetry.lock file for projects that want dependency locking. It supports both virtualenv-oriented stuff (a la pipenv) and normal stuff (a la pip and friends) while also providing backwards compatibility to those tools when you elect to upload your project managed by poetry to PyPI.
https://bugzilla.redhat.com/show_bug.cgi?id=1668387
--- Comment #5 from Raphael Groner projects.rg@smart.ms --- (In reply to Neal Gompa from comment #4)
(In reply to Fabio Valentini from comment #3)
…
Great, thanks for your explanations.
https://bugzilla.redhat.com/show_bug.cgi?id=1668387
Orion Poplawski orion@nwra.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |orion@nwra.com
--- Comment #6 from Orion Poplawski orion@nwra.com --- Neal - any progress here?
https://bugzilla.redhat.com/show_bug.cgi?id=1668387
--- Comment #7 from Neal Gompa ngompa13@gmail.com --- (In reply to Orion Poplawski from comment #6)
Neal - any progress here?
I'm waiting to resolve bug 1666293. Once that's done, I can process the rest of it.
https://bugzilla.redhat.com/show_bug.cgi?id=1668387
--- Comment #8 from Fabio Valentini decathorpe@gmail.com --- Just FYI, poetry claims to be incompatible with requests-toolbelt >= 0.9.0, and on f30, 0.9.1 is available. I'm not sure if we should continue working on this. The upstream developer acts like he's hostile (or completely indifferent) regarding distribution packaging.
https://bugzilla.redhat.com/show_bug.cgi?id=1668387
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NOTABUG Last Closed| |2019-05-12 14:18:21
--- Comment #9 from Fabio Valentini decathorpe@gmail.com --- I officially give up, as the upstream developer has not reacted at all to any of of the relevant, open bug reports blocking this package for months.
https://github.com/sdispater/poetry/issues/866 https://github.com/sdispater/cachy/issues/2 https://github.com/sdispater/pastel/issues/5 https://github.com/toastdriven/pylev/issues/11
https://bugzilla.redhat.com/show_bug.cgi?id=1668387 Bug 1668387 depends on bug 1666293, which changed state.
Bug 1666293 Summary: Review Request: python-pastel - Bring colors to your terminal https://bugzilla.redhat.com/show_bug.cgi?id=1666293
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NOTABUG
https://bugzilla.redhat.com/show_bug.cgi?id=1668387 Bug 1668387 depends on bug 1666306, which changed state.
Bug 1666306 Summary: Review Request: python-clikit - Utilities to build beautiful and testable CLIs https://bugzilla.redhat.com/show_bug.cgi?id=1666306
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NOTABUG
https://bugzilla.redhat.com/show_bug.cgi?id=1668387 Bug 1668387 depends on bug 1666311, which changed state.
Bug 1666311 Summary: Review Request: python-cleo - Create beautiful and testable command-line interfaces https://bugzilla.redhat.com/show_bug.cgi?id=1666311
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NOTABUG
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com