https://bugzilla.redhat.com/show_bug.cgi?id=1688810
Bug ID: 1688810 Summary: Review Request: python-astunparse An AST unparser for Python. Product: Fedora Version: 30 Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: ruslanpisarev@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://copr-be.cloud.fedoraproject.org/results/rpisarev/tensorflow/fedora-3... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/rpisarev/tensorflow/fedora-3...
Description: An AST unparser for Python.
PyPI: https://pypi.org/project/astunparse/ Documentation: https://astunparse.readthedocs.io/en/latest/
https://bugzilla.redhat.com/show_bug.cgi?id=1688810
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |quantum.analyst@gmail.com
--- Comment #1 from Elliott Sales de Andrade quantum.analyst@gmail.com --- Please remove the Python 2 subpackage.
https://bugzilla.redhat.com/show_bug.cgi?id=1688810
--- Comment #2 from ruslan ruslanpisarev@gmail.com --- The Python 2 subpackage was removed:
https://copr-be.cloud.fedoraproject.org/results/rpisarev/tensorflow/fedora-3... https://copr-be.cloud.fedoraproject.org/results/rpisarev/tensorflow/fedora-3...
https://bugzilla.redhat.com/show_bug.cgi?id=1688810
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |quantum.analyst@gmail.com Flags| |fedora-review?
--- Comment #3 from Elliott Sales de Andrade quantum.analyst@gmail.com --- - Please fix the description; it is a jumble of various sentences and image captions. - License text is: BSD and Python - You can remove the manual Requires and use the automatic generator. You can also enable it on older releases if you are building there as well:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_automatic...
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Python Software Foundation License version 2 BSD 3-clause "New" or "Revised" License", "Unknown or generated", "*No copyright* BSD (unspecified)". 21 files have unknown license. Detailed output of licensecheck in 1688810-python-astunparse/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [!]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python3-astunparse-1.6.2-2.fc30.noarch.rpm python-astunparse-1.6.2-2.fc30.src.rpm python3-astunparse.noarch: W: spelling-error Summary(en_US) unparser -> sparser, parser python3-astunparse.noarch: W: spelling-error %description -l en_US unparser -> sparser, parser python3-astunparse.noarch: W: spelling-error %description -l en_US unparse -> parse python3-astunparse.noarch: W: spelling-error %description -l en_US ast -> sat, as, at python-astunparse.src: W: spelling-error Summary(en_US) unparser -> sparser, parser python-astunparse.src: W: spelling-error %description -l en_US unparser -> sparser, parser python-astunparse.src: W: spelling-error %description -l en_US unparse -> parse python-astunparse.src: W: spelling-error %description -l en_US ast -> sat, as, at 2 packages and 0 specfiles checked; 0 errors, 8 warnings.
Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_CA.utf8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_CA.utf8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_CA.utf8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). sh: /usr/bin/python: No such file or directory python3-astunparse.noarch: W: spelling-error Summary(en_US) unparser -> sparser, parser python3-astunparse.noarch: W: spelling-error %description -l en_US unparser -> sparser, parser python3-astunparse.noarch: W: spelling-error %description -l en_US unparse -> parse python3-astunparse.noarch: W: spelling-error %description -l en_US ast -> sat, as, at python3-astunparse.noarch: W: invalid-url URL: https://github.com/simonpercivall/astunparse <urlopen error [Errno -2] Name or service not known> 1 packages and 0 specfiles checked; 0 errors, 5 warnings.
Requires -------- python3-astunparse (rpmlib, GLIBC filtered): python(abi) python3.7dist(six) python3.7dist(wheel) python3dist(six) python3dist(wheel)
Provides -------- python3-astunparse: python3-astunparse python3.7dist(astunparse) python3dist(astunparse)
Source checksums ---------------- https://files.pythonhosted.org/packages/source/a/astunparse/astunparse-1.6.2... : CHECKSUM(SHA256) this package : dab3e426715373fd76cd08bb1abe64b550f5aa494cf1e32384f26fd60961eb67 CHECKSUM(SHA256) upstream package : dab3e426715373fd76cd08bb1abe64b550f5aa494cf1e32384f26fd60961eb67
Generated by fedora-review 0.6.1 (29df316) last change: 2019-03-10 Command line :/home/elliott/code/FedoraReview/try-fedora-review -m fedora-rawhide-x86_64 -b 1688810 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, BATCH, EPEL7, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1688810
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1688810
--- Comment #4 from Elliott Sales de Andrade quantum.analyst@gmail.com --- This is actually a duplicate of bug 1667661.
https://bugzilla.redhat.com/show_bug.cgi?id=1688810
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |DUPLICATE Last Closed| |2019-11-07 02:12:44
--- Comment #5 from Elliott Sales de Andrade quantum.analyst@gmail.com ---
*** This bug has been marked as a duplicate of bug 1667661 ***
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com