[Bug 1392457] New: Re-review Request for renaming python package to python2

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392457

Bug ID: 1392457
           Summary: Re-review Request for renaming python package to
                    python2
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL:
https://github.com/fedora-python/python2-spec/blob/py2rename/python.spec

Diff from master branch:
https://github.com/fedora-python/python2-spec/compare/py2rename

SRPM URL: https://cstratak.fedorapeople.org/python2-2.7.12-9.fc26.src.rpm

Fedora Account System Username: cstratak

With Python 2 reaching end of life at 2020 and also having by default in Fedora
the Python 3 version of the language it only makes sense to explicitly reflect
in the name of the package, the respective major version. Also in the future,
there is a high possibility that python will refer only to python3.

Thus I would like to rename python to python2.

The package still virtually provide the python name. All the changes in the
SPEC file are in the posted github link. The change is intended only for
rawhide.

This can be tested by using a rawhide machine and enabling my copr repo [0]
where I have a build with the renamed python: dnf copr enable cstratak/Python2

Then by invoking "dnf update" or "dnf update python" the python2 package will
be installed, replacing the python package with no conflicts.

[0] https://copr.fedorainfracloud.org/coprs/cstratak/Python2/build/473988/

[Bug 1392457] Re-review Request for renaming python package to python2

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392457

Charalampos Stratakis  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]

[Bug 1392457] Re-review Request for renaming python package to python2

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392457

Miro Hrončok  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
              Flags|                            |fedora-review?

--- Comment #1 from Miro Hrončok  ---
Posting raw links for Fedora Review to work.

Spec URL:
https://raw.githubusercontent.com/fedora-python/python2-spec/py2rename/pytho...
SRPM URL: https://cstratak.fedorapeople.org/python2-2.7.12-9.fc26.src.rpm

[Bug 1392457] Re-review Request for renaming python package to python2

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392457

--- Comment #2 from Miro Hrončok  ---
You need to rename the specfile as well:

- Spec file name must match the spec package %{name}, in the format
  %{name}.spec.
  Note: python.spec should be python2.spec
  See:
  http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name

[Bug 1392457] Re-review Request for renaming python package to python2

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392457

--- Comment #3 from Charalampos Stratakis  ---
Renamed the specfile to python2.spec.

Also removed the provides for python-abi (as only python(abi) is required by
other packages).

Spec URL:
https://raw.githubusercontent.com/fedora-python/python2-spec/py2rename/pytho...

SRPM URL: https://cstratak.fedorapeople.org/python2-2.7.12-9.fc26.src.rpm

[Bug 1392457] Re-review Request for renaming python package to python2

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392457

--- Comment #4 from Charalampos Stratakis  ---
Also another addition. Implemented PEP 394[0], at this commit [1] so now all
the binaries are provided in the form of bin2 and bin2.7

[0] https://www.python.org/dev/peps/pep-0394/

[1]
https://github.com/fedora-python/python2-spec/commit/9e09f0f095c684e3bddfb6e...

[Bug 1392457] Re-review Request for renaming python package to python2

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392457

--- Comment #5 from Miro Hrončok  ---
Review exception granted: https://fedorahosted.org/fpc/ticket/660#comment:2

One thing: Please change source URL to use https (geppetto, 17:11:52)

After you do that or any necessary changes as well, post again Spec and SRPM
URL and I will double check the new obsoletes/provides.

[Bug 1392457] Re-review Request for renaming python package to python2

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392457

--- Comment #6 from Charalampos Stratakis  ---
https://github.com/fedora-python/python2-spec/commit/ce1eee682beab6c572b56f4...

Done.

Reposting the links:

SPEC:
https://raw.githubusercontent.com/fedora-python/python2-spec/py2rename/pytho...

SRPM: https://cstratak.fedorapeople.org/python2-2.7.12-9.fc26.src.rpm

[Bug 1392457] Re-review Request for renaming python package to python2

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392457

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Neal Gompa  ---
(In reply to Charalampos Stratakis from comment #3)
> Also removed the provides for python-abi (as only python(abi) is required by
> other packages).

This is still a system Python package, so shouldn't that be there?

[Bug 1392457] Re-review Request for renaming python package to python2

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392457

Miro Hrončok  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #8 from Miro Hrončok  ---
(In reply to Neal Gompa from comment #7)
> (In reply to Charalampos Stratakis from comment #3)
> > Also removed the provides for python-abi (as only python(abi) is required by
> > other packages).
>
> This is still a system Python package, so shouldn't that be there?

Nothing requires python-abi.

(In reply to Charalampos Stratakis from comment #6)
> https://github.com/fedora-python/python2-spec/commit/
> ce1eee682beab6c572b56f47de4c4751e28e2813
>
> Done.
>
> Reposting the links:
>
> SPEC:
> https://raw.githubusercontent.com/fedora-python/python2-spec/py2rename/
> python2.spec
>
> SRPM: https://cstratak.fedorapeople.org/python2-2.7.12-9.fc26.src.rpm

Checked the upgrade path. It worked. Double checked all the provides and
obsoletes:

(Lines after line breaks are obsoletes).

python2:
    python = 2.7.12-9.fc26
    python(abi) = 2.7
    python(x86-64) = 2.7.12-9.fc26
    python2 = 2.7.12-9.fc26
    python2(x86-64) = 2.7.12-9.fc26
    python27 = 2.7.12-9.fc26

python < 2.7.12-9

python2-debug:
    libpython2.7_d.so.1.0()(64bit)
    pkgconfig(python-2.7-debug) = 2.7
    pkgconfig(python-debug) = 2.7
    pkgconfig(python2-debug) = 2.7
    python-debug = 2.7.12-9.fc26
    python-debug(x86-64) = 2.7.12-9.fc26
    python2-debug = 2.7.12-9.fc26
    python2-debug(x86-64) = 2.7.12-9.fc26

python-debug < 2.7.12-9

python2-devel:
    pkgconfig(python) = 2.7
    pkgconfig(python-2.7) = 2.7
    pkgconfig(python2) = 2.7
    python-devel = 2.7.12-9.fc26
    python-devel(x86-64) = 2.7.12-9.fc26
    python2-devel = 2.7.12-9.fc26
    python2-devel(x86-64) = 2.7.12-9.fc26

python-devel < 2.7.12-9

python2-libs:
    libpython2.7.so.1.0()(64bit)
    python(abi) = 2.7
    python-libs = 2.7.12-9.fc26
    python-libs(x86-64) = 2.7.12-9.fc26
    python2-libs = 2.7.12-9.fc26
    python2-libs(x86-64) = 2.7.12-9.fc26
    python2.7dist(python) = 2.7.12
    python2dist(python) = 2.7.12

python-libs < 2.7.12-9

python2-test:
    python-test = 2.7.12-9.fc26
    python-test(x86-64) = 2.7.12-9.fc26
    python2-test = 2.7.12-9.fc26
    python2-test(x86-64) = 2.7.12-9.fc26

python-test < 2.7.12-9

python2-tkinter:
    python-tkinter = 2.7.12-9.fc26
    python-tkinter(x86-64) = 2.7.12-9.fc26
    python2-tkinter = 2.7.12-9.fc26
    python2-tkinter(x86-64) = 2.7.12-9.fc26
    tkinter = 2.7.12-9.fc26
    tkinter(x86-64) = 2.7.12-9.fc26
    tkinter2 = 2.7.12-9.fc26
    tkinter2(x86-64) = 2.7.12-9.fc26

tkinter < 2.7.12-9

python2-tools:
    python-tools = 2.7.12-9.fc26
    python-tools(x86-64) = 2.7.12-9.fc26
    python2-tools = 2.7.12-9.fc26
    python2-tools(x86-64) = 2.7.12-9.fc26

python-tools < 2.7.12-9

Package APPROVED.

[Bug 1392457] Review request: python2 - the python programming language in its version 2.x

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392457

Charalampos Stratakis  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Re-review Request for       |Review request: python2 -
                   |renaming python package to  |the python programming
                   |python2                     |language in its version 2.x

[Bug 1392457] Review request: python2 - An interpreted, interactive, object-oriented programming language

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392457

Charalampos Stratakis  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review request: python2 -   |Review request: python2 -
                   |the python programming      |An interpreted,
                   |language in its version 2.x |interactive,
                   |                            |object-oriented programming
                   |                            |language

[Bug 1392457] Review request: python2 - An interpreted, interactive, object-oriented programming language

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392457

--- Comment #9 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python2

[Bug 1392457] Review request: python2 - An interpreted, interactive, object-oriented programming language

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392457

Charalampos Stratakis  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED
   Fixed In Version|                            |python2-2.7.12-9.fc26

[Bug 1392457] Review request: python2 - An interpreted, interactive, object-oriented programming language

https://bugzilla.redhat.com/show_bug.cgi?id=1392457

Petr Viktorin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
                 CC|                            |[e-mail]
         Resolution|---                         |CURRENTRELEASE
        Last Closed|                            |2017-08-07 07:04:48