[Bug 228499] New: Review Request: hunspell-sl - Slovenian hunspell dictionaries

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228499

Summary: Review Request: hunspell-sl - Slovenian hunspell
                    dictionaries
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: http://people.redhat.com/caolanm/hunspell/hunspell-sl.spec
SRPM URL: http://people.redhat.com/caolanm/hunspell/hunspell-sl-0.20021008-1.src.rpm
Description: Slovenian hunspell dictionaries

Similar to 227811

[Bug 228499] Review Request: hunspell-sl - Slovenian hunspell dictionaries

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hunspell-sl - Slovenian hunspell dictionaries

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228499

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
OtherBugsDependingO|163776                      |163778
              nThis|                            |
               Flag|                            |fedora-review?

------- Additional Comments From [e-mail]  2007-02-14 06:37 EST -------
Upstream version has been updated, current one is 27-Jan-2007. Fortunately the
difference is only the licensing terms (switched from GPL to dual GPL/LGPL).
However in order to respect all packaging rules, please update the rpm.

GOOD

- package meets naming guidelines
- package meets packaging guidelines 
- spec file legible, in am. english
- the package builds in mock for devel/x86_64, generates a noarch (which is
consistent with the fact that basically it includes only 3 text files)
- the license GPL stated in the tag is the same as the web site says and is
  included in the package
- there are only 2 files (word lists) + a short doc with instructions and
license clearance, so no need for -doc and no .la, .pc, static files
- no missing BR
- no locales
- not relocatable
- owns all files/directories that it creates, does not take ownership of other
files/dirs
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- rpmlint output is silent
- code, not content
- nothing in %doc affects runtime
- no need for .desktop file

MUSTFIX:
source does not match upstream
6ff19cff25411c5ce7bd127e54395fe7441ab27d  sl_SI.zip (upstream)
b95fa4b31683ed3768532d4dc41b7a584bd795fc  sl_SI.zip (src.rpm)

[Bug 228499] Review Request: hunspell-sl - Slovenian hunspell dictionaries

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hunspell-sl - Slovenian hunspell dictionaries

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228499

------- Additional Comments From [e-mail]  2007-02-14 06:44 EST -------
updated to latest dict release as:

http://people.redhat.com/caolanm/hunspell/hunspell-sl-0.20070127-1.src.rpm

[Bug 228499] Review Request: hunspell-sl - Slovenian hunspell dictionaries

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hunspell-sl - Slovenian hunspell dictionaries

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228499

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2007-02-14 07:02 EST -------
Problems fixed, APPROVED

[Bug 228499] Review Request: hunspell-sl - Slovenian hunspell dictionaries

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hunspell-sl - Slovenian hunspell dictionaries

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228499

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2007-02-15 09:48 EST -------
 27644 (hunspell-sl): Build on target fedora-development-extras succeeded.

[Bug 228499] Review Request: hunspell-sl - Slovenian hunspell dictionaries

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hunspell-sl - Slovenian hunspell dictionaries

https://bugzilla.redhat.com/show_bug.cgi?id=228499

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora
            Version|devel                       |rawhide