https://bugzilla.redhat.com/show_bug.cgi?id=2074709
Bug ID: 2074709 Summary: Review Request: python-qt6 - PyQt6 is Python bindings for Qt6 Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: thunderbirdtr@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://pagure.io/python-qt6/raw/main/f/python-qt6.spec SRPM URL: https://pagure.io/python-qt6/raw/main/f/python-qt6-6.2.3-1.fc36.src.rpm Description: PyQt6 is Python bindings for Qt6 Fedora Account System Username: thunderbirdtr
https://bugzilla.redhat.com/show_bug.cgi?id=2074709
Onuralp Sezer thunderbirdtr@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #1 from Onuralp Sezer thunderbirdtr@gmail.com --- This package require python-pyqt6-sip for installation and Review Link: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2074732
https://bugzilla.redhat.com/show_bug.cgi?id=2074709
Miro Hrončok mhroncok@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@redhat.com
--- Comment #2 from Miro Hrončok mhroncok@redhat.com --- Despite the unusual python-qt5 name, this package should be named python-pyqt6 / python3-pyqt6.
https://bugzilla.redhat.com/show_bug.cgi?id=2074709
Miro Hrončok mhroncok@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2074732
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2074732 [Bug 2074732] Review Request: python-pyqt6-sip - The sip module support for PyQt6
https://bugzilla.redhat.com/show_bug.cgi?id=2074709
--- Comment #3 from Miro Hrončok mhroncok@redhat.com --- %python_provide macro is deprecated and should not be used, see https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/#_the_...
https://bugzilla.redhat.com/show_bug.cgi?id=2074709
--- Comment #4 from Onuralp Sezer thunderbirdtr@gmail.com ---
%python_provide removed.
BuildRequires: cmake(Qt6RemoteObjects) added
Extra files added.
%{python3_sitearch}/PyQt6/QtQuick3D.* %{python3_sitearch}/PyQt6/QtRemoteObjects.*
New file names
Spec URL: https://pagure.io/python-qt6/raw/main/f/python-pyqt6.spec SRPM URL: https://pagure.io/python-qt6/raw/main/f/python-pyqt6-6.2.3-1.fc36.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=2074709
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Flags| |fedora-review? CC| |ngompa13@gmail.com
--- Comment #5 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=2074709
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=2074709
--- Comment #6 from Neal Gompa ngompa13@gmail.com --- Spec review:
%global rpm_macros_dir %(d=%{_rpmconfigdir}/macros.d; [ -d $d ] || d=%{_sysconfdir}/rpm; echo $d)
Just get rid of all this and use %{_rpmmacrodir} wherever %{rpm_macros_dir} was used.
#patch0 -p1
Drop this, it's unused.
--qmake-setting 'QMAKE_CFLAGS_RELEASE="%{optflags}"' \ --qmake-setting 'QMAKE_CXXFLAGS_RELEASE="%{optflags} `pkg-config --cflags dbus-python`"' \ --qmake-setting 'QMAKE_LFLAGS_RELEASE="%{?__global_ldflags}"'
Use %{build_cflags}, %{build_cxxflags}, and %{build_ldflags} accordingly.
https://bugzilla.redhat.com/show_bug.cgi?id=2074709 Bug 2074709 depends on bug 2074732, which changed state.
Bug 2074732 Summary: Review Request: python-pyqt6-sip - The sip module support for PyQt6 https://bugzilla.redhat.com/show_bug.cgi?id=2074732
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |CURRENTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=2074709
Mads Kiilerich mads@kiilerich.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mads@kiilerich.com
--- Comment #7 from Mads Kiilerich mads@kiilerich.com --- FWIW: I'm looking into upgrading tortoisehg to use qt6. It seems like I need this package and am blocked.
(Note: this is also tracked on https://pagure.io/fedora-kde/SIG/issue/127 )
https://bugzilla.redhat.com/show_bug.cgi?id=2074709
--- Comment #8 from Onuralp Sezer thunderbirdtr@gmail.com --- (In reply to Mads Kiilerich from comment #7)
FWIW: I'm looking into upgrading tortoisehg to use qt6. It seems like I need this package and am blocked.
(Note: this is also tracked on https://pagure.io/fedora-kde/SIG/issue/127 )
Sorry for bit delay I am gonna taking care of it.
https://bugzilla.redhat.com/show_bug.cgi?id=2074709
Sandro Mani manisandro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |manisandro@gmail.com
--- Comment #9 from Sandro Mani manisandro@gmail.com --- *** Bug 2124098 has been marked as a duplicate of this bug. ***
https://bugzilla.redhat.com/show_bug.cgi?id=2074709
Onuralp Sezer thunderbirdtr@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(ngompa13@gmail.co | |m)
--- Comment #10 from Onuralp Sezer thunderbirdtr@gmail.com ---
Scratch build results
F38 and F37 builds fine
https://koji.fedoraproject.org/koji/taskinfo?taskID=91655388 https://koji.fedoraproject.org/koji/taskinfo?taskID=91655383
I did all the changes Neal asked as well.
Spec URL: https://pagure.io/python-qt6/raw/main/f/python-pyqt6.spec SRPM URL: https://pagure.io/python-qt6/raw/main/f/python-pyqt6-6.3.1-1.fc38.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=2074709
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ |needinfo?(ngompa13@gmail.co | |m) | Status|ASSIGNED |POST
--- Comment #11 from Neal Gompa ngompa13@gmail.com --- Looks good to me.
Package review notes:
* Builds and installs * Package licensing is correct and license files are correctly installed * Package naming follows packaging policy
https://bugzilla.redhat.com/show_bug.cgi?id=2074709
--- Comment #12 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pyqt6
https://bugzilla.redhat.com/show_bug.cgi?id=2074709
Sandro Mani manisandro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(thunderbirdtr@fed | |oraproject.org) CC| |thunderbirdtr@fedoraproject | |.org
--- Comment #13 from Sandro Mani manisandro@gmail.com --- @thunderbirdtr@fedoraproject.org Could you import the package? Or feel free to add me to the package and I'm happy to help.
https://bugzilla.redhat.com/show_bug.cgi?id=2074709
Onuralp SEZER thunderbirdtr@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(thunderbirdtr@fed | |oraproject.org) |
--- Comment #14 from Onuralp SEZER thunderbirdtr@fedoraproject.org --- PyQt6 is already in F36-37-38 and sure I can add you as well.
https://bugzilla.redhat.com/show_bug.cgi?id=2074709
--- Comment #15 from Sandro Mani manisandro@gmail.com --- My bad, I was looking for python-qt6... Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=2074709
--- Comment #16 from Onuralp SEZER thunderbirdtr@fedoraproject.org --- No problem, you're welcome :)
https://bugzilla.redhat.com/show_bug.cgi?id=2074709
TR Bentley home@trarbentley.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |home@trarbentley.net
--- Comment #17 from TR Bentley home@trarbentley.net --- This mat not be the place but pyqtwebengine-5.15.4-4.fc37 also needs to be updated for QT6 as it provides PyQY6 QTWebEngineWidgets.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com