https://bugzilla.redhat.com/show_bug.cgi?id=2038636
Bug ID: 2038636 Summary: Review Request: rust-nu-path - Path handling library for Nushell Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: michel@michel-slm.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://salimma.fedorapeople.org/specs/rust/rust-nu-path.spec SRPM URL: https://salimma.fedorapeople.org/specs/rust/rust-nu-path-0.42.0-1.fc35.src.r... Description: Path handling library for Nushell. Fedora Account System Username: salimma
https://bugzilla.redhat.com/show_bug.cgi?id=2038636
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |decathorpe@gmail.com
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- There's no LICENSE file in published crates. That is not acceptable wrt/ the MIT license, as it requires redistributed sources to contain the license text.
If there's a license file in the upstream repository, you can include it from there as a second Source file, until upstream fixes things and published crates contain the LICENSE file.
In any case, please report this issue with upstream (but I think you already did).
https://bugzilla.redhat.com/show_bug.cgi?id=2038636
--- Comment #2 from Michel Alexandre Salim michel@michel-slm.name --- Updated to 0.60 with license added and link to upstream PR adding the license
Spec URL: https://download.copr.fedorainfracloud.org/results/salimma/nu-wip/fedora-raw... SRPM URL: https://download.copr.fedorainfracloud.org/results/salimma/nu-wip/fedora-raw...
https://bugzilla.redhat.com/show_bug.cgi?id=2038636
Davide Cavalca dcavalca@fb.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |dcavalca@fb.com CC| |dcavalca@fb.com Status|NEW |ASSIGNED Flags| |fedora-review?
--- Comment #3 from Davide Cavalca dcavalca@fb.com --- Taking this review
https://bugzilla.redhat.com/show_bug.cgi?id=2038636
Davide Cavalca dcavalca@fb.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #4 from Davide Cavalca dcavalca@fb.com --- Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2038636
--- Comment #5 from Michel Alexandre Salim michel@michel-slm.name --- Thanks!
src/fedora/pkgs-sig-rust ❯ fedpkg request-repo rust-nu-path 2038636 https://pagure.io/releng/fedora-scm-requests/issue/43506
src/fedora/pkgs-sig-rust took 6s ❯ fedpkg request-branch --repo rust-nu-path --all-releases https://pagure.io/releng/fedora-scm-requests/issue/43507 https://pagure.io/releng/fedora-scm-requests/issue/43508 https://pagure.io/releng/fedora-scm-requests/issue/43509
https://bugzilla.redhat.com/show_bug.cgi?id=2038636
--- Comment #6 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-nu-path
https://bugzilla.redhat.com/show_bug.cgi?id=2038636
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-a7b8406617 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-a7b8406617
https://bugzilla.redhat.com/show_bug.cgi?id=2038636
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-00805ead9b has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-00805ead9b
https://bugzilla.redhat.com/show_bug.cgi?id=2038636
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-f12eda9c87 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-f12eda9c87
https://bugzilla.redhat.com/show_bug.cgi?id=2038636
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-f12eda9c87 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-f12eda9c87 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-f12eda9c87
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2038636
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-00805ead9b has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-00805ead9b *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-00805ead9b
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2038636
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-a7b8406617 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-a7b8406617 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-a7b8406617
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2038636
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2022-04-17 22:21:12
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-00805ead9b has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2038636
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-f12eda9c87 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2038636
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-a7b8406617 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org