https://bugzilla.redhat.com/show_bug.cgi?id=1228089
Bug ID: 1228089 Summary: Review Request: php-zetacomponents-base - Zeta Base Component Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fedora@famillecollet.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/9ea96b23650357863b6162... SRPM URL: http://rpms.famillecollet.com/SRPMS/php-zetacomponents-base-1.9-2.remi.src.r... Description: This is the base package of the Zeta components, offering the basic support that all Components need. In the first version this will be the autoload support.
Fedora Account System Username: remi
https://bugzilla.redhat.com/show_bug.cgi?id=1228089
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias|zetacomponents/base |
https://bugzilla.redhat.com/show_bug.cgi?id=1228089
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1228087 | |(zetacomponents/unit-test) Alias| |zetacomponents/base
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1228087 [Bug 1228087] Review Request: php-zetacomponents-unit-test - Zeta UnitTest Component
https://bugzilla.redhat.com/show_bug.cgi?id=1228089
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1228090 | |(zetacomponents/graph)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1228090 [Bug 1228090] Review Request: php-zetacomponents-graph - Zeta Graph Component
https://bugzilla.redhat.com/show_bug.cgi?id=1228089
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1228091 | |(zetacomponents/console-too | |ls)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1228091 [Bug 1228091] Review Request: php-zetacomponents-console-tools - Zeta ConsoleTools Component
https://bugzilla.redhat.com/show_bug.cgi?id=1228089 Bug 1228089 depends on bug 1228087, which changed state.
Bug 1228087 Summary: Review Request: php-zetacomponents-unit-test - Zeta UnitTest Component https://bugzilla.redhat.com/show_bug.cgi?id=1228087
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1228089
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |shawn.iwinski@gmail.com Assignee|nobody@fedoraproject.org |shawn.iwinski@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1228089
--- Comment #1 from Shawn Iwinski shawn.iwinski@gmail.com --- Created attachment 1044101 --> https://bugzilla.redhat.com/attachment.cgi?id=1044101&action=edit phpcompatinfo-full.log
Full (i.e. BuildRequires) phpcompatinfo
phpCompatInfo version 4.2.0 DB built May 22 2015 19:29:18 CEST
https://bugzilla.redhat.com/show_bug.cgi?id=1228089
--- Comment #2 from Shawn Iwinski shawn.iwinski@gmail.com --- Created attachment 1044102 --> https://bugzilla.redhat.com/attachment.cgi?id=1044102&action=edit phpcompatinfo-src.log
Source (i.e. Requires) phpcompatinfo
phpCompatInfo version 4.2.0 DB built May 22 2015 19:29:18 CEST
https://bugzilla.redhat.com/show_bug.cgi?id=1228089
--- Comment #3 from Shawn Iwinski shawn.iwinski@gmail.com --- Created attachment 1044103 --> https://bugzilla.redhat.com/attachment.cgi?id=1044103&action=edit fedora-review.txt
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1228089 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, PHP, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1228089
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #4 from Shawn Iwinski shawn.iwinski@gmail.com --- [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [!]: Buildroot is not present Note: Buildroot: present but not needed [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required
As usual, remove EPEL 5 bits after initial import.
[x]: Requires correct, justified where necessary.
Per phpcompatinfo: BuildRequires: php-pcre BuildRequires: php-simplexml BuildRequires: php-spl
Why the following?: BuildRequires: php-posix Requires: php-posix
I'll leave those details up to you :)
No blockers.
===== APPROVED =====
https://bugzilla.redhat.com/show_bug.cgi?id=1228089
--- Comment #5 from Remi Collet fedora@famillecollet.com ---
Why the following?: BuildRequires: php-posix Requires: php-posix
From phpcompatinfo report optional dep.
Conditions Analysis function_exists(posix_getpwuid) 1 posix 4.0.0 4.0.0
(yes having optional dep "outside" the "Extension Analysis" seems ugly).
https://bugzilla.redhat.com/show_bug.cgi?id=1228089
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #6 from Remi Collet fedora@famillecollet.com --- Thanks for the review!
New Package SCM Request ======================= Package Name: php-zetacomponents-base Short Description: Zeta Base Component Upstream URL: http://zetacomponents.org/ Owners: remi Branches: f21 f22 el6 epel7 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1228089
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1228089
--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1228089
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2015-06-29 12:57:02
https://bugzilla.redhat.com/show_bug.cgi?id=1228089
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- php-zetacomponents-base-1.9-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-zetacomponents-base-1.9-2.el6
https://bugzilla.redhat.com/show_bug.cgi?id=1228089
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- php-zetacomponents-base-1.9-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/php-zetacomponents-base-1.9-2.el7
https://bugzilla.redhat.com/show_bug.cgi?id=1228089
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- php-zetacomponents-base-1.9-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/php-zetacomponents-base-1.9-2.fc21
https://bugzilla.redhat.com/show_bug.cgi?id=1228089
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- php-zetacomponents-base-1.9-2.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/php-zetacomponents-base-1.9-2.fc22
https://bugzilla.redhat.com/show_bug.cgi?id=1228089
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |php-zetacomponents-base-1.9 | |-2.fc21 Resolution|RAWHIDE |ERRATA
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- php-zetacomponents-base-1.9-2.fc21 has been pushed to the Fedora 21 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1228089
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|php-zetacomponents-base-1.9 |php-zetacomponents-base-1.9 |-2.fc21 |-2.fc22
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- php-zetacomponents-base-1.9-2.fc22 has been pushed to the Fedora 22 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1228089
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|php-zetacomponents-base-1.9 |php-zetacomponents-base-1.9 |-2.fc22 |-2.el6
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- php-zetacomponents-base-1.9-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1228089
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|php-zetacomponents-base-1.9 |php-zetacomponents-base-1.9 |-2.el6 |-2.el7
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- php-zetacomponents-base-1.9-2.el7 has been pushed to the Fedora EPEL 7 stable repository.
package-review@lists.fedoraproject.org