[Bug 248163] New: Review Request: gtk-nodoka-engine - The Nodoka gtk engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248163

Summary: Review Request: gtk-nodoka-engine - The Nodoka gtk
                    engine
           Product: Fedora
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://feannatar.hostuju.cz/fedora/files/development/SPECS/gtk-nodoka-engine...
SRPM URL: http://feannatar.hostuju.cz/fedora/files/development/SRPMS/gtk-nodoka-engine...
Description: This package contains the Nodoka gtk engine as well as Nodoka theme for metacity and gtk.

Note:
Current upstream is me and Daniel Geiger and we currently release it on the fedora wiki (see the spec file for URL). I however consider submitting a request for inclusion in fedorahosted projects. For more info about the Nodoka theme and engine see fedora-art-list archives.

[Bug 248163] Review Request: gtk-nodoka-engine - The Nodoka gtk engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtk-nodoka-engine - The Nodoka gtk engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248163

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |248516
              nThis|                            |

[Bug 248163] Review Request: gtk-nodoka-engine - The Nodoka gtk engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtk-nodoka-engine - The Nodoka gtk engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248163

------- Additional Comments From [e-mail]  2007-07-17 04:36 EST -------
I've splited the metacity and metatheme into separate package - BZ #248516 and
released new version the engine.

NEW SPEC:
http://feannatar.hostuju.cz/fedora/files/development/SPECS/gtk-nodoka-engine...

NEW SRPM:
http://feannatar.hostuju.cz/fedora/files/development/SRPMS/gtk-nodoka-engine...

[Bug 248163] Review Request: gtk-nodoka-engine - The Nodoka gtk engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtk-nodoka-engine - The Nodoka gtk engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248163

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

[Bug 248163] Review Request: gtk-nodoka-engine - The Nodoka gtk engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtk-nodoka-engine - The Nodoka gtk engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248163

------- Additional Comments From [e-mail]  2007-07-27 13:08 EST -------
Some trivia:

- version of spec file and src.rpm don't match

- please use a full src url, if practical

- no need to do the obsoletes/provides dance for something that has not ever
 been in a fedora release.

- please don't --enable-animation. I as the gtk2 maintainer am going to veto
 any theme engine that tries to do that behind the toolkits or apps back.

- need to require gtk2 for the engines directory ownership

[Bug 248163] Review Request: gtk-nodoka-engine - The Nodoka gtk engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtk-nodoka-engine - The Nodoka gtk engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248163

------- Additional Comments From [e-mail]  2007-07-27 14:41 EST -------
(In reply to comment #2)
> Some trivia:
> version of spec file and src.rpm don't match

Hm... I see both are 0.3.2.1-1 though Daniel meanwhile updated the src.rpm to
0.5-1. I'll fix the other things in next release and they should match by then.
> please use a full src url, if practical

As we use wiki currently for upstream I think it's impractical ATM
> no need to do the obsoletes/provides dance for something that has not ever
>
> been in a fedora release.

I'll remove them in next release. They were there because older releases were
differently handled and I provided the rpms for testing to community and so I
added obsoletes/provides for easier upgrade
> please don't --enable-animation. I as the gtk2 maintainer am going to veto
>
> any theme engine that tries to do that behind the toolkits or apps back.

I don't prefer the animation myself so I am OK with that... will remove it in
next release. But on the other side... I noticed the Murrine engine has the
animation enabled as well and the code behind is exactly the same as in Nodoka
engine.
> need to require gtk2 for the engines directory ownership

I will add it in next release. I missed it.

[Bug 248163] Review Request: gtk-nodoka-engine - The Nodoka gtk engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtk-nodoka-engine - The Nodoka gtk engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248163

------- Additional Comments From [e-mail]  2007-07-27 15:02 EST -------
New release, fixes the above mentioned issues:

NEW SPEC:
http://feannatar.hostuju.cz/fedora/files/development/SPECS/gtk-nodoka-engine...

NEW SRPM:
http://feannatar.hostuju.cz/fedora/files/development/SRPMS/gtk-nodoka-engine...

[Bug 248163] Review Request: gtk-nodoka-engine - The Nodoka gtk engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtk-nodoka-engine - The Nodoka gtk engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248163

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2007-07-29 23:28 EST -------
rpmlint is silent on the produced rpm

package name: ok
spec file name: ok
packaging guidelines: ok
license: ok
license field: ok
license file: ok
spec language: ok
spec legible: yes
upstream sources: ok
buildable: ok
excludearch: n/a
build requires: ok
locales: n/a
shared libs: n/a
relocatable: n/a
directory ownership: ok
file list dupes: ok
file permissions: ok
%clean section: ok
macro use: ok
permissible content: ok
doc subpackage: n/a
%doc content: ok
headers: n/a
static libs: n/a
pc files: n/a
shared lib symlinks: n/a
devel package: n/a
libtool archives: ok
gui app: n/a
file ownership: ok
%install: ok
utf8 filenames: ok

Approved.

[Bug 248163] Review Request: gtk-nodoka-engine - The Nodoka gtk engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtk-nodoka-engine - The Nodoka gtk engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248163

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2007-08-03 17:12 EST -------
New Package CVS Request
=======================
Package Name: gtk-nodoka-engine
Short Description: The Nodoka GTK2 theme rendering engine with its default GTK2
theme
Owners: [e-mail]
Branches: 
InitialCC:

[Bug 248163] Review Request: gtk-nodoka-engine - The Nodoka gtk engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtk-nodoka-engine - The Nodoka gtk engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248163

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2007-08-04 02:15 EST -------
cvs done.

[Bug 248163] Review Request: gtk-nodoka-engine - The Nodoka gtk engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtk-nodoka-engine - The Nodoka gtk engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248163

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|                            |NEXTRELEASE