[Bug 1263600] New: Review Request: perl-Log-Log4perl-Appender-Socket-UNIX - Log4perl appender for writing to UNIX domain sockets
https://bugzilla.redhat.com/show_bug.cgi?id=1263600
Bug ID: 1263600 Summary: Review Request: perl-Log-Log4perl-Appender-Socket-UNIX - Log4perl appender for writing to UNIX domain sockets Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: holcapek@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://raw.githubusercontent.com/holcapek/perl-Log-Log4perl-Appender-Socket... SRPM URL: https://github.com/holcapek/perl-Log-Log4perl-Appender-Socket-UNIX/raw/maste... Description: This is a simple appender for writing to a unix domain socket. It relies on Socket and only logs to an existing socket. Fedora Account System Username: holcapek
https://bugzilla.redhat.com/show_bug.cgi?id=1263600
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |psabata@redhat.com Assignee|nobody@fedoraproject.org |psabata@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1263600
--- Comment #1 from Petr Šabata psabata@redhat.com --- I've mentioned some of these things in your other package review already. Well, here we go.
* The package doesn't even build in mock. Seriously?
* Missing some build deps: - perl, called in the spec - perl(IO::Handle), lib/Log/Log4perl/Appender/Socket/UNIX.pm:10 - perl(Log::Log4perl::Appender), lib/Log/Log4perl/Appender/Socket/UNIX.pm:5 - perl(Socket), lib/Log/Log4perl/Appender/Socket/UNIX.pm:11 - perl(strict), Build.PL:2 - perl(Test::More), t/1_load.t:16 - perl(warnings), Build.PL:2
* Optional but recommended for build consistency: - perl(Test::NoWarnings), t/1_load.t:8
* Missing a runtime dependency on Log::Log4perl::Appender; this won't get autodetected.
* Drop %defattr, it's no longer required.
* The Group tag is optional and can be dropped.
* License texts need to be packaged using the %license macro.
* Consider packaging the `examples' directory as documentation.
* The README file is useless in this case. Drop it.
https://bugzilla.redhat.com/show_bug.cgi?id=1263600
--- Comment #2 from Jan Holcapek holcapek@gmail.com --- (In reply to Petr Šabata from comment #1)
- The package doesn't even build in mock. Seriously?
Now it does. Sorry, didn't know of [1] till today.
[1] https://fedoraproject.org/wiki/Using_Mock_to_test_package_builds
- Missing some build deps:
- perl, called in the spec
- perl(IO::Handle), lib/Log/Log4perl/Appender/Socket/UNIX.pm:10
- perl(Log::Log4perl::Appender), lib/Log/Log4perl/Appender/Socket/UNIX.pm:5
- perl(Socket), lib/Log/Log4perl/Appender/Socket/UNIX.pm:11
- perl(strict), Build.PL:2
- perl(Test::More), t/1_load.t:16
- perl(warnings), Build.PL:2
Fixed. But honestly, I was trusting cpanspec to figure that out. How did you found about these build deps? (Well, I can simply look into and grep the code for use-es and require-s, but I guess this could be (semi)automated somehow?)
- Optional but recommended for build consistency:
- perl(Test::NoWarnings), t/1_load.t:8
Fixed.
- Missing a runtime dependency on Log::Log4perl::Appender; this won't get autodetected.
Fixed.
- Drop %defattr, it's no longer required.
Dropped.
- The Group tag is optional and can be dropped.
Dropped.
- License texts need to be packaged using the %license macro.
Fixed. Another news for me, thanks. However, rpmlint complains upon the rpm:
perl-Log-Log4perl-Appender-Socket-UNIX.noarch: E: incorrect-fsf-address /usr/share/licenses/perl-Log-Log4perl-Appender-Socket-UNIX/LICENSE
- Consider packaging the `examples' directory as documentation.
FIncluded.
- The README file is useless in this case. Drop it.
Dropped.
Spec URL: https://github.com/holcapek/perl-Log-Log4perl-Appender-Socket-UNIX/blob/mast... SRPM URL: https://github.com/holcapek/perl-Log-Log4perl-Appender-Socket-UNIX/raw/maste...
https://bugzilla.redhat.com/show_bug.cgi?id=1263600
--- Comment #3 from Jan Holcapek holcapek@gmail.com --- (In reply to Jan Holcapek from comment #2)
Fixed. But honestly, I was trusting cpanspec to figure that out. How did you found about these build deps? (Well, I can simply look into and grep the code for use-es and require-s, but I guess this could be (semi)automated somehow?)
Oh, I've just fell in love with fedora-review tool :-)
https://bugzilla.redhat.com/show_bug.cgi?id=1263600
--- Comment #4 from Petr Šabata psabata@redhat.com --- (In reply to Jan Holcapek from comment #2)
(In reply to Petr Šabata from comment #1)
- The package doesn't even build in mock. Seriously?
Now it does. Sorry, didn't know of [1] till today.
[1] https://fedoraproject.org/wiki/Using_Mock_to_test_package_builds
Ack.
One always learns :)
You can also test whether your package builds in koji which provides very similar yet slightly different environment than mock (e.g. no network access).
$ koji build --scratch rawhide package.src.rpm
- Missing some build deps:
- perl, called in the spec
- perl(IO::Handle), lib/Log/Log4perl/Appender/Socket/UNIX.pm:10
- perl(Log::Log4perl::Appender), lib/Log/Log4perl/Appender/Socket/UNIX.pm:5
- perl(Socket), lib/Log/Log4perl/Appender/Socket/UNIX.pm:11
- perl(strict), Build.PL:2
- perl(Test::More), t/1_load.t:16
- perl(warnings), Build.PL:2
Fixed. But honestly, I was trusting cpanspec to figure that out. How did you found about these build deps? (Well, I can simply look into and grep the code for use-es and require-s, but I guess this could be (semi)automated somehow?)
cpanspec only reads upstream provided metadata which is almost always incorrect.
Indeed, to be sure, you simply need to read the code. Remember there are many ways to load a module in perl, not just use and require statements.
You can also use this tool, `tangerine', which helps a great deal with this task.
$ tangerine Build.PL lib/ t/
- Optional but recommended for build consistency:
- perl(Test::NoWarnings), t/1_load.t:8
Fixed.
Ack.
- Missing a runtime dependency on Log::Log4perl::Appender; this won't get autodetected.
Fixed.
Ack.
- Drop %defattr, it's no longer required.
Dropped.
Ack.
- The Group tag is optional and can be dropped.
Dropped.
Ack.
- License texts need to be packaged using the %license macro.
Fixed. Another news for me, thanks. However, rpmlint complains upon the rpm:
perl-Log-Log4perl-Appender-Socket-UNIX.noarch: E: incorrect-fsf-address /usr/share/licenses/perl-Log-Log4perl-Appender-Socket-UNIX/LICENSE
That's safe to ignore for packaging purposes but it's a good idea to let upstream know they distribute an old copy of the license text.
- Consider packaging the `examples' directory as documentation.
FIncluded.
Ack.
- The README file is useless in this case. Drop it.
Dropped.
Ack.
https://bugzilla.redhat.com/show_bug.cgi?id=1263600
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #5 from Petr Šabata psabata@redhat.com --- (In reply to Jan Holcapek from comment #3)
(In reply to Jan Holcapek from comment #2)
Fixed. But honestly, I was trusting cpanspec to figure that out. How did you found about these build deps? (Well, I can simply look into and grep the code for use-es and require-s, but I guess this could be (semi)automated somehow?)
Oh, I've just fell in love with fedora-review tool :-)
It's a popular tool but don't just blindly trust everything it says :)
https://bugzilla.redhat.com/show_bug.cgi?id=1263600
Jan Holcapek holcapek@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #6 from Jan Holcapek holcapek@gmail.com --- New Package SCM Request ======================= Package Name: perl-Log-Log4perl-Appender-Socket-UNIX Short Description: Log4perl appender for writing to UNIX domain sockets Upstream URL: http://search.cpan.org/dist/Log-Log4perl-Appender-Socket-UNIX/ Owners: holcapek Branches: f21 f22 f23 el6 epel7 InitialCC: perl-sig
https://bugzilla.redhat.com/show_bug.cgi?id=1263600
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1263600
--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1263600
--- Comment #8 from Petr Šabata psabata@redhat.com --- Any progress here? Package built, updates issued? Can this be closed?
https://bugzilla.redhat.com/show_bug.cgi?id=1263600
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- perl-Log-Log4perl-Appender-Socket-UNIX-1.04-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-89924f9030
https://bugzilla.redhat.com/show_bug.cgi?id=1263600
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1263600
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- perl-Log-Log4perl-Appender-Socket-UNIX-1.04-3.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-1d82aa5522
https://bugzilla.redhat.com/show_bug.cgi?id=1263600
Jan Holcapek holcapek@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2015-12-02 09:33:32
https://bugzilla.redhat.com/show_bug.cgi?id=1263600
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ON_QA Resolution|NEXTRELEASE |--- Keywords| |Reopened
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- perl-Log-Log4perl-Appender-Socket-UNIX-1.04-3.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update perl-Log-Log4perl-Appender-Socket-UNIX' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-f871afba8b
https://bugzilla.redhat.com/show_bug.cgi?id=1263600
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- perl-Log-Log4perl-Appender-Socket-UNIX-1.04-4.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-0e5bd10e03
https://bugzilla.redhat.com/show_bug.cgi?id=1263600
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1263600
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- perl-Log-Log4perl-Appender-Socket-UNIX-1.04-3.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update perl-Log-Log4perl-Appender-Socket-UNIX' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-1d82aa5522
https://bugzilla.redhat.com/show_bug.cgi?id=1263600
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- perl-Log-Log4perl-Appender-Socket-UNIX-1.04-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update perl-Log-Log4perl-Appender-Socket-UNIX' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-89924f9030
https://bugzilla.redhat.com/show_bug.cgi?id=1263600
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- perl-Log-Log4perl-Appender-Socket-UNIX-1.04-4.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update perl-Log-Log4perl-Appender-Socket-UNIX' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-0e5bd10e03
https://bugzilla.redhat.com/show_bug.cgi?id=1263600
Jan Holcapek holcapek@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE Last Closed|2015-12-02 09:33:32 |2016-02-01 02:25:59
https://bugzilla.redhat.com/show_bug.cgi?id=1263600
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- perl-Log-Log4perl-Appender-Socket-UNIX-1.04-3.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1263600
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|NEXTRELEASE |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1263600
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- perl-Log-Log4perl-Appender-Socket-UNIX-1.04-4.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1263600
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- perl-Log-Log4perl-Appender-Socket-UNIX-1.04-3.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1263600
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- perl-Log-Log4perl-Appender-Socket-UNIX-1.04-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla