https://bugzilla.redhat.com/show_bug.cgi?id=979166
Bug ID: 979166 Summary: Review Request: tora - Toolkit for Oracle, MySQL and PostreSQL Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: pahan@hubbitus.info QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
Spec URL: https://raw.github.com/Hubbitus/Fedora-packaging/5571c2bf2ecf9598e85162d0a36... SRPM URL: http://hubbitus.info/rpm/Fedora18/tora/tora-3-0.1.svn4651.fc18.src.rpm Description: TOra - Toolkit for Oracle
TOra is supported for running with an Oracle 8.1.7 or newer client installation. It has been verified to work with Oracle 10g and 11g.
This RPM is built to work with PostgreSQL and MySQL. Oracle should work also, but does not tested (not in Fedora). Fedora Account System Username: hubbitus
https://bugzilla.redhat.com/show_bug.cgi?id=979166
Matthias Kuhn matthias.kuhn@gmx.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.kuhn@gmx.ch
--- Comment #1 from Matthias Kuhn matthias.kuhn@gmx.ch --- General: 1. The help files should not go into %{_libdir}.
2. The Summary and %description focuses very much on Oracle, while the appropriate BuildRequires are commented out. The resulting binary and the summary/description should match.
3. I would recommend maintaining the .desktop file as a separate source file.
Running rpmlint -i on the resulting .rpm: 1. There is an incorrect free software foundation address in the README file. Upstream should be informed. http://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address
2. There are only non binary files in /usr/lib so they should be in /usr/share (see helpfile comment above)
3. /usr/share/doc/tora-3/NEWS: The character encoding of this file is not UTF-8. Consider converting it in the specfile's %prep section for example using iconv(1).
4. Binary tora: Each executable in standard binary directories should have a man page.
Running rpmlint -i on the .src.rpm: 1. There are some bogus dates in the changelog.
Disclaimer: I'm not an approved fedora packager, so this review is probably not perfect at all.
https://bugzilla.redhat.com/show_bug.cgi?id=979166
--- Comment #2 from Pavel Alexeev (aka Pahan-Hubbitus) pahan@hubbitus.info --- Matthias, thank you for the comments.
Upstream informed about incorrect FSF address - https://sourceforge.net/p/tora/bugs/872/
Unfortunately I nothing can do with absent manual if it is not present by upstream author.
Other issues addressed.
Changes: https://github.com/Hubbitus/Fedora-packaging/commit/15a46bad57d6d97dbfa1171d... Spec:https://raw.github.com/Hubbitus/Fedora-packaging/15a46bad57d6d97dbfa1171d337... Srpm: http://hubbitus.info/rpm/Fedora19/tora/tora-3-0.2.svn4651.fc19.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=979166
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@gmail.com
--- Comment #3 from Christopher Meng cickumqt@gmail.com --- - %global everywhere, no %define
- URL SHOULD BE http://torasql.com/
- No need to specify BuildRequires: qt-devel >= 4.3.0, as 4.3.0 is really ancient.
- Remove "TOra - Toolkit for Oracle" in %description.
- Your version is still older than listed:
http://sourceforge.net/projects/tora/files/tora-experimental/
- install --mode=644 is not enough,
use install -pm644.
- I tried to build oracle related stuffs in the past but actually I need some closed source packages. And I can see
#- BuildRequires: oracle-instantclient-devel = %%{oraclever} #- BuildRequires: oracle-instantclient-sqlplus = %%{oraclever}
in your spec, any explanation?
https://bugzilla.redhat.com/show_bug.cgi?id=979166
Pavel Alexeev (aka Pahan-Hubbitus) pahan@hubbitus.info changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|package-review@lists.fedora | |project.org |
--- Comment #4 from Pavel Alexeev (aka Pahan-Hubbitus) pahan@hubbitus.info --- Hi Christopher.
Thank you, I have address most mentioned issues.
(In reply to Christopher Meng from comment #3)
- I tried to build oracle related stuffs in the past but actually I need
some closed source packages. And I can see
#- BuildRequires: oracle-instantclient-devel = %%{oraclever} #- BuildRequires: oracle-instantclient-sqlplus = %%{oraclever} in your spec, any explanation?
Yes, to use it with oracle you need Oracle proprietary libraries. We have no such libs in Fedora. And I even did not tried do that as my searches was to Postgres GUI (it is because I package also pgmodeler). It come from Remi Collet rpm and you may uncomment it when try build with Oracle support. At least who will try do that can read it in spec comments. I have add it.
Unfortunately I found several bundled libraries which is stop issue. https://sourceforge.net/p/tora/bugs/873/
I'll post files later, when can resolve bundles issue. Without it it useless.
https://bugzilla.redhat.com/show_bug.cgi?id=979166
Pavel Alexeev (aka Pahan-Hubbitus) pahan@hubbitus.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1026440 Flags|needinfo? |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1026440 [Bug 1026440] Please update antlr3 to version 3.5.1 and include C++ runtime
https://bugzilla.redhat.com/show_bug.cgi?id=979166
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |cickumqt@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=979166
--- Comment #7 from Christopher Meng cickumqt@gmail.com --- I'd like to see the new SPEC & SRPM based on previous comments and improvements.
BTW the URL has changed to torasql.com
Add missing hicolor-icon-theme dep.
Move %files after %post* but before %changelog.
Then I will start the final review.
https://bugzilla.redhat.com/show_bug.cgi?id=979166
--- Comment #8 from Pavel Alexeev (aka Pahan-Hubbitus) pahan@hubbitus.info --- Thank you Christopher. But unfortunately we can't continue until bundled libs issue will be lifted.
https://bugzilla.redhat.com/show_bug.cgi?id=979166
--- Comment #9 from ibre5041 ibre5041@ibrezina.net --- The issue with bundled libs can not be resolved by Tora development team either. The version of the ANTLR3 parser runtime you use (3.2) is buggy and causes segfaults. Moreover is has different API. Our code requires API ver. 3.5 and also needs the latest SEGFAULT fixes from the ANTLR3 git trunk.
We can use external libs: loki and qscitilla. But we still need our internal (bundled) libs: - antlr3c (our is stable and has the right API version) - antlr3cpp (this one was not packaged yet) - trotl (our internal lib not used anywhere else) - libermodel (our internal lib not used anywhere else)
Ivan
https://bugzilla.redhat.com/show_bug.cgi?id=979166
--- Comment #10 from ibre5041 ibre5041@ibrezina.net --- I looks like it started moving forward. We depend on the bug 1026440. Thx Pavel
https://bugzilla.redhat.com/show_bug.cgi?id=979166
--- Comment #11 from Pavel Alexeev (aka Pahan-Hubbitus) pahan@hubbitus.info --- Hello, Ivan.
Off course your libs which is part of project itself may be stay there. And I also hope we could make step forward if linked antlr3cpp will be updated.
https://bugzilla.redhat.com/show_bug.cgi?id=979166
--- Comment #12 from ibre5041 ibre5041@ibrezina.net --- At this moment it's OK. All mine patches(pull requests) for antlr3cpp are applied in trunk. But in the future I'm going to work on this project too and would like to use mine changes also in Tora project.
https://bugzilla.redhat.com/show_bug.cgi?id=979166
--- Comment #13 from Pavel Alexeev (aka Pahan-Hubbitus) pahan@hubbitus.info --- Great news! Is it meant you are became on of co-author of antlr3cpp and there no more needs to have separate copy in tora project?
https://bugzilla.redhat.com/show_bug.cgi?id=979166
--- Comment #14 from ibre5041 ibre5041@ibrezina.net --- I have "bad" news. I found some memory leak in antlr3cpp and did fix it. At this moment mine patch waits in github's pull request queue. But I do not want to use un-patched version of antlr3cpp in Tora.
https://bugzilla.redhat.com/show_bug.cgi?id=979166
--- Comment #15 from Pavel Alexeev (aka Pahan-Hubbitus) pahan@hubbitus.info --- Bad news better than nothing. Could you please provide link on pull-request to track it?
https://bugzilla.redhat.com/show_bug.cgi?id=979166
--- Comment #16 from ibre5041 ibre5041@ibrezina.net --- Here is it: https://github.com/antlr/antlr3/pull/145
https://bugzilla.redhat.com/show_bug.cgi?id=979166 Bug 979166 depends on bug 1026440, which changed state.
Bug 1026440 Summary: Please update antlr3 to version 3.5.1 and include C++ runtime https://bugzilla.redhat.com/show_bug.cgi?id=1026440
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=979166 Bug 979166 depends on bug 1026440, which changed state.
Bug 1026440 Summary: Please update antlr3 to version 3.5.1 and include C++ runtime https://bugzilla.redhat.com/show_bug.cgi?id=1026440
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Resolution|RAWHIDE |---
https://bugzilla.redhat.com/show_bug.cgi?id=979166 Bug 979166 depends on bug 1026440, which changed state.
Bug 1026440 Summary: Please update antlr3 to version 3.5.1 and include C++ runtime https://bugzilla.redhat.com/show_bug.cgi?id=1026440
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |CURRENTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=979166
--- Comment #17 from Pavel Alexeev pahan@hubbitus.info --- Christopher, ping.
https://bugzilla.redhat.com/show_bug.cgi?id=979166
Pavel Alexeev pahan@hubbitus.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|i@cicku.me |nobody@fedoraproject.org
--- Comment #18 from Pavel Alexeev pahan@hubbitus.info --- Reviewer did not answer in months. Clear assignment.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla