[Bug 859271] New: Review Request: php-symfony2-OptionsResolver - Symfony2 OptionsResolver Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=859271

Bug ID: 859271
        QA Contact: [e-mail]
          Severity: medium
           Version: rawhide
          Priority: medium
                CC: [e-mail],
                    [e-mail]
          Assignee: [e-mail]
           Summary: Review Request: php-symfony2-OptionsResolver -
                    Symfony2 OptionsResolver Component
        Regression: ---
      Story Points: ---
    Classification: Fedora
                OS: Linux
          Reporter: [e-mail]
              Type: ---
     Documentation: ---
          Hardware: All
        Mount Type: ---
            Status: NEW
         Component: Package Review
           Product: Fedora

Spec URL:
http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-symfony2-OptionsResolver...

SRPM URL:
http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-symfony2-OptionsResolver...

Description:
OptionsResolver helps at configuring objects with option arrays.

It supports default values on different levels of your class hierarchy, option
constraints (required vs. optional, allowed values) and lazy options whose
default value depends on the value of another option.

Fedora Account System Username: siwinski

Distributions: EPEL 6, F16+

[Bug 859271] Review Request: php-symfony2-OptionsResolver - Symfony2 OptionsResolver Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=859271

Shawn Iwinski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Blocks|                            |823071
         Depends On|                            |814994
                   |                            |(php-channel-symfony2)

[Bug 859271] Review Request: php-symfony2-OptionsResolver - Symfony2 OptionsResolver Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=859271

Remi Collet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #1 from Remi Collet  ---
Same comments as bug #859270

[Bug 859271] Review Request: php-symfony2-OptionsResolver - Symfony2 OptionsResolver Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=859271

Remi Collet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]          |[e-mail]

[Bug 859271] Review Request: php-symfony2-OptionsResolver - Symfony2 OptionsResolver Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=859271

--- Comment #2 from Shawn Iwinski  ---
Updated per bug #859270 comments.

- Added PEAR package.xml modificaions
- Added patch for tests' bootstrap.php
- Added tests (%check)

SPEC URL:
http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-symfony2-OptionsResolver...

SRPM URL:
http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-symfony2-OptionsResolver...

[Bug 859271] Review Request: php-symfony2-OptionsResolver - Symfony2 OptionsResolver Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=859271

--- Comment #3 from Remi Collet  ---
Created attachment 624962
  --> https://bugzilla.redhat.com/attachment.cgi?id=624962&action=edit
859271-php-symfony2-OptionsResolver/php-symfony2-OptionsResolver-review.txt

Generated by fedora-review 0.3.0 (c78e275) last change: 2012-09-24

[Bug 859271] Review Request: php-symfony2-OptionsResolver - Symfony2 OptionsResolver Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=859271

Remi Collet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |
              Flags|                            |fedora-review+

--- Comment #4 from Remi Collet  ---
Same typo in %changelog (modificaions) copy/paste limit ;)

=== APPROVED ===

[Bug 859271] Review Request: php-symfony2-OptionsResolver - Symfony2 OptionsResolver Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=859271

Shawn Iwinski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-cvs?

--- Comment #5 from Shawn Iwinski  ---
New Package SCM Request
=======================
Package Name: php-symfony2-OptionsResolver
Short Description: Symfony2 OptionsResolver Component
Owners: siwinski
Branches: f16 f17 f18 el6
InitialCC:

[Bug 859271] Review Request: php-symfony2-OptionsResolver - Symfony2 OptionsResolver Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=859271

--- Comment #6 from Jon Ciesla  ---
Git done (by process-git-requests).

[Bug 859271] Review Request: php-symfony2-OptionsResolver - Symfony2 OptionsResolver Component

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=859271

Shawn Iwinski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2012-11-17 11:58:03