[Bug 1419291] New: Review Request: python-backports-unittest_mock - backport of unittest mock for python 3.2 and before
https://bugzilla.redhat.com/show_bug.cgi?id=1419291
Bug ID: 1419291 Summary: Review Request: python-backports-unittest_mock - backport of unittest mock for python 3.2 and before Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: kevin@scrye.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://www.scrye.com/~kevin/fedora/review/python-backports-unittest_mock/pyt... SRPM URL: http://www.scrye.com/~kevin/fedora/review/python-backports-unittest_mock/pyt...
Description: Provides a function “install()” which makes the “mock” module available as “unittest.mock” on Python 3.2 and earlier.
Also advertises a pytest plugin which configures unittest.mock automatically.
Fedora Account System Username: kevin
scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=17602296
rpmlint says:
python2-backports-unittest_mock.noarch: W: spelling-error Summary(en_US) backport -> back port, back-port, backpacker python2-backports-unittest_mock.noarch: W: spelling-error Summary(en_US) unittest -> unit test, unit-test, unities python2-backports-unittest_mock.noarch: W: summary-not-capitalized C backport of unittest mock for python 3.2 and before python2-backports-unittest_mock.noarch: W: spelling-error %description -l en_US unittest -> unit test, unit-test, unities python2-backports-unittest_mock.noarch: W: spelling-error %description -l en_US pytest -> testes python2-backports-unittest_mock.noarch: E: wrong-script-interpreter /usr/share/doc/python2-backports-unittest_mock/conf.py /usr/bin/env python3 python3-backports-unittest_mock.noarch: W: spelling-error Summary(en_US) backport -> back port, back-port, backpacker python3-backports-unittest_mock.noarch: W: spelling-error Summary(en_US) unittest -> unit test, unit-test, unities python3-backports-unittest_mock.noarch: W: summary-not-capitalized C backport of unittest mock for python 3.2 and before python3-backports-unittest_mock.noarch: W: spelling-error %description -l en_US unittest -> unit test, unit-test, unities python3-backports-unittest_mock.noarch: W: spelling-error %description -l en_US pytest -> testes python3-backports-unittest_mock.noarch: E: wrong-script-interpreter /usr/share/doc/python3-backports-unittest_mock/conf.py /usr/bin/env python3 python-backports-unittest_mock.src: W: spelling-error Summary(en_US) backport -> back port, back-port, backpacker python-backports-unittest_mock.src: W: spelling-error Summary(en_US) unittest -> unit test, unit-test, unities python-backports-unittest_mock.src: W: summary-not-capitalized C backport of unittest mock for python 3.2 and before python-backports-unittest_mock.src: W: spelling-error %description -l en_US unittest -> unit test, unit-test, unities python-backports-unittest_mock.src: W: spelling-error %description -l en_US pytest -> testes 3 packages and 0 specfiles checked; 2 errors, 15 warnings.
All of which I think can be ignored.
https://bugzilla.redhat.com/show_bug.cgi?id=1419291
--- Comment #1 from Kevin Fenzi kevin@scrye.com --- BTW, this package is needed for the python2 tests of python-setuptools recent versions.
https://bugzilla.redhat.com/show_bug.cgi?id=1419291
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Flags| |fedora-review?
--- Comment #2 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=1419291
--- Comment #3 from Neal Gompa ngompa13@gmail.com --- Review notes:
+ Package is appropriately named + Subpackages are named correctly per current Python packaging guidelines - %python_provide macro usage is missing on Python module subpackages + License noted correctly - License file is not included in the module subpackages + Unit tests are run and pass in the %check section
https://bugzilla.redhat.com/show_bug.cgi?id=1419291
--- Comment #4 from Kevin Fenzi kevin@scrye.com --- Spec URL: http://www.scrye.com/~kevin/fedora/review/python-backports-unittest_mock/pyt... SRPM URL: http://www.scrye.com/~kevin/fedora/review/python-backports-unittest_mock/pyt...
Added the python_provide macro. Added a copy of the MIT license, as upstream doesn't include it on purpose. I'll argue with them about it later, but in the mean time I am including a copy.
https://bugzilla.redhat.com/show_bug.cgi?id=1419291
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #5 from Neal Gompa ngompa13@gmail.com --- Looks good to me.
APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1419291
Kevin Fenzi kevin@scrye.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #6 from Kevin Fenzi kevin@scrye.com --- Thanks for the quick review!
Package requested.
https://bugzilla.redhat.com/show_bug.cgi?id=1419291
--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-backports-unittest...
https://bugzilla.redhat.com/show_bug.cgi?id=1419291
Kevin Fenzi kevin@scrye.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2017-02-06 13:00:13
--- Comment #8 from Kevin Fenzi kevin@scrye.com --- Built in rawhide. Thanks.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com