Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=349191
Summary: Review Request: malaga-suomi-voikko - A description of Finnish morphology written in Malaga (Voikko edition) Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: vpivaini@cs.helsinki.fi QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://vpv.fedorapeople.org/packages/malaga-suomi-voikko.spec SRPM URL: http://vpv.fedorapeople.org/packages/malaga-suomi-voikko-0.7.6-0.1.fc7.src.r... Description: A description of Finnish morphology written in Malaga. This version is modified to support the Voikko spellchecker/hyphenator and is not compatible with the Sukija text indexer.
I've named the package malaga-suomi-voikko, because it extends Malaga (see Bug #346121) with Finnish and it is a modified version to support the F/OSS Finnish spell checker Voikko, which I intend to package also. This way malaga-suomi (without Voikko support) could be packaged separately if needed.
Rpmlint outputs these errors: malaga-suomi-voikko.i386: E: no-binary malaga-suomi-voikko.i386: E: only-non-binary-in-usr-lib
I have explained these in the comments of the spec file, copied here as well: Files differ on big-endian and small-endian archs, and they have different names (*_l vs *_b). This is the reason we use %{_libdir} instead of %{_datadir} and won't noarch the package.
This is exactly what the Voikko developers asked me to do, they think that using /usr/share would be wrong, because of the issue mentioned above.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: malaga-suomi-voikko - A description of Finnish morphology written in Malaga (Voikko edition)
https://bugzilla.redhat.com/show_bug.cgi?id=349191
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |346121
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: malaga-suomi-voikko - A description of Finnish morphology written in Malaga (Voikko edition)
https://bugzilla.redhat.com/show_bug.cgi?id=349191
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |350781 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: malaga-suomi-voikko - A description of Finnish morphology written in Malaga (Voikko edition)
https://bugzilla.redhat.com/show_bug.cgi?id=349191
Bug 349191 depends on bug 346121, which changed state.
Bug 346121 Summary: Review Request: malaga - Programming language for modelling of language-dependent grammatical information https://bugzilla.redhat.com/show_bug.cgi?id=346121
What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: malaga-suomi-voikko - A description of Finnish morphology written in Malaga (Voikko edition)
https://bugzilla.redhat.com/show_bug.cgi?id=349191
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@ioa.s.u-tokyo.ac.jp
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-10-31 13:58 EST ------- This is just a initial comment: - malaga requires libmalaga, so "(Build)Requires: libmalaga" is actally not needed.
- For %files entry ------------------------------------------------------------ %files %{_libdir}/voikko %{_libdir}/voikko/voikko-fi_FI*_l %{_libdir}/voikko/voikko-fi_FI.pro ------------------------------------------------------------- The entry "%_libdir/voikko" (which is a directory) means the directory %_libdir/voikko itself and all files/directories/etc under this directory, so the following two entries are not needed.
- Rebuild fails on ppc and ppc64. For ppc: http://koji.fedoraproject.org/koji/taskinfo?taskID=222539 For ppc64: ttp://koji.fedoraproject.org/koji/taskinfo?taskID=222476
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: malaga-suomi-voikko - A description of Finnish morphology written in Malaga (Voikko edition)
https://bugzilla.redhat.com/show_bug.cgi?id=349191
------- Additional Comments From vpivaini@cs.helsinki.fi 2007-10-31 16:58 EST ------- New SPEC: http://vpv.fedorapeople.org/packages/malaga-suomi-voikko.spec New SRPM: http://vpv.fedorapeople.org/packages/malaga-suomi-voikko-0.7.6-0.2.fc7.src.r...
(In reply to comment #1)
- malaga requires libmalaga, so "(Build)Requires: libmalaga" is actally not needed.
Fixed.
The entry "%_libdir/voikko" (which is a directory) means the directory %_libdir/voikko itself and all files/directories/etc under this directory, so the following two entries are not needed.
Fixed, this also fixes the ppc and ppc64 build failures, I tested the new SRPM myself in koji.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: malaga-suomi-voikko - A description of Finnish morphology written in Malaga (Voikko edition)
https://bugzilla.redhat.com/show_bug.cgi?id=349191
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp Status|NEW |ASSIGNED Flag| |fedora-review+
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-11-01 07:37 EST ------- ---------------------------------------------------------------- This package (malaga-suomi-voikko) is APPROVED by me ----------------------------------------------------------------
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: malaga-suomi-voikko - A description of Finnish morphology written in Malaga (Voikko edition)
https://bugzilla.redhat.com/show_bug.cgi?id=349191
vpivaini@cs.helsinki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From vpivaini@cs.helsinki.fi 2007-11-01 08:01 EST ------- New Package CVS Request ======================= Package Name: malaga-suomi-voikko Short Description: A description of Finnish morphology written in Malaga (Voikko edition) Owners: vpv Branches: F-7 F-8 Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: malaga-suomi-voikko - A description of Finnish morphology written in Malaga (Voikko edition)
https://bugzilla.redhat.com/show_bug.cgi?id=349191
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2007-11-01 13:32 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: malaga-suomi-voikko - A description of Finnish morphology written in Malaga (Voikko edition)
https://bugzilla.redhat.com/show_bug.cgi?id=349191
vpivaini@cs.helsinki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From vpivaini@cs.helsinki.fi 2007-11-01 14:01 EST ------- Package built for devel, see http://koji.fedoraproject.org/koji/taskinfo?taskID=223475
I also tried to build it for F-7 and F-8, which didn't succeed, because they don't have Malaga yet. I assume I need to wait for the updates to be pushed before building? In any case, I'm closing this bug.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: malaga-suomi-voikko - A description of Finnish morphology written in Malaga (Voikko edition)
https://bugzilla.redhat.com/show_bug.cgi?id=349191
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-11-01 14:19 EST ------- * you can ask rel-eng team to add malaga to buildroot so that you can rebuild this package on F-7 or F-8.
When mailing to rel-eng team, please show them the EVR (epoch-version-release) of malaga to be added to buildroot.
package-review@lists.fedoraproject.org