[Bug 2190490] New: Review Request: golang-github-hashicorp-plugin.spec - golang plugin system over RPC

https://bugzilla.redhat.com/show_bug.cgi?id=2190490

Bug ID: 2190490
           Summary: Review Request: golang-github-hashicorp-plugin.spec -
                    golang plugin system over RPC
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://fuller.fedorapeople.org/terraform/golang-github-hashicorp-plugin.spe...
SRPM URL:
https://fuller.fedorapeople.org/terraform/golang-github-hashicorp-plugin-1.4...
Description: golang plugin system over RPC
Fedora Account System Username: fuller

[Bug 2190490] Review Request: golang-github-hashicorp-plugin.spec - golang plugin system over RPC

https://bugzilla.redhat.com/show_bug.cgi?id=2190490

Link Dupont  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
             Status|NEW                         |POST
           Assignee|[e-mail]    |[e-mail]
                 CC|                            |[e-mail]

[Bug 2190490] Review Request: golang-github-hashicorp-plugin.spec - golang plugin system over RPC

https://bugzilla.redhat.com/show_bug.cgi?id=2190490

Link Dupont  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #1 from Link Dupont  ---
A few small commits have been released since 1.4.9; consider bumping the
version to 1.4.10.
https://github.com/hashicorp/go-plugin/compare/v1.4.9...v1.4.10

Some .gitignore files are included in the package via %godocs including
examples. Consider removing them during %prep.
> golang-github-hashicorp-plugin-devel.noarch: E: version-control-internal-file /usr/share/doc/golang-github-hashicorp-plugin-devel/examples/basic/.gitignore
> golang-github-hashicorp-plugin-devel.noarch: E: version-control-internal-file /usr/share/doc/golang-github-hashicorp-plugin-devel/examples/grpc/.gitignore
> golang-github-hashicorp-plugin-devel.noarch: E: version-control-internal-file /usr/share/doc/golang-github-hashicorp-plugin-devel/examples/negotiated/.gitignore

%prep
%goprep
%autopatch -p1
find . -iname .gitignore -exec rm {} ;

Approving the package, but consider them before/during import.

- [x] The spec file is clear and easy to read
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No rpmlint errors (or valid justification for exceptions)
- [x] %check section passes
- [x] The latest version is packaged
- [x] %goipath is set correctly
- [x] The package complies with the Packaging Guidelines

On import, don't forget to do the following:

- [ ] Add package to https://release-monitoring.org
- [ ] Add package to https://koschei.fedoraproject.org/packages
- [ ] Grant @go-sig group commit privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and/or the
Bodhi ticket.

[Bug 2190490] Review Request: golang-github-hashicorp-plugin - golang plugin system over RPC

https://bugzilla.redhat.com/show_bug.cgi?id=2190490

Mark E. Fuller  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request:             |Review Request:
                   |golang-github-hashicorp-plu |golang-github-hashicorp-plu
                   |gin.spec - golang plugin    |gin - golang plugin system
                   |system over RPC             |over RPC