Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: qt-gstreamer - C++ bindings for GStreamer with a Qt-style API
https://bugzilla.redhat.com/show_bug.cgi?id=674730
Summary: Review Request: qt-gstreamer - C++ bindings for GStreamer with a Qt-style API Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: alekcejk@googlemail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://nucleo.fedorapeople.org/pkg-reviews/qt-gstreamer/qt-gstreamer.spec
SRPM URL: http://nucleo.fedorapeople.org/pkg-reviews/qt-gstreamer/qt-gstreamer-0.10.1-...
Description: QtGStreamer provides C++ bindings for GStreamer with a Qt-style API, plus some helper classes for integrating GStreamer better in Qt applications.
Builds in mock: http://koji.fedoraproject.org/koji/taskinfo?taskID=2758987 http://nucleo.fedorapeople.org/pkg-reviews/qt-gstreamer/i686/ http://nucleo.fedorapeople.org/pkg-reviews/qt-gstreamer/x86_64/
$ rpmlint qt-gstreamer-0.10.1-1.fc14.src.rpm qt-gstreamer-0.10.1-1.fc14.i686.rpm qt-gstreamer-devel-0.10.1-1.fc14.i686.rpm qt-gstreamer-debuginfo-0.10.1-1.fc14.i686.rpm qt-gstreamer-0.10.1-1.fc14.x86_64.rpm qt-gstreamer-devel-0.10.1-1.fc14.x86_64.rpm qt-gstreamer-debuginfo-0.10.1-1.fc14.x86_64.rpm 7 packages and 0 specfiles checked; 0 errors, 0 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674730
nucleo alekcejk@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |http://gstreamer.freedeskto | |p.org/wiki/QtGStreamer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674730
nucleo alekcejk@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |674738
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674730
Mohamed El Morabity pikachu.2014@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |pikachu.2014@gmail.com AssignedTo|nobody@fedoraproject.org |pikachu.2014@gmail.com Flag| |fedora-review?
--- Comment #1 from Mohamed El Morabity pikachu.2014@gmail.com 2011-02-07 04:39:11 EST --- I will review this package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674730
Mohamed El Morabity pikachu.2014@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #2 from Mohamed El Morabity pikachu.2014@gmail.com 2011-02-20 06:13:43 EST --- Sorry for being long... The package looks quite good, here is its review:
MUST: rpmlint must be run on every package. ->OK, no warning
MUST: The package must be named according to the Package Naming Guidelines. ->OK
MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. ->OK
MUST: The package must meet the Packaging Guidelines. ->OK
MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. ->OK
MUST: The License field in the package spec file must match the actual license. ->OK
MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. ->OK
MUST: The spec file must be written in American English. ->OK
MUST: The spec file for the package MUST be legible. ->OK
MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. ->OK, md5sum = d2507a8084973fa9956d792c20013977
MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. ->OK, see Koji links above
MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. ->N/A
MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. ->OK
MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. ->N/A
MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. ->OK
MUST: Packages must NOT bundle copies of system libraries. ->OK
MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. ->N/A
MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory.
OK
MUST: A Fedora package must not list a file more than once in the spec file's %files listings. ->OK
MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. ->OK
MUST: Each package must consistently use macros. ->OK
MUST: The package must contain code, or permissable content. ->OK
MUST: Large documentation files must go in a -doc subpackage. ->N/A
MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. ->OK
MUST: Header files must be in a -devel package. ->OK
MUST: Static libraries must be in a -static package. ->N/A
MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. ->OK
MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release}. ->OK
MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. ->OK
MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. ->N/A
MUST: Packages must not own files or directories already owned by other packages. ->OK
MUST: All filenames in rpm packages must be valid UTF-8. ->OK
This package is APPROVED.
Just a (small) note: maybe you could add the examples/ folder in the sources as %doc, it may be useful for qt-gstreamer beginners. It's not mandatory of course, just a suggestion.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674730
nucleo alekcejk@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #3 from nucleo alekcejk@googlemail.com 2011-02-20 09:30:16 EST --- (In reply to comment #2)
Just a (small) note: maybe you could add the examples/ folder in the sources as %doc, it may be useful for qt-gstreamer beginners. It's not mandatory of course, just a suggestion.
All examples available in "API Documentation" on QtGStreamer site.
This package is APPROVED.
Thank you for review.
New Package SCM Request ======================= Package Name: qt-gstreamer Short Description: C++ bindings for GStreamer with a Qt-style API Owners: nucleo Branches: f14 f15 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674730
--- Comment #4 from Jason Tibbitts tibbs@math.uh.edu 2011-02-21 15:30:41 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674730
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674730
--- Comment #5 from Fedora Update System updates@fedoraproject.org 2011-02-21 16:16:07 EST --- qt-gstreamer-0.10.1-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/qt-gstreamer-0.10.1-1.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674730
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2011-02-21 16:16:48 EST --- qt-gstreamer-0.10.1-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/qt-gstreamer-0.10.1-1.fc15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674730
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2011-02-21 23:56:07 EST --- qt-gstreamer-0.10.1-1.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update qt-gstreamer'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/qt-gstreamer-0.10.1-1.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674730
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2011-03-01 20:52:44 EST --- qt-gstreamer-0.10.1-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674730
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |qt-gstreamer-0.10.1-1.fc14 Resolution| |ERRATA Last Closed| |2011-03-01 20:52:49
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674730
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2011-03-02 22:02:10 EST --- qt-gstreamer-0.10.1-1.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674730
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|qt-gstreamer-0.10.1-1.fc14 |qt-gstreamer-0.10.1-1.fc15
package-review@lists.fedoraproject.org