[Bug 2140674] New: Review Request: rust-memfd - Pure-Rust library to work with Linux memfd and sealing
https://bugzilla.redhat.com/show_bug.cgi?id=2140674
Bug ID: 2140674 Summary: Review Request: rust-memfd - Pure-Rust library to work with Linux memfd and sealing Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: decathorpe@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://decathorpe.fedorapeople.org/rust-memfd.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-memfd-0.6.1-1.fc37.src.rpm
Description: Pure-Rust library to work with Linux memfd and sealing.
Fedora Account System Username: decathorpe
koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=93911689
An earlier version of this package has previously been available, but has been retired for more than 8 weeks, so this review is also pre-requisite for package unretirement: https://src.fedoraproject.org/rpms/rust-memfd
Note that the build failure on s390x is due to an issue with the rustix package, not a problem with this one, and I'll try to fix it ASAP.
https://bugzilla.redhat.com/show_bug.cgi?id=2140674
Richard W.M. Jones rjones@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Assignee|nobody@fedoraproject.org |rjones@redhat.com Flags| |fedora-review? CC| |rjones@redhat.com Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=2140674
Richard W.M. Jones rjones@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2124697
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2124697 [Bug 2124697] Review Request: libblkio - Block device I/O library
https://bugzilla.redhat.com/show_bug.cgi?id=2140674
--- Comment #1 from Richard W.M. Jones rjones@redhat.com --- The package was generated by a trusted maintainer using rust2rpm so I'm going to do a reduced review.
Upstream: https://github.com/lucab/memfd-rs
The latest version is 0.6.1. (This is not tagged so github thinks the latest is 0.4.1). The latest version is therefore being packaged.
The license tag matches upstream (dual MIT, Apache) and is correct.
There are no downstream changes or patches.
The spec file is legible, matches the packaging guidelines, and is largely generated.
The scratch build above failed on s390x. I did another one to see if the failure is temporary or permanent: https://koji.fedoraproject.org/koji/taskinfo?taskID=93912721 And it is. I think this needs to be fixed (upstream probably) before this package can go into Fedora.
I downloaded and tested the package by compiling libblkio against it (see bug 2124697). I had to add this patch to libblkio: https://gitlab.com/libblkio/libblkio/-/merge_requests/143 Anyway, it worked fine.
https://bugzilla.redhat.com/show_bug.cgi?id=2140674
--- Comment #2 from Fabio Valentini decathorpe@gmail.com ---
And it is. I think this needs to be fixed (upstream probably) before this package can go into Fedora.
No, that one is probably my fault. It looks like some well-intentioned downstream changes to the rustix crate (to make it possible to run more tests) were broken, see my previous comment:
Note that the build failure on s390x is due to an issue with the rustix package, not a problem with this one, and I'll try to fix it ASAP.
I'm testing a fix right now, and will submit a new scratch build once the fix has landed in rawhide.
https://bugzilla.redhat.com/show_bug.cgi?id=2140674
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- Meh, it looks like my downstream change just plastered over an actual problem with rustix on s390x. I've reported the problem here: https://github.com/bytecodealliance/rustix/issues/439
https://bugzilla.redhat.com/show_bug.cgi?id=2140674
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- Nevermind, looks like our tooling for creating some of our downstream patches don't like the way rustix does things ...
With the fix for that problem in rustix submitted to rawhide, a new memfd scratch build now succeeded: https://koji.fedoraproject.org/koji/taskinfo?taskID=93916424
https://bugzilla.redhat.com/show_bug.cgi?id=2140674
Richard W.M. Jones rjones@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #5 from Richard W.M. Jones rjones@redhat.com --- *** This package is APPROVED by rjones ***
https://bugzilla.redhat.com/show_bug.cgi?id=2140674
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST
--- Comment #6 from Fabio Valentini decathorpe@gmail.com --- Great, thanks! I've filed this ticket to request package unretirement: https://pagure.io/releng/issue/11122
https://bugzilla.redhat.com/show_bug.cgi?id=2140674
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2022-11-08 20:29:10
--- Comment #7 from Fabio Valentini decathorpe@gmail.com --- Package unretired, submitted, and built: https://koji.fedoraproject.org/koji/buildinfo?buildID=2085881 https://bodhi.fedoraproject.org/updates/FEDORA-2022-83ed82c28e Thanks everybody!
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com