[Bug 226492] New: Merge Review: timidity++

List overview All Threads
Download

newer

older

[Bug 169795] Review Request:...

[Bug 430417] New: Review Request:...

Red Hat Bugzilla

31 Jan 2007 31 Jan '07

10:10 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226492

Summary: Merge Review: timidity++ Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nobody@fedoraproject.org QAContact: fedora-package-review@redhat.com CC: twoerner@redhat.com

Fedora Merge Review: timidity++

http://cvs.fedora.redhat.com/viewcvs/devel/timidity++/ Initial Owner: twoerner@redhat.com

-- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Show replies by thread

Red Hat Bugzilla

23 Jan 23 Jan

5:47 p.m.

New subject: [Bug 226492] Merge Review: timidity++

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: timidity++

https://bugzilla.redhat.com/show_bug.cgi?id=226492

bugzilla@redhat.com changed:

mtasaka@ioa.s.u-tokyo.ac.jp changed:

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-01-23 11:47 EST ------- cc-ing Jindrich and Hans, assigning to myself.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

7:19 p.m.

New subject: [Bug 226492] Merge Review: timidity++

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: timidity++

https://bugzilla.redhat.com/show_bug.cgi?id=226492

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-01-23 13:19 EST ------- License check list: =========================================================== Source: GPLv2+

interface/VTparse.h MIT interface/VTPrsTbl.c MIT interface/xaw_redef.c MIT timidity/mt19937ar.c BSD utils/fft4g.c Okay! utils/fft4g.h Okay! http://www.kurims.kyoto-u.ac.jp/~ooura/fft-j.html

Source1,3,4: SourceURL links broken, and all binaries. What are these files? Maybe Public Domain? or like "Redistributable, no modification permitted"? ===========================================================

For 2.13.2-6:

* Documents - Please add some documents to %doc * At least "COPYING" must be added * And consider to add some other documents such as ---------------------------------------------------------- TiMidity++-2.13.2/AUTHORS TiMidity++-2.13.2/ChangeLog* TiMidity++-2.13.2/README* (TiMidity++-2.13.2/README.ja is encoded in EUC-JP) ---------------------------------------------------------- * Also please check man files ---------------------------------------------------------- TiMidity++-2.13.2/doc/ja_JP.eucJP/timidity.1 (EUC-JP) timidity.cfg.5 (Same as above) ---------------------------------------------------------- ! Note If you are willing to support Japanese man page, it - must be converted from EUC-JP to UTF-8 (by iconv, for example) - must be placed on %_mandir/ja/man1/timidity.1* - and must be marked as %lang(ja).

* Obsoletes - Please change Obsoletes to at least version specific (and why is this Obsoletes needed?)

* Parallel make - Please check if parallel make is possible.

* Timestamps - When using "cp" or "install" commands, please add "-p" option to keep timestamps.

* Verbose output - Any reason you want to use tar x"v"jf? (note that for %setup Fedora requests that it should be quiet)

* Hardcorded /etc - Is the reason you are using hardcorded /etc is the existence of Patch(0)? If so I was told to remove hardcoded path by like below: ------------------------------------------------------------- %setup -q -n TiMidity++-%{version} %Patch ......... # Ensure that we are actually using %%_sysconfdir sed -i.path -e 's|/etc/timidity.cfg|%{_sysconfdir}/timidity.cfg|' \ timidity/timidity.h

%build ------------------------------------------------------------- and replace all /etc with %_sysconfdir. I also think this is better. Or maybe it can be replaced by below? -------------------------------------------------------------- export EXTRACFLAGS="$RPM_OPT_FLAGS -DCONFIG_FILE="%{_sysconfdir}/timidity.cfg"" --------------------------------------------------------------

* rpmlint - Only one thing: ------------------------------------------------------------- timidity++-patches.i386: W: symlink-should-be-relative /usr/share/timidity/timidity.cfg /etc/timidity.cfg -------------------------------------------------------------

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

24 Jan 24 Jan

5:11 p.m.

New subject: [Bug 226492] Merge Review: timidity++

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: timidity++

https://bugzilla.redhat.com/show_bug.cgi?id=226492

------- Additional Comments From j.w.r.degoede@hhs.nl 2008-01-24 11:11 EST ------- (In reply to comment #2)

...

License check list: Source1,3,4: SourceURL links broken, and all binaries. What are these files? Maybe Public Domain? or like "Redistributable, no modification permitted"?

Bummer,

I've spend some time (lots of time) investigating this instruments.tar.bz2 contains the midia (a public domain SGI midi player) patch set which is still available here: ftp://ftp.funet.fi/pub/sci/audio/softsynths/midia/

Its a .tar.gz there, but after unpacking both are identical. There is no clear proof of this being public domain, other then it being allegedly pd here: http://www.opensound.com/softoss.html

Notice that opensound is not distributing it anymore themselves, nor can the complete midia player be found anywhere on the net.

I did eventually find this post where the author claims that the midia patches are modified copies of the patches distributed with the gravis ultrasound and thus are illegal: http://archive.netbsd.se/?ml=netbsd-tech-pkg&a=2006-10&t=2429714

Taking the disappearance of midia from the net into account this doesn't sound unbelievable.

...

So this leaves us with no patches and thus no midi playback capability, I've just checked Debian, and they have the same problem.

I've spend hours browsing the net for reasonably sized General Midi patch sets, none can be found in GUS .pat format, but I've found several in .sf2 format (which timidity can use too, we may need to convert it though for use with SDL_mixer / allegro / libtimidity / wildmidi).

All .sf2 GM patch sets I've found come either without a license statement, or one which is not compatible with Fedora :(

However I've send mail to all patchset authors that I could find a working mail address of, asking them for license conditions if none were given, and if they were given if they are willing to reword things so that they become compatible with Fedora's content guidelines.

I've send 6 mails in total, so stay tuned.

Since timidity has been part of RedHat since RedHat 6.2, presumably with these patches, I'm currently not planning on removing them immediately, hoping that we will have a backup for them in place soon, I'll send a private mail to Spot pointing him to this bug.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

6:13 p.m.

New subject: [Bug 226492] Merge Review: timidity++

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: timidity++

https://bugzilla.redhat.com/show_bug.cgi?id=226492

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-01-24 12:13 EST ------- Well, I don't know what "patch"es should exist to make use of timidity++, however is the following URL useful?

http://freepats.opensrc.org/

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

7:39 p.m.

New subject: [Bug 226492] Merge Review: timidity++

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: timidity++

https://bugzilla.redhat.com/show_bug.cgi?id=226492

------- Additional Comments From j.w.r.degoede@hhs.nl 2008-01-24 13:39 EST ------- (In reply to comment #4)

...

Well, I don't know what "patch"es should exist to make use of timidity++, however is the following URL useful?

http://freepats.opensrc.org/

Thanks for thinking along, but no, unfortunately that patchset does not give complete General Midi coverage (it only covers about 50%).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

9:21 p.m.

New subject: [Bug 226492] Merge Review: timidity++

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: timidity++

https://bugzilla.redhat.com/show_bug.cgi?id=226492

tcallawa@redhat.com changed:

------- Additional Comments From tcallawa@redhat.com 2008-01-24 15:21 EST ------- Well, freepats is better than nothing, I suppose. Blocking FE-Legal.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

25 Jan 25 Jan

11:35 a.m.

New subject: [Bug 226492] Merge Review: timidity++

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: timidity++

https://bugzilla.redhat.com/show_bug.cgi?id=226492

------- Additional Comments From jnovy@redhat.com 2008-01-25 05:35 EST ------- Committed most of the proposed review fixes.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

12:07 p.m.

New subject: [Bug 226492] Merge Review: timidity++

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: timidity++

https://bugzilla.redhat.com/show_bug.cgi?id=226492

------- Additional Comments From j.w.r.degoede@hhs.nl 2008-01-25 06:07 EST ------- (In reply to comment #7)

...

Committed most of the proposed review fixes.

Thanks,

2 comments:

1) is jack-audio-connection-kit-devel available on ppc64 now? I added those hacks because it wasn't. 2) The GPLv2 license trumps / encompasses / overrules the MIT an BSD licenses, so the resulting binary is effectively licensed under the GPLv2 only.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

12:14 p.m.

New subject: [Bug 226492] Merge Review: timidity++

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: timidity++

https://bugzilla.redhat.com/show_bug.cgi?id=226492

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-01-25 06:14 EST ------- (In reply to comment #8)

...

The GPLv2 license trumps / encompasses / overrules the MIT an BSD licenses, so the resulting binary is effectively licensed under the GPLv2 only.

As far as I checked the codes of timidity+, the license should be GPLv2+.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

12:18 p.m.

New subject: [Bug 226492] Merge Review: timidity++

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: timidity++

https://bugzilla.redhat.com/show_bug.cgi?id=226492

------- Additional Comments From jnovy@redhat.com 2008-01-25 06:18 EST ------- Hans, it seems that it still won't build on ppc64 with jack enabled:

http://koji.fedoraproject.org/koji/taskinfo?taskID=371942

So I reverted back to the ppc64 hack, we can try it again after some time :)

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

27 Jan 27 Jan

11:18 p.m.

New subject: [Bug 226492] Merge Review: timidity++

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: timidity++

https://bugzilla.redhat.com/show_bug.cgi?id=226492

------- Additional Comments From j.w.r.degoede@hhs.nl 2008-01-27 17:18 EST ------- Good news after lots of searching and negotiating with the author I've managed to find a soundfont that meets the content Guidelines for Fedora. I've already send the license past Spot and he has approved it.

I've packages it and submitted it for review. Its review is bug 430417. Note that in order to convert the original .sf2 file to gus patch format (needed by SDL_mixer, allegro, libtimidity and wildmidi) a conversion utility is needed, its review is bug 430418. So if someone can give me a hand and review these can then we can get rid of the not licensed gus patches we are currently using.

If you look at soundfont package, you will see that the spec file generates 2 packages: PersonalCopy-Lite-soundfont PersonalCopy-Lite-patches

The first contains the pristine .sf2 file from upstream, the other contains the same file converted into GUS patch format. Timidity++ can handle both, and seems to do somehat better with the .sf2 format (for one timidity does not support multiple velocity layers when reading the patches in the gus format).

So it would be best to make timidity depend upon the .sf2 format version. However that brings us to the question what todo with /etc/timidity.cfg, as already said: SDL_mixer, allegro, libtimidity and wildmidi all 4 only support the gus format, and they expect to be able to read a generalmidi mapping in gus format from /etc/timidity.cfg.

So my proposed solution is to let the gus format package install /etc/timidity.cfg (and provide timidity++-patches, as that is required by the 4 listed above), and let the .sf2 format package install /etc/timidity-soundfont.cfg.

I then combine this with a patch to timidity to first check for /etc/timidity-soundfont.conf and fallback to /etc/timidity.cfg if that is missing, and all is well. Any opinions / input on this?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

28 Jan 28 Jan

4:15 a.m.

New subject: [Bug 226492] Merge Review: timidity++

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: timidity++

https://bugzilla.redhat.com/show_bug.cgi?id=226492

mtasaka@ioa.s.u-tokyo.ac.jp changed:

What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |430417

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

3 Mar 3 Mar

5:03 p.m.

New subject: [Bug 226492] Merge Review: timidity++

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: timidity++

https://bugzilla.redhat.com/show_bug.cgi?id=226492

mtasaka@ioa.s.u-tokyo.ac.jp changed:

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-03-03 11:03 EST ------- (For people watching this Merge Review, please also check bug 430417)

FE-Legal removed.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

5:29 p.m.

New subject: [Bug 226492] Merge Review: timidity++

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: timidity++

https://bugzilla.redhat.com/show_bug.cgi?id=226492

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-03-03 11:29 EST ------- For 2.13.2-13:

* Patches merge - Please merge the patches which can be merged (especially a patch and a patch to the patch, e.g. Patch(0) and Patch16)

* License - Now License tag is just GPLv2.

* Macros - Unify macros usage. For example (I have not checked all macros usage inconsistency) ------------------------------------------------------- echo "soundfont /usr/share/soundfonts/PCLite.sf2" > \ $RPM_BUILD_ROOT/%{_sysconfdir}/timidity++.cfg ...... %config(noreplace) /etc/timidity++.cfg ------------------------------------------------------- echo "soundfont /usr/share/soundfonts/PCLite.sf2" > \ $RPM_BUILD_ROOT/%{_sysconfdir}/timidity++.cfg

(From PersonalCopy-Lite-soundfont:) %{_datadir}/soundfonts -------------------------------------------------------

- For hardcoded /etc, please also check my comment 2.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

9:17 p.m.

New subject: [Bug 226492] Merge Review: timidity++

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: timidity++

https://bugzilla.redhat.com/show_bug.cgi?id=226492

------- Additional Comments From j.w.r.degoede@hhs.nl 2008-03-03 15:17 EST ------- (In reply to comment #13)

...

For 2.13.2-13:

Patches merge

Please merge the patches which can be merged (especially a patch and a patch to the patch, e.g. Patch(0) and Patch16)

License

Now License tag is just GPLv2.

Macros

Unify macros usage. For example (I have not checked all macros usage inconsistency)

All fixed.

...

For hardcoded /etc, please also check my comment 2.

Erm, asking consistent use of %{_sysconfdir} in a .spec I agree with, but asking to use rpm macros in patches, thats just pedantic: -ewontfix

New version with the 3 items above fixed: http://people.atrpms.net/~hdegoede/timidity++.spec http://people.atrpms.net/~hdegoede/timidity++-2.13.2-13.fc9.src.rpm

Note to people watching along this is not build / committed to CVS yet as it requires PersonalCopy-Lite-soundfont which is under review, see bug 430417.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

4 Mar 4 Mar

11:36 a.m.

New subject: [Bug 226492] Merge Review: timidity++

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: timidity++

https://bugzilla.redhat.com/show_bug.cgi?id=226492

mtasaka@ioa.s.u-tokyo.ac.jp changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-03-04 05:36 EST ------- Okay.

-------------------------------------------------------------------- This package (timidity++) is APPROVED by me --------------------------------------------------------------------

Please rebuild PersonalCopy-Lite-soundfont (bug 430417) first for timidity++-patches obsoletes.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

8:48 p.m.

New subject: [Bug 226492] Merge Review: timidity++

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: timidity++

https://bugzilla.redhat.com/show_bug.cgi?id=226492

Bug 226492 depends on bug 430417, which changed state.

Bug 430417 Summary: Review Request: PersonalCopy-Lite-soundfont - Lite version of the PersonalCopy General Midi soundfont https://bugzilla.redhat.com/show_bug.cgi?id=430417

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

10:03 p.m.

New subject: [Bug 226492] Merge Review: timidity++

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: timidity++

https://bugzilla.redhat.com/show_bug.cgi?id=226492

------- Additional Comments From j.w.r.degoede@hhs.nl 2008-03-04 16:03 EST ------- PersonalCopy-Lite-soundfont imported and build. propsed new timidity++ package committed and build in rawhide, closing.

Note I will also be builing both packages as an update for F-7 and F-8 to resolve the license issues there too (by request of Spot).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

10:05 p.m.

New subject: [Bug 226492] Merge Review: timidity++

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: timidity++

https://bugzilla.redhat.com/show_bug.cgi?id=226492

j.w.r.degoede@hhs.nl changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

10:06 p.m.

New subject: [Bug 226492] Merge Review: timidity++

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: timidity++

https://bugzilla.redhat.com/show_bug.cgi?id=226492

------- Additional Comments From j.w.r.degoede@hhs.nl 2008-03-04 16:06 EST ------- p.s.

Mamoru, I forgot to say this before:

Many thanks for the review!

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

6349

Age (days ago)

6747

Last active (days ago)

package-review@lists.fedoraproject.org

20 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla