[Bug 2362270] New: Review Request: yumex - Yum Extender graphical package management tool
https://bugzilla.redhat.com/show_bug.cgi?id=2362270
Bug ID: 2362270 Summary: Review Request: yumex - Yum Extender graphical package management tool Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: tim.lauridsen@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://raw.githubusercontent.com/timlau/yumex-ng/refs/heads/5.2.x/yumex.spe... SRPM URL: https://github.com/timlau/yumex-ng/releases/download/yumex-5.2.0/yumex-5.2.0... Description: Yum Extender graphical package management tool Fedora Account System Username: timlau
https://bugzilla.redhat.com/show_bug.cgi?id=2362270
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |http://yumex.dk
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8966473 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- Not a valid SPDX expression 'GPLv3+'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/yumex Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicti... - Systemd user unit service file(s) in yumex-updater Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_... - icons in yumex, yumex-updater - desktop file(s) with MimeType entry in yumex Read more: https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=4...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2362270
Tim Lauridsen tim.lauridsen@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |Unretirement
https://bugzilla.redhat.com/show_bug.cgi?id=2362270
Tim Lauridsen tim.lauridsen@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL|http://yumex.dk |https://github.com/timlau/y | |umex-ng
https://bugzilla.redhat.com/show_bug.cgi?id=2362270
--- Comment #2 from Tim Lauridsen tim.lauridsen@gmail.com --- Spec URL: https://raw.githubusercontent.com/timlau/yumex-ng/refs/tags/fedora-review/yu... SRPM URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex-5.2...
Make license a valid SPDX expression
https://bugzilla.redhat.com/show_bug.cgi?id=2362270
--- Comment #3 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2087176 --> https://bugzilla.redhat.com/attachment.cgi?id=2087176&action=edit The .spec file difference from Copr build 8966473 to 8966615
https://bugzilla.redhat.com/show_bug.cgi?id=2362270
--- Comment #4 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8966615 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/yumex Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicti... - Upstream MD5sum check error, diff is in /var/lib/copr-rpmbuild/results/yumex/diff.txt Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ - Systemd user unit service file(s) in yumex-updater Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_... - icons in yumex, yumex-updater - desktop file(s) with MimeType entry in yumex Read more: https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=4...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2362270
--- Comment #5 from Tim Lauridsen tim.lauridsen@gmail.com ---
Spec URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex.spe... SRPM URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex-5.2...
- removed update-desktop-database calls - build SPRM with upstream sources, so MD5SUM will match - the name should be ok, as this is an un-retirement of the old yumex package, that was maintained by me, back in the days
https://bugzilla.redhat.com/show_bug.cgi?id=2362270
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2087178 --> https://bugzilla.redhat.com/attachment.cgi?id=2087178&action=edit The .spec file difference from Copr build 8966615 to 8966667
https://bugzilla.redhat.com/show_bug.cgi?id=2362270
--- Comment #7 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8966667 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/yumex Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicti... - Systemd user unit service file(s) in yumex-updater Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_... - icons in yumex, yumex-updater
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2362270
--- Comment #8 from Tim Lauridsen tim.lauridsen@gmail.com --- Spec URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex.spe... SRPM URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex-5.2...
- cleanup systemd service scriptlets (https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_...) - cleanup icon handling (https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=4...)
https://bugzilla.redhat.com/show_bug.cgi?id=2362270
--- Comment #9 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2087190 --> https://bugzilla.redhat.com/attachment.cgi?id=2087190&action=edit The .spec file difference from Copr build 8966667 to 8967061
https://bugzilla.redhat.com/show_bug.cgi?id=2362270
--- Comment #10 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8967061 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/yumex Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicti... - Systemd user unit service file(s) in yumex-updater Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_... - icons in yumex, yumex-updater
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2362270
--- Comment #11 from Tim Lauridsen tim.lauridsen@gmail.com --- Spec URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex.spe... SRPM URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex-5.2...
- Removed calls to gtk-update-icon-cache from %posttrans
https://bugzilla.redhat.com/show_bug.cgi?id=2362270
--- Comment #12 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2087192 --> https://bugzilla.redhat.com/attachment.cgi?id=2087192&action=edit The .spec file difference from Copr build 8967061 to 8967105
https://bugzilla.redhat.com/show_bug.cgi?id=2362270
--- Comment #13 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8967105 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/yumex Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicti... - Systemd user unit service file(s) in yumex-updater Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2362270
--- Comment #14 from Tim Lauridsen tim.lauridsen@gmail.com --- Spec URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex.spe... SRPM URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex-5.2...
- fix ownership for /usr/share/yumex
https://bugzilla.redhat.com/show_bug.cgi?id=2362270
--- Comment #15 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2087232 --> https://bugzilla.redhat.com/attachment.cgi?id=2087232&action=edit The .spec file difference from Copr build 8967105 to 8967335
https://bugzilla.redhat.com/show_bug.cgi?id=2362270
--- Comment #16 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8967335 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/yumex Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicti... - Systemd user unit service file(s) in yumex-updater Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2362270
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? Assignee|nobody@fedoraproject.org |ngompa13@gmail.com CC| |ngompa13@gmail.com
--- Comment #17 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=2362270
--- Comment #18 from Tim Lauridsen tim.lauridsen@gmail.com --- Spec URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex.spe... SRPM URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex-5.2...
- changed to use %autorelease & %autochangelog as preferred for new fedora packages. - removed old obsoletes of yumex-dnf, not need as there is no relation or upgrade path from yumex-dnf to current yumex (both have been retired in Fedora for years)
https://bugzilla.redhat.com/show_bug.cgi?id=2362270
--- Comment #19 from Tim Lauridsen tim.lauridsen@gmail.com ---
New Yum Extender release
Spec URL: https://github.com/timlau/yumex-ng/releases/download/yumex-5.4.0/yumex.spec SRPM URL: https://github.com/timlau/yumex-ng/releases/download/yumex-5.4.0/yumex-5.4.0...
https://bugzilla.redhat.com/show_bug.cgi?id=2362270
--- Comment #20 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2109259 --> https://bugzilla.redhat.com/attachment.cgi?id=2109259&action=edit The .spec file difference from Copr build 8967335 to 9676784
https://bugzilla.redhat.com/show_bug.cgi?id=2362270
--- Comment #21 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9676784 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/yumex Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicti... - Systemd user unit service file(s) in yumex-updater Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2362270
--- Comment #22 from Tim Lauridsen tim.lauridsen@gmail.com --- Hi ngompa13@gmail.com
Hope you soon will have a moment to complete this review
Thanks in advance
/Tim
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com