Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: colorgcc - Script to colorize the terminal output of gcc, g++, cc, c++
https://bugzilla.redhat.com/show_bug.cgi?id=700833
Summary: Review Request: colorgcc - Script to colorize the terminal output of gcc, g++, cc, c++ Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mcermak@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: ---
Spec URL: http://www.physics.muni.cz/~cermak/colorgcc/colorgcc.spec SRPM URL: http://www.physics.muni.cz/~cermak/colorgcc/colorgcc-1.3.2-1.fc14.src.rpm Patch0 URL: http://www.physics.muni.cz/~cermak/colorgcc/colorgcc-1.3.2-invocation.patch
Description:
Hi! I had a look at the Package maintainers wishlist [1] and decided to get the colorgcc script packaged for Fedora. I would appreciate a review.
+ rpmlint colorgcc.spec colorgcc.spec: W: no-%build-section 0 packages and 1 specfiles checked; 0 errors, 1 warnings. + rpmlint colorgcc-1.3.2-1.fc14.src.rpm colorgcc.src: W: no-%build-section 1 packages and 0 specfiles checked; 0 errors, 1 warnings. + rpmlint colorgcc-1.3.2-1.fc14.noarch.rpm colorgcc.noarch: W: no-documentation colorgcc.noarch: W: no-manual-page-for-binary color-g++ colorgcc.noarch: W: no-manual-page-for-binary color-cc colorgcc.noarch: W: no-manual-page-for-binary color-gcc colorgcc.noarch: W: no-manual-page-for-binary color-c++ 1 packages and 0 specfiles checked; 0 errors, 5 warnings.
------------------------------- [1] http://fedoraproject.org/wiki/PackageMaintainers/WishList
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700833
Martin Cermak mcermak@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841(FE-NEEDSPONSOR)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700833
Thomas Spura tomspur@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tomspur@fedoraproject.org
--- Comment #1 from Thomas Spura tomspur@fedoraproject.org 2011-04-29 11:16:30 EDT --- Hmm, is there an easy way to call ccache instead of gcc within colorgcc? Currently I have this for calling colorgcc: $ ll /usr/local/bin/ insgesamt 0 lrwxrwxrwx. 1 root root 15 15. Mai 2010 cc -> /usr/bin/ccache lrwxrwxrwx. 1 root root 15 15. Mai 2010 g++ -> /usr/bin/ccache lrwxrwxrwx. 1 root root 15 15. Mai 2010 gcc -> /usr/bin/ccache
Replacing that link to color-gcc will unfortunately disable ccache...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700833
Hans de Goede hdegoede@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |hdegoede@redhat.com Blocks|177841(FE-NEEDSPONSOR) | AssignedTo|nobody@fedoraproject.org |hdegoede@redhat.com
--- Comment #2 from Hans de Goede hdegoede@redhat.com 2011-04-30 04:34:57 EDT --- Reviewing this one ...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700833
Hans de Goede hdegoede@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #3 from Hans de Goede hdegoede@redhat.com 2011-04-30 04:43:26 EDT --- Full review done:
Good: ===== - rpmlint checks return: colorgcc.src: W: no-%build-section colorgcc.noarch: W: no-documentation colorgcc.noarch: W: no-manual-page-for-binary color-g++ colorgcc.noarch: W: no-manual-page-for-binary color-cc colorgcc.noarch: W: no-manual-page-for-binary color-gcc colorgcc.noarch: W: no-manual-page-for-binary color-c++ These can all be ignored - package meets naming guidelines - package meets packaging guidelines - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file
Needs work: ----------- - Please use the full URL for Source0
- The license tag should be GPL+, per: http://fedoraproject.org/wiki/Licensing See the GPL (no version) table
- If you're not adding a %clean, nor cleaning the buildroot in %install, you should not specify a buildroot at all, so drop: BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
- A bitter way to handle %prep would be: %prep %setup -q -c -T cp -p %{SOURCE0} . %patch0 -p1 You can then also drop the "cd %{name}-%{version}" from %install
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700833
--- Comment #4 from Jason Tibbitts tibbs@math.uh.edu 2011-04-30 14:15:48 EDT --- I see no SCM request to process.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700833
Hans de Goede hdegoede@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700833
--- Comment #5 from Martin Cermak mcermak@redhat.com 2011-05-06 02:56:56 EDT ---
Needs work:
Please use the full URL for Source0
The license tag should be GPL+, per: http://fedoraproject.org/wiki/Licensing See the GPL (no version) table
If you're not adding a %clean, nor cleaning the buildroot in %install, you
should not specify a buildroot at all, so drop: BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
- A bitter way to handle %prep would be:
%prep %setup -q -c -T cp -p %{SOURCE0} . %patch0 -p1 You can then also drop the "cd %{name}-%{version}" from %install
This should be resolved in colorgcc-1.3.2-2:
Spec URL: http://www.physics.muni.cz/~cermak/colorgcc-1.3.2-2/colorgcc.spec SRPM URL: http://www.physics.muni.cz/~cermak/colorgcc-1.3.2-2/colorgcc-1.3.2-2.fc14.sr... Patch0 URL: http://www.physics.muni.cz/~cermak/colorgcc-1.3.2-2/colorgcc-1.3.2-invocatio...
$ rpmlint colorgcc.spec colorgcc.spec: W: no-%build-section 0 packages and 1 specfiles checked; 0 errors, 1 warnings.
$ rpmlint colorgcc-1.3.2-2.fc14.src.rpm colorgcc.src: W: no-%build-section 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
$ rpmlint colorgcc-1.3.2-2.fc14.noarch.rpm colorgcc.noarch: W: no-documentation colorgcc.noarch: W: no-manual-page-for-binary color-gcc colorgcc.noarch: W: no-manual-page-for-binary color-g++ colorgcc.noarch: W: no-manual-page-for-binary color-cc colorgcc.noarch: W: no-manual-page-for-binary color-ccache colorgcc.noarch: W: no-manual-page-for-binary color-c++ 1 packages and 0 specfiles checked; 0 errors, 6 warnings.
Hmm, is there an easy way to call ccache instead of gcc within colorgcc? Currently I have this for calling colorgcc: $ ll /usr/local/bin/ insgesamt 0 lrwxrwxrwx. 1 root root 15 15. Mai 2010 cc -> /usr/bin/ccache lrwxrwxrwx. 1 root root 15 15. Mai 2010 g++ -> /usr/bin/ccache lrwxrwxrwx. 1 root root 15 15. Mai 2010 gcc -> /usr/bin/ccache
Replacing that link to color-gcc will unfortunately disable ccache...
On a fresh F14 system, ccache is called transparently if you call gcc:
$ strace -eexecve -f gcc hello.c 2>&1 | grep ^execve | grep -v ENOENT execve("/usr/lib64/ccache/gcc", ["gcc", "hello.c"], [/* 33 vars */]) = 0 execve("/usr/bin/gcc", ["/usr/bin/gcc", "hello.c"], [/* 34 vars */]) = 0
So I just removed absolute paths pointing to compiler binaries from colorgcc. Now it should work as expected if you have ccache installed:
$ strace -eexecve -f color-gcc hello.c 2>&1 | grep ^execve | grep -v ENOENT execve("/usr/bin/color-gcc", ["color-gcc", "hello.c"], [/* 33 vars */]) = 0 execve("/usr/lib64/ccache/gcc", ["gcc", "hello.c"], [/* 33 vars */]) = 0 execve("/usr/bin/gcc", ["/usr/bin/gcc", "hello.c"], [/* 34 vars */]) = 0
And also if you haven't:
trace -eexecve -f color-gcc hello.c 2>&1 | grep ^execve | grep -v ENOENT execve("/usr/bin/color-gcc", ["color-gcc", "hello.c"], [/* 33 vars */]) = 0 execve("/usr/bin/gcc", ["gcc", "hello.c"], [/* 33 vars */]) = 0
And I also provided the color-ccache link:
$ rpm -ql colorgcc /usr/bin/color-c++ /usr/bin/color-cc /usr/bin/color-ccache /usr/bin/color-g++ /usr/bin/color-gcc
Hope I didn't miss something. What remains is to set up some nice aliases... :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700833
Hans de Goede hdegoede@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #6 from Hans de Goede hdegoede@redhat.com 2011-05-06 09:29:35 EDT --- Looks good now: approved.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700833
Martin Cermak mcermak@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #7 from Martin Cermak mcermak@redhat.com 2011-05-07 06:44:57 EDT --- New Package SCM Request ======================= Package Name: colorgcc Short Description: Script to colorize the compiler output Owners: mcermak Branches: f14 f15 InitialCC: jwrdegoede
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700833
--- Comment #8 from Jason Tibbitts tibbs@math.uh.edu 2011-05-10 11:53:16 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700833
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700833
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2011-05-13 05:27:10 EDT --- colorgcc-1.3.2-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/colorgcc-1.3.2-2.fc15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700833
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2011-05-13 05:32:25 EDT --- colorgcc-1.3.2-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/colorgcc-1.3.2-2.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700833
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2011-05-13 19:11:14 EDT --- colorgcc-1.3.2-2.fc14 has been pushed to the Fedora 14 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700833
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2011-05-24 23:07:19 EDT --- colorgcc-1.3.2-2.fc14 has been pushed to the Fedora 14 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700833
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |colorgcc-1.3.2-2.fc14 Resolution| |ERRATA Last Closed| |2011-05-24 23:07:24
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700833
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2011-06-08 19:56:00 EDT --- colorgcc-1.3.2-2.fc15 has been pushed to the Fedora 15 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700833
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|colorgcc-1.3.2-2.fc14 |colorgcc-1.3.2-2.fc15
package-review@lists.fedoraproject.org