Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: libksane - SANE Library interface for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=719327
Summary: Review Request: libksane - SANE Library interface for KDE Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rdieter@math.unl.edu QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: ---
Spec URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libksane.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libksane-4.6.90-1.fc15.src.... Description: SANE Library interface for KDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719327
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |656997(kde-reviews) Alias| |libksane
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719327
--- Comment #1 from Rex Dieter rdieter@math.unl.edu 2011-07-06 09:58:00 EDT --- *** Bug 719326 has been marked as a duplicate of this bug. ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719327
nucleo alekcejk@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |alekcejk@googlemail.com QAContact|extras-qa@fedoraproject.org |alekcejk@googlemail.com Flag| |fedora-review?
--- Comment #2 from nucleo alekcejk@googlemail.com 2011-07-10 15:54:43 EDT --- rpmlint output for libksane-4.6.90-2 rpms built from http://rdieter.fedorapeople.org/rpms/kdegraphics/libksane-4.6.90-2.fc15.src....
libksane-devel.i686: W: no-documentation libksane-devel.x86_64: W: no-documentation 7 packages and 0 specfiles checked; 0 errors, 2 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719327
--- Comment #3 from nucleo alekcejk@googlemail.com 2011-07-10 16:03:24 EDT --- Package and spec names are fine, license LGPLv2+ is actual license used in libksane sources (twain.h is not used when system libsane found), Requires in devel package fine, scriptlets are fine. Package builds in mock http://koji.fedoraproject.org/koji/taskinfo?taskID=3189868
The only thing should be fixed is replace COPYING with COPYING.LIB in %doc because this license used here.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719327
--- Comment #4 from Rex Dieter rdieter@math.unl.edu 2011-07-10 16:30:54 EDT ---
Spec URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libksane.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libksane-4.6.90-3.fc15.src....
%changelog * Sun Jul 10 2011 Rex Dieter rdieter@fedoraproject.org 4.6.90-3 - %%doc COPYING.LIB - add basic %%check section
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719327
nucleo alekcejk@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #5 from nucleo alekcejk@googlemail.com 2011-07-10 16:53:36 EDT --- libksane-4.6.90-3 also builds in mock http://koji.fedoraproject.org/koji/taskinfo?taskID=3189893 rpmlint output fine. So all issues fixed now and
package is APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719327
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag| |fedora-cvs?
--- Comment #6 from Rex Dieter rdieter@math.unl.edu 2011-07-10 18:51:06 EDT --- Thanks.
New Package SCM Request ======================= Package Name: libksane Short Description: SANE Library interface for KDE Owners: than rdieter jreznik kkofler ltinkl rnovacek rrix Branches: f15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719327
--- Comment #7 from nucleo alekcejk@googlemail.com 2011-07-10 21:19:35 EDT --- It is will be better to change URL to https://projects.kde.org/projects/kde/kdegraphics/libs/libksane Sorry that I not noticed this before.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719327
--- Comment #8 from Jon Ciesla limb@jcomserv.net 2011-07-11 11:14:38 EDT --- Git done (by process-git-requests).
nucleo, please take ownership of review tickets you're working on. Thank you!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719327
nucleo alekcejk@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |alekcejk@googlemail.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719327
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Last Closed| |2011-07-12 13:08:41
--- Comment #9 from Rex Dieter rdieter@math.unl.edu 2011-07-12 13:08:41 EDT --- imported.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719327
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|656997(kde-reviews) |
package-review@lists.fedoraproject.org