Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: eclipse-emf-query - Specify and execute queries against EMF models
https://bugzilla.redhat.com/show_bug.cgi?id=537451
Summary: Review Request: eclipse-emf-query - Specify and execute queries against EMF models Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: fedora@matbooth.co.uk QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
This package depends eclipse-mdt-ocl, whose review request is bug #536684.
Spec URL: http://mbooth.fedorapeople.org/reviews/eclipse-emf-query.spec SRPM URL: http://mbooth.fedorapeople.org/reviews/eclipse-emf-query-1.3.0-1.fc12.src.rp...
Description: The query component facilitates the process of search and retrieval of model elements of interest in a flexible yet controlled and structured manner. Provides API support for the basic EObject based Condition objects that are used to formulate queries for EMF models.
* The IEObjectSource interface provides the search scope elements to be used in a query. * The SELECT class implements a template-function that does the iteration over model elements and applies the search condition on each; it collects the resulting elements into a QueryResultSet object and returns it to the caller * The FROM class represents the elements to search. It is responsible of providing an appropriate iterator for the elements in the search space. * The WHERE class applies the search conditions over the elements in the search set. * The UPDATE class passes the elements who satisfy the search condition to a caller-supplied modification function. It collects the modified elements into a QueryResultSet object and returns it to the caller. * The QueryResultSet class represents the set of elements returned by a given query. * The EObjectCondition class is the abstract parent of all conditions that deal with model-elements (i.e., EObjects). It incorporates the services of a PruneHandler in order to answers whether or not to prune the element tree at a specific element and thus ignore its children. * The ConditionPolicy class is used to allow the user to decide how to apply a given condition on a collection of a model-element EAttributes or EReferences values. Supports both the: exists (ANY) and for-all (ALL) semantics. * The EObjectStructuralFeatureValueCondition class is the parent class for conditions that are responsible for checking the values held in model- elements attributes or references.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=537451
Mat Booth fedora@matbooth.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |537454
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=537451
Mat Booth fedora@matbooth.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |536684
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=537451
Lubomir Rintel lkundrak@v3.sk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |lkundrak@v3.sk AssignedTo|nobody@fedoraproject.org |lkundrak@v3.sk Flag| |fedora-review?
--- Comment #1 from Lubomir Rintel lkundrak@v3.sk 2009-11-21 14:27:46 EDT --- * Package name and version are in accordance with packaging guidelines * SPEC file clean, legible and well-commented * License tag correct, license packaged as %doc * Filelist okay, for directories it uses and does now it depends on packages that provide them * Provides/Require list ok (mock build did not finish yet)
Objections:
1.) Why do you check stuff out from CVS?
2.) Please don't pretty-format the Description, please use complete sentences. It does not always look well in package management front-ends.
3.) RPMLint:
eclipse-emf-query.noarch: W: spurious-executable-perm /usr/share/doc/eclipse-emf-query-1.3.0/epl-v10.html The file is installed with executable permissions, but was identified as one that probably should not be executable. Verify if the executable bits are desired, and remove if not.
eclipse-emf-query.noarch: W: spurious-executable-perm /usr/share/doc/eclipse-emf-query-1.3.0/notice.html The file is installed with executable permissions, but was identified as one that probably should not be executable. Verify if the executable bits are desired, and remove if not.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=537451
--- Comment #2 from Lubomir Rintel lkundrak@v3.sk 2009-11-21 18:50:47 EDT --- * built fine in mock
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=537451
--- Comment #3 from Mat Booth fedora@matbooth.co.uk 2009-11-24 06:42:10 EDT --- (In reply to comment #1)
- Package name and version are in accordance with packaging guidelines
- SPEC file clean, legible and well-commented
- License tag correct, license packaged as %doc
- Filelist okay, for directories it uses and does now it depends on packages
that provide them
- Provides/Require list ok
(mock build did not finish yet)
Objections:
1.) Why do you check stuff out from CVS?
This should be satisfactorily answered in bug #536683.
2.) Please don't pretty-format the Description, please use complete sentences. It does not always look well in package management front-ends.
3.) RPMLint:
eclipse-emf-query.noarch: W: spurious-executable-perm /usr/share/doc/eclipse-emf-query-1.3.0/epl-v10.html The file is installed with executable permissions, but was identified as one that probably should not be executable. Verify if the executable bits are desired, and remove if not.
eclipse-emf-query.noarch: W: spurious-executable-perm /usr/share/doc/eclipse-emf-query-1.3.0/notice.html The file is installed with executable permissions, but was identified as one that probably should not be executable. Verify if the executable bits are desired, and remove if not.
Done and done:
Spec URL: http://mbooth.fedorapeople.org/reviews/eclipse-emf-query.spec SRPM URL: http://mbooth.fedorapeople.org/reviews/eclipse-emf-query-1.3.0-2.fc10.src.rp...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=537451
Lubomir Rintel lkundrak@v3.sk changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #4 from Lubomir Rintel lkundrak@v3.sk 2009-11-27 07:14:44 EDT --- Thank you!
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=537451
Mat Booth fedora@matbooth.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #5 from Mat Booth fedora@matbooth.co.uk 2009-11-27 09:06:29 EDT --- (In reply to comment #4)
Thank you!
APPROVED
Thanks.
New Package CVS Request ======================= Package Name: eclipse-emf-query Short Description: Specify and execute queries against EMF models Owners: mbooth Branches: F-12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=537451
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #6 from Jason Tibbitts tibbs@math.uh.edu 2009-12-01 13:46:17 EDT --- CVS done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=537451
Bug 537451 depends on bug 536684, which changed state.
Bug 536684 Summary: Review Request: eclipse-mdt-ocl - Implementation of the OCL OMG metamodel for Eclipse https://bugzilla.redhat.com/show_bug.cgi?id=536684
What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=537451
Mat Booth fedora@matbooth.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
--- Comment #7 from Mat Booth fedora@matbooth.co.uk 2009-12-01 16:23:09 EDT --- Built successfully in rawhide, closing.
package-review@lists.fedoraproject.org