[Bug 2049382] New: Review Request: aws-c-auth - C99 library implementation of AWS client-side authentication: standard credentials providers and signing.
https://bugzilla.redhat.com/show_bug.cgi?id=2049382
Bug ID: 2049382 Summary: Review Request: aws-c-auth - C99 library implementation of AWS client-side authentication: standard credentials providers and signing. Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: davdunc@amazon.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://davdunc.fedorapeople.org/awscli-2-rpms/aws-c-auth.spec SRPM URL: https://davdunc.fedorapeople.org/awscli-2-rpms/aws-c-auth-0.6.5-1.fc35.src.r... Description: C99 library implementation of AWS client-side authentication: standard credentials providers and signing. Fedora Account System Username: davdunc
https://bugzilla.redhat.com/show_bug.cgi?id=2049382
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? Assignee|nobody@fedoraproject.org |ngompa13@gmail.com
--- Comment #2 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=2049382
--- Comment #3 from Neal Gompa ngompa13@gmail.com ---
%files %license LICENSE %doc README.md
%files libs %{_libdir}/libaws-c-auth.so %{_libdir}/libaws-c-auth.so.1.0.0
These two files sections can be collapsed into a single "%files libs" section.
And "%{_libdir}/libaws-c-auth.so" needs to be in the devel subpackage.
Finally, with these changes, the libs subpackage shouldn't depend on an empty main package that isn't going to be made, so:
Requires: %{name}%{?_isa} = %{version}-%{release}
should be dropped.
https://bugzilla.redhat.com/show_bug.cgi?id=2049382
--- Comment #4 from Neal Gompa ngompa13@gmail.com ---
%{_libdir}/aws-c-auth/cmake/aws-c-auth-config.cmake %{_libdir}/aws-c-auth/cmake/shared/aws-c-auth-targets-noconfig.cmake %{_libdir}/aws-c-auth/cmake/shared/aws-c-auth-targets.cmake
The directory structure is wrong here. This needs to be "%{_libdir}/cmake/aws-c-auth" instead of "%{_libdir}/aws-c-auth/cmake". The CMake dependency generator isn't picking up anything and CMake can't use the modules unless it's in the right directory structure.
https://bugzilla.redhat.com/show_bug.cgi?id=2049382
David Duncan davdunc@amazon.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2049644
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2049644 [Bug 2049644] Review Request: aws-c-io - This is a module for the AWS SDK for C.
https://bugzilla.redhat.com/show_bug.cgi?id=2049382
--- Comment #5 from David Duncan davdunc@amazon.com --- Updated for all of these issues. Bumped spec SPEC: https://davdunc.fedorapeople.org/awscli-2-rpms/aws-c-auth.spec SRPM: https://davdunc.fedorapeople.org/awscli-2-rpms/aws-c-auth-0.6.5-3.fc35.src.r...
https://bugzilla.redhat.com/show_bug.cgi?id=2049382
David Duncan davdunc@amazon.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(ngompa13@gmail.co | |m)
https://bugzilla.redhat.com/show_bug.cgi?id=2049382
David Duncan davdunc@amazon.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(ngompa13@gmail.co | |m)
https://bugzilla.redhat.com/show_bug.cgi?id=2049382
David Duncan davdunc@amazon.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(ngompa13@gmail.co | |m)
--- Comment #6 from David Duncan davdunc@amazon.com --- SRPM URL: https://davdunc.fedorapeople.org/awscli-2-rpms/aws-c-auth-0.6.5-6.fc35.src.r... Spec URL: https://davdunc.fedorapeople.org/awscli-2-rpms/aws-c-auth.spec
https://bugzilla.redhat.com/show_bug.cgi?id=2049382
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ngompa13@gmail.co | |m) | |needinfo?(ngompa13@gmail.co | |m) | |needinfo?(ngompa13@gmail.co | |m) |
--- Comment #7 from Neal Gompa ngompa13@gmail.com --- This can't proceed until its build dependencies are cleared.
https://bugzilla.redhat.com/show_bug.cgi?id=2049382 Bug 2049382 depends on bug 2049379, which changed state.
Bug 2049379 Summary: Review Request: aws-c-common - Core c99 package for AWS SDK for C https://bugzilla.redhat.com/show_bug.cgi?id=2049379
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=2049382
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ngompa13@gmail.co | |m) |
Product: Fedora Version: rawhide Component: Package Review
Neal Gompa ngompa13@gmail.com has canceled Package Review package-review@lists.fedoraproject.org's request for Neal Gompa ngompa13@gmail.com's needinfo: Bug 2049382: Review Request: aws-c-auth - C99 library implementation of AWS client-side authentication: standard credentials providers and signing. https://bugzilla.redhat.com/show_bug.cgi?id=2049382
https://bugzilla.redhat.com/show_bug.cgi?id=2049382
Dominik Wombacher dominik@wombacher.cc changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2279003
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2279003 [Bug 2279003] Review Request: aws-c-sdkutils - C99 library implementing AWS SDK specific utilities.
https://bugzilla.redhat.com/show_bug.cgi?id=2049382 Bug 2049382 depends on bug 2049397, which changed state.
Bug 2049397 Summary: Review Request: aws-c-sdkutils - AWS SDK Utility library https://bugzilla.redhat.com/show_bug.cgi?id=2049397
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |DUPLICATE
https://bugzilla.redhat.com/show_bug.cgi?id=2049382
Dominik Wombacher dominik@wombacher.cc changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |DUPLICATE CC| |dominik@wombacher.cc Last Closed| |2024-05-03 22:41:40
--- Comment #9 from Dominik Wombacher dominik@wombacher.cc ---
*** This bug has been marked as a duplicate of bug 2279012 ***
https://bugzilla.redhat.com/show_bug.cgi?id=2049382 Bug 2049382 depends on bug 2049400, which changed state.
Bug 2049400 Summary: Review Request: aws-c-cal - Aws Crypto Abstraction Layer: Cross-Platform, C99 wrapper for cryptography primitives. https://bugzilla.redhat.com/show_bug.cgi?id=2049400
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |NEXTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=2049382 Bug 2049382 depends on bug 2279003, which changed state.
Bug 2279003 Summary: Review Request: aws-c-sdkutils - C99 library implementing AWS SDK specific utilities. https://bugzilla.redhat.com/show_bug.cgi?id=2279003
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |NEXTRELEASE
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com