[Bug 910835] New: Review Request: snotes - A flexible and easy to use notes system

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=910835

Bug ID: 910835
           Summary: Review Request: snotes - A flexible and easy to use
                    notes system
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Reporter: [e-mail]

Spec URL: http://psabata.fedorapeople.org/pkgs/snotes/snotes.spec
SRPM URL: http://psabata.fedorapeople.org/pkgs/snotes/snotes-1.0-1.fc18.src.rpm
Description: A flexible and easy to use notes system
Fedora Account System Username: psabata

[Bug 910835] Review Request: snotes - A flexible and easy to use notes system

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=910835

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

[Bug 910835] Review Request: snotes - A flexible and easy to use notes system

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=910835

--- Comment #1 from Petr Šabata  ---
I've updated the package with some forgotten runtime deps:

Spec URL: http://psabata.fedorapeople.org/pkgs/snotes/snotes.spec
SRPM URL: http://psabata.fedorapeople.org/pkgs/snotes/snotes-1.0-2.fc18.src.rpm

[Bug 910835] Review Request: snotes - A flexible and easy to use notes system

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=910835

--- Comment #2 from Petr Pisar  ---
URL and Source0 are usable. Ok.
Source tar ball is original (SHA-256:
782547cc4db6591d9db015eac49062e62837b2bd4bc4bdaa358a60e268081242). Ok.

FIX: Run-require `git' (snotes:49).

perl is optional. Ok.

TODO: Run-require `xterm'. This the similar to already run-required
`vim-minimal' (snotes:30).

$ rpmlint snotes.spec ../SRPMS/snotes-1.0-1.fc19.src.rpm
../RPMS/noarch/snotes-1.0-1.fc19.noarch.rpm 
snotes.noarch: W: no-manual-page-for-binary snotes
snotes.noarch: W: no-manual-page-for-binary snotes-open
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/snotes-1.0-1.fc19.noarch.rpm
-rwxr-xr-x    1 root    root                     5028 Feb 14 09:20
/usr/bin/snotes
-rwxr-xr-x    1 root    root                     2793 Feb 14 09:20
/usr/bin/snotes-open
drwxr-xr-x    2 root    root                        0 Feb 14 09:20
/usr/share/doc/snotes-1.0
-rw-r--r--    1 root    root                     1089 Feb 11 20:35
/usr/share/doc/snotes-1.0/LICENSE
-rw-r--r--    1 root    root                      773 Feb 11 20:35
/usr/share/doc/snotes-1.0/README
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/snotes-1.0-1.fc19.noarch.rpm | sort |
uniq -c
      1 /bin/sh
      1 dmenu
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 vim-minimal
FIX: Run-require git
TODO: Run-require xterm.

$ rpm -q --provides -p ../RPMS/noarch/snotes-1.0-1.fc19.noarch.rpm | sort |
uniq -c
      1 snotes = 1.0-1.fc19
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/snotes-1.0-1.fc19.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F19
(http://koji.fedoraproject.org/koji/taskinfo?taskID=4969472). Ok.

Otherwise package is in line with Fedora packaging guidelines.

Please correct all `FIX' issues, consider fixing `TODO' items, and provide new
spec file.
Resolution: NOT approved.

[Bug 910835] Review Request: snotes - A flexible and easy to use notes system

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=910835

--- Comment #3 from Petr Šabata  ---
All fixed in r2, see Comment#1.

[Bug 910835] Review Request: snotes - A flexible and easy to use notes system

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=910835

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |
              Flags|                            |fedora-review+

--- Comment #4 from Petr Pisar  ---
Spec file changes:
--- snotes.spec.old     2013-02-13 17:30:40.000000000 +0100
+++ snotes.spec 2013-02-14 09:20:41.000000000 +0100
@@ -1,13 +1,16 @@
 Name:           snotes
 Version:        1.0
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        A flexible and easy to use notes system
 License:        MIT
 URL:            https://github.com/v4hn/%%7Bname%7D
 Source0:        https://github.com/v4hn/%%7Bname%7D/archive/v%%7Bversion%7D.tar.gz
 BuildArch:      noarch
 Requires:       dmenu
+Requires:       git
+# The default editor
 Requires:       vim-minimal
+Requires:       xterm

%description
 %{summary}.
@@ -27,5 +30,8 @@
 %{_bindir}/snotes*

%changelog
+* Thu Feb 14 2013 Petr Šabata  - 1.0-2
+- Add some forgotted runtime dependecies
+
 * Wed Feb 13 2013 Petr Šabata  - 1.0-1
 - Initial package
> FIX: Run-require `git' (snotes:49).

+Requires:       git
Ok.
> TODO: Run-require `xterm'. This the similar to already run-required `vim-minimal' (snotes:30).

+Requires:       xterm
Ok.

$ rpmlint snotes.spec ../SRPMS/snotes-1.0-2.fc19.src.rpm
../RPMS/noarch/snotes-1.0-2.fc19.noarch.rpm 
snotes.noarch: W: no-manual-page-for-binary snotes
snotes.noarch: W: no-manual-page-for-binary snotes-open
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
rpmlint is Ok.

$ rpm -q --requires -p ../RPMS/noarch/snotes-1.0-2.fc19.noarch.rpm | sort |
uniq -c
      1 /bin/sh
      1 dmenu
      1 git
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 vim-minimal
      1 xterm
Binary requires are Ok.

Package builds in F19
(http://koji.fedoraproject.org/koji/taskinfo?taskID=4969543). Ok.

Package is good.
Resolution: Package approved.

[Bug 910835] Review Request: snotes - A flexible and easy to use notes system

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=910835

Petr Šabata  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-cvs?

--- Comment #5 from Petr Šabata  ---
New Package SCM Request
=======================
Package Name: snotes
Short Description: A flexible and easy to use notes system
Owners: psabata
Branches: f17 f18
InitialCC:

[Bug 910835] Review Request: snotes - A flexible and easy to use notes system

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=910835

--- Comment #6 from Jon Ciesla  ---
Git done (by process-git-requests).

[Bug 910835] Review Request: snotes - A flexible and easy to use notes system

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=910835

--- Comment #7 from Petr Šabata  ---
Thank you both.

[Bug 910835] Review Request: snotes - A flexible and easy to use notes system

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=910835

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

[Bug 910835] Review Request: snotes - A flexible and easy to use notes system

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=910835

--- Comment #8 from Fedora Update System  ---
snotes-1.0-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/snotes-1.0-2.fc18

[Bug 910835] Review Request: snotes - A flexible and easy to use notes system

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=910835

--- Comment #9 from Fedora Update System  ---
snotes-1.0-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/snotes-1.0-2.fc17

[Bug 910835] Review Request: snotes - A flexible and easy to use notes system

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=910835

--- Comment #10 from Fedora Update System  ---
snotes-1.0-2.fc17 has been pushed to the Fedora 17 stable repository.

[Bug 910835] Review Request: snotes - A flexible and easy to use notes system

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=910835

--- Comment #11 from Fedora Update System  ---
snotes-1.0-2.fc18 has been pushed to the Fedora 18 stable repository.

[Bug 910835] Review Request: snotes - A flexible and easy to use notes system

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=910835

Petr Šabata  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
   Fixed In Version|                            |snotes-1.0-2.fc18
         Resolution|---                         |CURRENTRELEASE
        Last Closed|                            |2014-04-03 09:37:39