[Bug 1976483] New: Review Request: python-build - A simple, correct PEP517 package builder

https://bugzilla.redhat.com/show_bug.cgi?id=1976483

Bug ID: 1976483
           Summary: Review Request: python-build - A simple, correct
                    PEP517 package builder
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://download.copr.fedorainfracloud.org/results/lbalhar/build/fedora-rawh...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/lbalhar/build/fedora-rawh...
Description: A simple, correct PEP517 package builder
Fedora Account System Username: lbalhar

Note that this review is the second one in the queue for this package, but the
first one seems to be abandoned:
https://bugzilla.redhat.com/show_bug.cgi?id=1910392

[Bug 1976483] Review Request: python-build - A simple, correct PEP517 package builder

https://bugzilla.redhat.com/show_bug.cgi?id=1976483

Lumír Balhar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1893382, 1905174
                 CC|                            |[e-mail]

--- Comment #1 from Lumír Balhar  ---
*** Bug 1910392 has been marked as a duplicate of this bug. ***

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1893382
[Bug 1893382] python-check-manifest-0.46 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1905174
[Bug 1905174] F34FailsToInstall: python3-check-manifest

[Bug 1976483] Review Request: python-build - A simple, correct PEP517 package builder

https://bugzilla.redhat.com/show_bug.cgi?id=1976483

Miro Hrončok  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Miro Hrončok  ---
Spec sanity:

1) Consider using and URL that contains name:

Source0:        %{url}/archive/%{version}/%{pypi_name}-%{version}.tar.gz

It plays much nicer with other tarballs when %_sourcedir is a common location
on packager's machine.

2) %{?python_provide:...} is deprecated and SHOULD NOT be used, see
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_py_pr...

Other than that, looks sane.

[Bug 1976483] Review Request: python-build - A simple, correct PEP517 package builder

https://bugzilla.redhat.com/show_bug.cgi?id=1976483

--- Comment #3 from Miro Hrončok  ---
Oh, one more thing.

3) Please move %generate_buildrequires after %prep, when it happens. It makes
the reader flow follow to the execution flow.

[Bug 1976483] Review Request: python-build - A simple, correct PEP517 package builder

https://bugzilla.redhat.com/show_bug.cgi?id=1976483

--- Comment #4 from Miro Hrončok  ---
I've got a test failures when building via mock:

+ /usr/bin/pytest --ignore
/builddir/build/BUILD/build-0.5.1/.pyproject-builddir -k 'not
test_build_package and not test_build_package_via_sdist'
============================= test session starts
==============================
platform linux -- Python 3.10.0b3, pytest-6.2.4, py-1.10.0, pluggy-0.13.1
rootdir: /builddir/build/BUILD/build-0.5.1, configfile: setup.cfg
plugins: virtualenv-1.7.0, cov-2.11.1, shutil-1.7.0, mock-3.5.1, forked-1.3.0,
xdist-2.3.0, rerunfailures-9.1.1
collected 122 items / 4 deselected / 118 selected
tests/test_env.py ..sF....FFFFFFFF.                                      [ 14%]
tests/test_main.py ....................                                  [ 31%]
tests/test_module.py .                                                   [ 32%]
tests/test_projectbuilder.py ........................................... [ 68%]
......                                                                   [ 73%]
tests/test_integration.py sssssssssssssssssssssssssssssss                [100%]
=================================== FAILURES
===================================
____________________ test_executable_missing_post_creation
_____________________
mocker = <pytest_mock.plugin.MockerFixture object at 0x7f43cd6b3f70>
    @pytest.mark.skipif(IS_PY2, reason='venv module used on Python 3 only')
    @pytest.mark.skipif(IS_PYPY3, reason='PyPy3 uses get path to create and
provision venv')
    def test_executable_missing_post_creation(mocker):
        mocker.patch.object(build.env, 'virtualenv', None)
        original_get_paths = sysconfig.get_paths

def _get_paths(vars):  # noqa
            shutil.rmtree(vars['base'])
            return original_get_paths(vars=vars)

get_paths = mocker.patch('sysconfig.get_paths', side_effect=_get_paths)
        with pytest.raises(RuntimeError, match='Virtual environment creation
failed, executable .* missing'):
>       with build.env.IsolatedEnvBuilder():

tests/test_env.py:77: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
../../BUILDROOT/python-build-0.5.1-1.fc35.x86_64/usr/lib/python3.10/site-packages/build/env.py:90:
in __enter__
    executable, scripts_dir = _create_isolated_env_virtualenv(self._path)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
path = '/tmp/build-env-nrfb_6k7'
    def _create_isolated_env_virtualenv(path):  # type: (str) -> Tuple[str,
str]
        """
        On Python 2 we use the virtualenv package to provision a virtual
environment.

:param path: The path where to create the isolated build environment
        :return: The Python executable and script folder
        """
        cmd = [str(path), '--no-setuptools', '--no-wheel', '--activators', '']
>   result = virtualenv.cli_run(cmd, setup_logging=False)

E       AttributeError: 'NoneType' object has no attribute 'cli_run'
../../BUILDROOT/python-build-0.5.1-1.fc35.x86_64/usr/lib/python3.10/site-packages/build/env.py:182:
AttributeError
_______________ test_pip_needs_upgrade_mac_os_11[x86_64-20.2.0]
________________
mocker = <pytest_mock.plugin.MockerFixture object at 0x7f43cd6b05e0>
pip_version = '20.2.0', arch = 'x86_64'
    @pytest.mark.isolated
    @pytest.mark.parametrize('pip_version', ['20.2.0', '20.3.0', '21.0.0',
'21.0.1'])
    @pytest.mark.parametrize('arch', ['x86_64', 'arm64'])
    @pytest.mark.skipif(IS_PY35, reason="Python 3.5 does not run on macOS 11,
and pip can't upgrade to 21 there")
    @pytest.mark.skipif(IS_PY2, reason='venv module used on Python 3 only')
    def test_pip_needs_upgrade_mac_os_11(mocker, pip_version, arch):
        SimpleNamespace = collections.namedtuple('SimpleNamespace', 'version')

check_call = mocker.patch('subprocess.check_call')
        mocker.patch('platform.system', return_value='Darwin')
        mocker.patch('platform.machine', return_value=arch)
        mocker.patch('platform.mac_ver', return_value=('11.0', ('', '', ''),
''))
        mocker.patch('build.env.metadata.distributions',
return_value=(SimpleNamespace(version=pip_version),))
        mocker.patch.object(build.env, 'virtualenv', None)  # hide virtualenv

min_version = Version('20.3' if arch == 'x86_64' else '21.0.1')
>   with build.env.IsolatedEnvBuilder():

tests/test_env.py:131: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
../../BUILDROOT/python-build-0.5.1-1.fc35.x86_64/usr/lib/python3.10/site-packages/build/env.py:90:
in __enter__
    executable, scripts_dir = _create_isolated_env_virtualenv(self._path)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
path = '/tmp/build-env-ksdtb14z'
    def _create_isolated_env_virtualenv(path):  # type: (str) -> Tuple[str,
str]
        """
        On Python 2 we use the virtualenv package to provision a virtual
environment.

:param path: The path where to create the isolated build environment
        :return: The Python executable and script folder
        """
        cmd = [str(path), '--no-setuptools', '--no-wheel', '--activators', '']
>   result = virtualenv.cli_run(cmd, setup_logging=False)

E       AttributeError: 'NoneType' object has no attribute 'cli_run'
../../BUILDROOT/python-build-0.5.1-1.fc35.x86_64/usr/lib/python3.10/site-packages/build/env.py:182:
AttributeError
_______________ test_pip_needs_upgrade_mac_os_11[x86_64-20.3.0]
________________
mocker = <pytest_mock.plugin.MockerFixture object at 0x7f43cd6b37c0>
pip_version = '20.3.0', arch = 'x86_64'
    @pytest.mark.isolated
    @pytest.mark.parametrize('pip_version', ['20.2.0', '20.3.0', '21.0.0',
'21.0.1'])
    @pytest.mark.parametrize('arch', ['x86_64', 'arm64'])
    @pytest.mark.skipif(IS_PY35, reason="Python 3.5 does not run on macOS 11,
and pip can't upgrade to 21 there")
    @pytest.mark.skipif(IS_PY2, reason='venv module used on Python 3 only')
    def test_pip_needs_upgrade_mac_os_11(mocker, pip_version, arch):
        SimpleNamespace = collections.namedtuple('SimpleNamespace', 'version')

check_call = mocker.patch('subprocess.check_call')
        mocker.patch('platform.system', return_value='Darwin')
        mocker.patch('platform.machine', return_value=arch)
        mocker.patch('platform.mac_ver', return_value=('11.0', ('', '', ''),
''))
        mocker.patch('build.env.metadata.distributions',
return_value=(SimpleNamespace(version=pip_version),))
        mocker.patch.object(build.env, 'virtualenv', None)  # hide virtualenv

min_version = Version('20.3' if arch == 'x86_64' else '21.0.1')
>   with build.env.IsolatedEnvBuilder():

tests/test_env.py:131: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
../../BUILDROOT/python-build-0.5.1-1.fc35.x86_64/usr/lib/python3.10/site-packages/build/env.py:90:
in __enter__
    executable, scripts_dir = _create_isolated_env_virtualenv(self._path)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
path = '/tmp/build-env-so8ov877'
    def _create_isolated_env_virtualenv(path):  # type: (str) -> Tuple[str,
str]
        """
        On Python 2 we use the virtualenv package to provision a virtual
environment.

:param path: The path where to create the isolated build environment
        :return: The Python executable and script folder
        """
        cmd = [str(path), '--no-setuptools', '--no-wheel', '--activators', '']
>   result = virtualenv.cli_run(cmd, setup_logging=False)

E       AttributeError: 'NoneType' object has no attribute 'cli_run'
../../BUILDROOT/python-build-0.5.1-1.fc35.x86_64/usr/lib/python3.10/site-packages/build/env.py:182:
AttributeError
_______________ test_pip_needs_upgrade_mac_os_11[x86_64-21.0.0]
________________
mocker = <pytest_mock.plugin.MockerFixture object at 0x7f43cd6b0190>
pip_version = '21.0.0', arch = 'x86_64'
    @pytest.mark.isolated
    @pytest.mark.parametrize('pip_version', ['20.2.0', '20.3.0', '21.0.0',
'21.0.1'])
    @pytest.mark.parametrize('arch', ['x86_64', 'arm64'])
    @pytest.mark.skipif(IS_PY35, reason="Python 3.5 does not run on macOS 11,
and pip can't upgrade to 21 there")
    @pytest.mark.skipif(IS_PY2, reason='venv module used on Python 3 only')
    def test_pip_needs_upgrade_mac_os_11(mocker, pip_version, arch):
        SimpleNamespace = collections.namedtuple('SimpleNamespace', 'version')

check_call = mocker.patch('subprocess.check_call')
        mocker.patch('platform.system', return_value='Darwin')
        mocker.patch('platform.machine', return_value=arch)
        mocker.patch('platform.mac_ver', return_value=('11.0', ('', '', ''),
''))
        mocker.patch('build.env.metadata.distributions',
return_value=(SimpleNamespace(version=pip_version),))
        mocker.patch.object(build.env, 'virtualenv', None)  # hide virtualenv

min_version = Version('20.3' if arch == 'x86_64' else '21.0.1')
>   with build.env.IsolatedEnvBuilder():

tests/test_env.py:131: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
../../BUILDROOT/python-build-0.5.1-1.fc35.x86_64/usr/lib/python3.10/site-packages/build/env.py:90:
in __enter__
    executable, scripts_dir = _create_isolated_env_virtualenv(self._path)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
path = '/tmp/build-env-voitzirj'
    def _create_isolated_env_virtualenv(path):  # type: (str) -> Tuple[str,
str]
        """
        On Python 2 we use the virtualenv package to provision a virtual
environment.

:param path: The path where to create the isolated build environment
        :return: The Python executable and script folder
        """
        cmd = [str(path), '--no-setuptools', '--no-wheel', '--activators', '']
>   result = virtualenv.cli_run(cmd, setup_logging=False)

E       AttributeError: 'NoneType' object has no attribute 'cli_run'
../../BUILDROOT/python-build-0.5.1-1.fc35.x86_64/usr/lib/python3.10/site-packages/build/env.py:182:
AttributeError
_______________ test_pip_needs_upgrade_mac_os_11[x86_64-21.0.1]
________________
mocker = <pytest_mock.plugin.MockerFixture object at 0x7f43cd6b1300>
pip_version = '21.0.1', arch = 'x86_64'
    @pytest.mark.isolated
    @pytest.mark.parametrize('pip_version', ['20.2.0', '20.3.0', '21.0.0',
'21.0.1'])
    @pytest.mark.parametrize('arch', ['x86_64', 'arm64'])
    @pytest.mark.skipif(IS_PY35, reason="Python 3.5 does not run on macOS 11,
and pip can't upgrade to 21 there")
    @pytest.mark.skipif(IS_PY2, reason='venv module used on Python 3 only')
    def test_pip_needs_upgrade_mac_os_11(mocker, pip_version, arch):
        SimpleNamespace = collections.namedtuple('SimpleNamespace', 'version')

check_call = mocker.patch('subprocess.check_call')
        mocker.patch('platform.system', return_value='Darwin')
        mocker.patch('platform.machine', return_value=arch)
        mocker.patch('platform.mac_ver', return_value=('11.0', ('', '', ''),
''))
        mocker.patch('build.env.metadata.distributions',
return_value=(SimpleNamespace(version=pip_version),))
        mocker.patch.object(build.env, 'virtualenv', None)  # hide virtualenv

min_version = Version('20.3' if arch == 'x86_64' else '21.0.1')
>   with build.env.IsolatedEnvBuilder():

tests/test_env.py:131: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
../../BUILDROOT/python-build-0.5.1-1.fc35.x86_64/usr/lib/python3.10/site-packages/build/env.py:90:
in __enter__
    executable, scripts_dir = _create_isolated_env_virtualenv(self._path)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
path = '/tmp/build-env-umq4hssy'
    def _create_isolated_env_virtualenv(path):  # type: (str) -> Tuple[str,
str]
        """
        On Python 2 we use the virtualenv package to provision a virtual
environment.

:param path: The path where to create the isolated build environment
        :return: The Python executable and script folder
        """
        cmd = [str(path), '--no-setuptools', '--no-wheel', '--activators', '']
>   result = virtualenv.cli_run(cmd, setup_logging=False)

E       AttributeError: 'NoneType' object has no attribute 'cli_run'
../../BUILDROOT/python-build-0.5.1-1.fc35.x86_64/usr/lib/python3.10/site-packages/build/env.py:182:
AttributeError
________________ test_pip_needs_upgrade_mac_os_11[arm64-20.2.0]
________________
mocker = <pytest_mock.plugin.MockerFixture object at 0x7f43cd3a9270>
pip_version = '20.2.0', arch = 'arm64'
    @pytest.mark.isolated
    @pytest.mark.parametrize('pip_version', ['20.2.0', '20.3.0', '21.0.0',
'21.0.1'])
    @pytest.mark.parametrize('arch', ['x86_64', 'arm64'])
    @pytest.mark.skipif(IS_PY35, reason="Python 3.5 does not run on macOS 11,
and pip can't upgrade to 21 there")
    @pytest.mark.skipif(IS_PY2, reason='venv module used on Python 3 only')
    def test_pip_needs_upgrade_mac_os_11(mocker, pip_version, arch):
        SimpleNamespace = collections.namedtuple('SimpleNamespace', 'version')

check_call = mocker.patch('subprocess.check_call')
        mocker.patch('platform.system', return_value='Darwin')
        mocker.patch('platform.machine', return_value=arch)
        mocker.patch('platform.mac_ver', return_value=('11.0', ('', '', ''),
''))
        mocker.patch('build.env.metadata.distributions',
return_value=(SimpleNamespace(version=pip_version),))
        mocker.patch.object(build.env, 'virtualenv', None)  # hide virtualenv

min_version = Version('20.3' if arch == 'x86_64' else '21.0.1')
>   with build.env.IsolatedEnvBuilder():

tests/test_env.py:131: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
../../BUILDROOT/python-build-0.5.1-1.fc35.x86_64/usr/lib/python3.10/site-packages/build/env.py:90:
in __enter__
    executable, scripts_dir = _create_isolated_env_virtualenv(self._path)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
path = '/tmp/build-env-qhk2e47u'
    def _create_isolated_env_virtualenv(path):  # type: (str) -> Tuple[str,
str]
        """
        On Python 2 we use the virtualenv package to provision a virtual
environment.

:param path: The path where to create the isolated build environment
        :return: The Python executable and script folder
        """
        cmd = [str(path), '--no-setuptools', '--no-wheel', '--activators', '']
>   result = virtualenv.cli_run(cmd, setup_logging=False)

E       AttributeError: 'NoneType' object has no attribute 'cli_run'
../../BUILDROOT/python-build-0.5.1-1.fc35.x86_64/usr/lib/python3.10/site-packages/build/env.py:182:
AttributeError
________________ test_pip_needs_upgrade_mac_os_11[arm64-20.3.0]
________________
mocker = <pytest_mock.plugin.MockerFixture object at 0x7f43cc24bf70>
pip_version = '20.3.0', arch = 'arm64'
    @pytest.mark.isolated
    @pytest.mark.parametrize('pip_version', ['20.2.0', '20.3.0', '21.0.0',
'21.0.1'])
    @pytest.mark.parametrize('arch', ['x86_64', 'arm64'])
    @pytest.mark.skipif(IS_PY35, reason="Python 3.5 does not run on macOS 11,
and pip can't upgrade to 21 there")
    @pytest.mark.skipif(IS_PY2, reason='venv module used on Python 3 only')
    def test_pip_needs_upgrade_mac_os_11(mocker, pip_version, arch):
        SimpleNamespace = collections.namedtuple('SimpleNamespace', 'version')

check_call = mocker.patch('subprocess.check_call')
        mocker.patch('platform.system', return_value='Darwin')
        mocker.patch('platform.machine', return_value=arch)
        mocker.patch('platform.mac_ver', return_value=('11.0', ('', '', ''),
''))
        mocker.patch('build.env.metadata.distributions',
return_value=(SimpleNamespace(version=pip_version),))
        mocker.patch.object(build.env, 'virtualenv', None)  # hide virtualenv

min_version = Version('20.3' if arch == 'x86_64' else '21.0.1')
>   with build.env.IsolatedEnvBuilder():

tests/test_env.py:131: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
../../BUILDROOT/python-build-0.5.1-1.fc35.x86_64/usr/lib/python3.10/site-packages/build/env.py:90:
in __enter__
    executable, scripts_dir = _create_isolated_env_virtualenv(self._path)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
path = '/tmp/build-env-3k5qr79b'
    def _create_isolated_env_virtualenv(path):  # type: (str) -> Tuple[str,
str]
        """
        On Python 2 we use the virtualenv package to provision a virtual
environment.

:param path: The path where to create the isolated build environment
        :return: The Python executable and script folder
        """
        cmd = [str(path), '--no-setuptools', '--no-wheel', '--activators', '']
>   result = virtualenv.cli_run(cmd, setup_logging=False)

E       AttributeError: 'NoneType' object has no attribute 'cli_run'
../../BUILDROOT/python-build-0.5.1-1.fc35.x86_64/usr/lib/python3.10/site-packages/build/env.py:182:
AttributeError
________________ test_pip_needs_upgrade_mac_os_11[arm64-21.0.0]
________________
mocker = <pytest_mock.plugin.MockerFixture object at 0x7f43cc24bee0>
pip_version = '21.0.0', arch = 'arm64'
    @pytest.mark.isolated
    @pytest.mark.parametrize('pip_version', ['20.2.0', '20.3.0', '21.0.0',
'21.0.1'])
    @pytest.mark.parametrize('arch', ['x86_64', 'arm64'])
    @pytest.mark.skipif(IS_PY35, reason="Python 3.5 does not run on macOS 11,
and pip can't upgrade to 21 there")
    @pytest.mark.skipif(IS_PY2, reason='venv module used on Python 3 only')
    def test_pip_needs_upgrade_mac_os_11(mocker, pip_version, arch):
        SimpleNamespace = collections.namedtuple('SimpleNamespace', 'version')

check_call = mocker.patch('subprocess.check_call')
        mocker.patch('platform.system', return_value='Darwin')
        mocker.patch('platform.machine', return_value=arch)
        mocker.patch('platform.mac_ver', return_value=('11.0', ('', '', ''),
''))
        mocker.patch('build.env.metadata.distributions',
return_value=(SimpleNamespace(version=pip_version),))
        mocker.patch.object(build.env, 'virtualenv', None)  # hide virtualenv

min_version = Version('20.3' if arch == 'x86_64' else '21.0.1')
>   with build.env.IsolatedEnvBuilder():

tests/test_env.py:131: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
../../BUILDROOT/python-build-0.5.1-1.fc35.x86_64/usr/lib/python3.10/site-packages/build/env.py:90:
in __enter__
    executable, scripts_dir = _create_isolated_env_virtualenv(self._path)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
path = '/tmp/build-env-cxh_gynv'
    def _create_isolated_env_virtualenv(path):  # type: (str) -> Tuple[str,
str]
        """
        On Python 2 we use the virtualenv package to provision a virtual
environment.

:param path: The path where to create the isolated build environment
        :return: The Python executable and script folder
        """
        cmd = [str(path), '--no-setuptools', '--no-wheel', '--activators', '']
>   result = virtualenv.cli_run(cmd, setup_logging=False)

E       AttributeError: 'NoneType' object has no attribute 'cli_run'
../../BUILDROOT/python-build-0.5.1-1.fc35.x86_64/usr/lib/python3.10/site-packages/build/env.py:182:
AttributeError
________________ test_pip_needs_upgrade_mac_os_11[arm64-21.0.1]
________________
mocker = <pytest_mock.plugin.MockerFixture object at 0x7f43cd4caef0>
pip_version = '21.0.1', arch = 'arm64'
    @pytest.mark.isolated
    @pytest.mark.parametrize('pip_version', ['20.2.0', '20.3.0', '21.0.0',
'21.0.1'])
    @pytest.mark.parametrize('arch', ['x86_64', 'arm64'])
    @pytest.mark.skipif(IS_PY35, reason="Python 3.5 does not run on macOS 11,
and pip can't upgrade to 21 there")
    @pytest.mark.skipif(IS_PY2, reason='venv module used on Python 3 only')
    def test_pip_needs_upgrade_mac_os_11(mocker, pip_version, arch):
        SimpleNamespace = collections.namedtuple('SimpleNamespace', 'version')

check_call = mocker.patch('subprocess.check_call')
        mocker.patch('platform.system', return_value='Darwin')
        mocker.patch('platform.machine', return_value=arch)
        mocker.patch('platform.mac_ver', return_value=('11.0', ('', '', ''),
''))
        mocker.patch('build.env.metadata.distributions',
return_value=(SimpleNamespace(version=pip_version),))
        mocker.patch.object(build.env, 'virtualenv', None)  # hide virtualenv

min_version = Version('20.3' if arch == 'x86_64' else '21.0.1')
>   with build.env.IsolatedEnvBuilder():

tests/test_env.py:131: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
../../BUILDROOT/python-build-0.5.1-1.fc35.x86_64/usr/lib/python3.10/site-packages/build/env.py:90:
in __enter__
    executable, scripts_dir = _create_isolated_env_virtualenv(self._path)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
path = '/tmp/build-env-tjll4j18'
    def _create_isolated_env_virtualenv(path):  # type: (str) -> Tuple[str,
str]
        """
        On Python 2 we use the virtualenv package to provision a virtual
environment.

:param path: The path where to create the isolated build environment
        :return: The Python executable and script folder
        """
        cmd = [str(path), '--no-setuptools', '--no-wheel', '--activators', '']
>   result = virtualenv.cli_run(cmd, setup_logging=False)

E       AttributeError: 'NoneType' object has no attribute 'cli_run'
../../BUILDROOT/python-build-0.5.1-1.fc35.x86_64/usr/lib/python3.10/site-packages/build/env.py:182:
AttributeError
=============================== warnings summary
===============================
tests/test_env.py::test_isolation
tests/test_env.py::test_isolation
tests/test_env.py::test_isolation
tests/test_env.py::test_isolation
tests/test_env.py::test_isolated_environment_install
tests/test_env.py::test_default_pip_is_never_too_old
tests/test_main.py::test_build_isolated
tests/test_main.py::test_build_raises_build_exception
tests/test_main.py::test_build_raises_build_backend_exception
  /usr/lib/python3.10/site-packages/virtualenv/run/plugin/base.py:18:
DeprecationWarning: SelectableGroups dict interface is deprecated. Use select.
    return OrderedDict((e.name, e.load()) for e in cls.entry_points().get(key,
{}))
-- Docs: https://docs.pytest.org/en/stable/warnings.html
=========================== short test summary info
============================
FAILED tests/test_env.py::test_executable_missing_post_creation -
AttributeEr...
FAILED tests/test_env.py::test_pip_needs_upgrade_mac_os_11[x86_64-20.2.0] -
A...
FAILED tests/test_env.py::test_pip_needs_upgrade_mac_os_11[x86_64-20.3.0] -
A...
FAILED tests/test_env.py::test_pip_needs_upgrade_mac_os_11[x86_64-21.0.0] -
A...
FAILED tests/test_env.py::test_pip_needs_upgrade_mac_os_11[x86_64-21.0.1] -
A...
FAILED tests/test_env.py::test_pip_needs_upgrade_mac_os_11[arm64-20.2.0] -
At...
FAILED tests/test_env.py::test_pip_needs_upgrade_mac_os_11[arm64-20.3.0] -
At...
FAILED tests/test_env.py::test_pip_needs_upgrade_mac_os_11[arm64-21.0.0] -
At...
FAILED tests/test_env.py::test_pip_needs_upgrade_mac_os_11[arm64-21.0.1] -
At...
====== 9 failed, 77 passed, 32 skipped, 4 deselected, 9 warnings in 4.78s
======

[Bug 1976483] Review Request: python-build - A simple, correct PEP517 package builder

https://bugzilla.redhat.com/show_bug.cgi?id=1976483

--- Comment #5 from Miro Hrončok  ---
I was checking what happened that your copr build passed and my mock build did
not. Apparently, I had some extra packages installed in mock from the
jupyter-packaging revew, Fedora-Review did not clean that mock and it made the
build fail like this :( Weird as it is, it passed now when I cleaned my mock,
sorry for the noise.

[Bug 1976483] Review Request: python-build - A simple, correct PEP517 package builder

https://bugzilla.redhat.com/show_bug.cgi?id=1976483

Miro Hrončok  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review+

--- Comment #6 from Miro Hrončok  ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

Please fix 1-2-3 above and consider the package pre-APPROVED.

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* Expat License".
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines (except %python_provide)
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[!]: Package meets the Packaging Guidelines::Python: SHOULD NOT use
%python_provide
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[?]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint
-------
Checking: python3-build-0.5.1-1.fc35.noarch.rpm
          python-build-0.5.1-1.fc35.src.rpm
python3-build.noarch: W: no-manual-page-for-binary pyproject-build
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

Rpmlint (installed packages): Cannot parse rpmlint output, rpmlint 2 :/

Source checksums
----------------
https://github.com/pypa/build/archive/refs/tags/0.5.1.tar.gz :
  CHECKSUM(SHA256) this package     :
e7916828e59258040bbf79dad37710e8896791f7c125b1a8ba6cb3ae9cb18cbb
  CHECKSUM(SHA256) upstream package :
e7916828e59258040bbf79dad37710e8896791f7c125b1a8ba6cb3ae9cb18cbb

Requires
--------
python3-build (rpmlib, GLIBC filtered):
    /usr/bin/python3
    python(abi)
    python3.10dist(packaging)
    python3.10dist(pep517)
    python3.10dist(toml)

Provides
--------
python3-build:
    python-build
    python3-build
    python3.10-build
    python3.10dist(build)
    python3dist(build)

Generated by fedora-review 0.7.0 (fed5495) last change: 2019-03-17
Command line :try-fedora-review -b 1976483 -m fedora-rawhide-x86_64
--mock-options=--enablerepo=local
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Shell-api, Generic
Disabled plugins: Haskell, SugarActivity, Ocaml, fonts, C/C++, PHP, Perl, R,
Ruby, Java
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

[Bug 1976483] Review Request: python-build - A simple, correct PEP517 package builder

https://bugzilla.redhat.com/show_bug.cgi?id=1976483

--- Comment #7 from Tomas Hrcka  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-build

[Bug 1976483] Review Request: python-build - A simple, correct PEP517 package builder

https://bugzilla.redhat.com/show_bug.cgi?id=1976483

Lumír Balhar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2021-06-29 05:54:43

--- Comment #8 from Lumír Balhar  ---
https://bodhi.fedoraproject.org/updates/FEDORA-2021-48ea493a32