[Bug 2276190] New: Review Request: golang-github-ergochat-readline - A readline implementation in pure Go
https://bugzilla.redhat.com/show_bug.cgi?id=2276190
Bug ID: 2276190 Summary: Review Request: golang-github-ergochat-readline - A readline implementation in pure Go Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mikel@olasagasti.info QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-ergochat-readline.spe... SRPM URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-ergochat-readline-0.1... Description: A readline implementation in pure Go. Fedora Account System Username: mikelo2
https://bugzilla.redhat.com/show_bug.cgi?id=2276190
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2157305 Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2157305 [Bug 2157305] gopass-1.15.13 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2276190
Tadej Janež tadej.j@nez.si changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ CC| |tadej.j@nez.si
--- Comment #1 from Tadej Janež tadej.j@nez.si --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gocode/src/github.com(golang-github-mr-tron-base58-devel, golang-github-azure-sdk-storage-azblob-devel, < ... trimmed ... >, golang-github-nvidia-nvml-devel, golang-github-git-lfs-3-devel)
The above note is expected. [-]: %build honors applicable compiler flags or justifies otherwise. N/A for a source package. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 16731 bytes in 8 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-}: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: golang-github-ergochat-readline-devel-0.1.0-1.fc41.noarch.rpm golang-github-ergochat-readline-0.1.0-1.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp1wmlgjuo')] checks: 32, packages: 2
golang-github-ergochat-readline.spec: W: no-%build-section golang-github-ergochat-readline-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/ergochat/readline/.goipath 2 packages and 0 specfiles checked; 0 errors, 2 warnings, 7 filtered, 0 badness; has taken 0.3 s
Both warnings are spurious and I think you should create a .rpmlintrc file and add appropriate filters to filter out the above.
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1
golang-github-ergochat-readline-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/ergochat/readline/.goipath 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 3 filtered, 0 badness; has taken 0.1 s
Source checksums ---------------- https://github.com/ergochat/readline/archive/v0.1.0/readline-0.1.0.tar.gz : CHECKSUM(SHA256) this package : f12ebfed47b81bdf313909daefa661e623e5ed38f6985fbbab98d58ea55743c5 CHECKSUM(SHA256) upstream package : f12ebfed47b81bdf313909daefa661e623e5ed38f6985fbbab98d58ea55743c5
Requires -------- golang-github-ergochat-readline-devel (rpmlib, GLIBC filtered): go-filesystem golang(golang.org/x/sys/unix) golang(golang.org/x/text/width)
Provides -------- golang-github-ergochat-readline-devel: golang(github.com/ergochat/readline) golang(github.com/ergochat/readline/internal/ansi) golang(github.com/ergochat/readline/internal/platform) golang(github.com/ergochat/readline/internal/ringbuf) golang(github.com/ergochat/readline/internal/runes) golang(github.com/ergochat/readline/internal/term) golang-github-ergochat-readline-devel golang-ipath(github.com/ergochat/readline)
https://bugzilla.redhat.com/show_bug.cgi?id=2276190
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |mikel@olasagasti.info
https://bugzilla.redhat.com/show_bug.cgi?id=2276190
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|mikel@olasagasti.info |tadej.j@nez.si
https://bugzilla.redhat.com/show_bug.cgi?id=2276190
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST
--- Comment #2 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-ergochat-readline
https://bugzilla.redhat.com/show_bug.cgi?id=2276190
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #3 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-25c27fe074 (golang-github-ergochat-readline-0.1.2-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-25c27fe074
https://bugzilla.redhat.com/show_bug.cgi?id=2276190
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2024-07-09 09:02:31
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-25c27fe074 (golang-github-ergochat-readline-0.1.2-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com