https://bugzilla.redhat.com/show_bug.cgi?id=1977534
Bug ID: 1977534 Summary: Review Request: python-keep - A Meta CLI toolkit Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: michel@michel-slm.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://salimma.fedorapeople.org/specs/python/python-keep.spec SRPM URL: https://salimma.fedorapeople.org/specs/python/python-keep-2.10.1-1.fc33.src.... Description: Personal shell command keeper and snippets manager
- Save a new command with a brief description - Search the saved commands using powerful patterns - Save the commands as a secret GitHub gist - Use `keep push` and `keep pull` to sync the commands between GitHub gist and other computers.
**ProTip : Save the commands you usually forget in ssh sessions and sync it with your local machine.**
Fedora Account System Username: salimma
https://bugzilla.redhat.com/show_bug.cgi?id=1977534
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1977535
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1977535 [Bug 1977535] Review Request: python-howdoi - Instant coding answers via the command line
https://bugzilla.redhat.com/show_bug.cgi?id=1977534
Davide Cavalca dcavalca@fb.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dcavalca@fb.com Assignee|nobody@fedoraproject.org |dcavalca@fb.com Doc Type|--- |If docs needed, set a value Flags| |fedora-review?
--- Comment #1 from Davide Cavalca dcavalca@fb.com --- Taking this review
https://bugzilla.redhat.com/show_bug.cgi?id=1977534
--- Comment #2 from Davide Cavalca dcavalca@fb.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License". 29 files have unknown license. Detailed output of licensecheck in /tmp/1977534-python- keep/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python3-keep-2.10.1-1.fc35.noarch.rpm python-keep-2.10.1-1.fc35.src.rpm python3-keep.noarch: W: no-manual-page-for-binary keep 2 packages and 0 specfiles checked; 0 errors, 1 warnings.
Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output:
Source checksums ---------------- https://github.com/orkohunter/keep/archive/2.10.1/keep-2.10.1.tar.gz : CHECKSUM(SHA256) this package : 76a4b52c0b68303615d83f1624f0288dd01dd1c4abc46a842dce1cbc7e3ddefb CHECKSUM(SHA256) upstream package : 76a4b52c0b68303615d83f1624f0288dd01dd1c4abc46a842dce1cbc7e3ddefb
Requires -------- python3-keep (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3.10dist(click) python3.10dist(pygithub) python3.10dist(requests) python3.10dist(terminaltables)
Provides -------- python3-keep: python-keep python3-keep python3.10-keep python3.10dist(keep) python3dist(keep)
Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1977534 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Python, Generic Disabled plugins: Ocaml, R, Perl, Java, PHP, C/C++, Haskell, SugarActivity, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=1977534
Davide Cavalca dcavalca@fb.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Davide Cavalca dcavalca@fb.com --- Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1977534
Davide Cavalca dcavalca@fb.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST
https://bugzilla.redhat.com/show_bug.cgi?id=1977534
--- Comment #4 from Michel Alexandre Salim michel@michel-slm.name --- Thanks, repo requested https://pagure.io/releng/fedora-scm-requests/issue/35408
https://bugzilla.redhat.com/show_bug.cgi?id=1977534
--- Comment #5 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-keep
https://bugzilla.redhat.com/show_bug.cgi?id=1977534
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-84a5d956c1 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-84a5d956c1
https://bugzilla.redhat.com/show_bug.cgi?id=1977534
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-535d01eecb has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-535d01eecb
https://bugzilla.redhat.com/show_bug.cgi?id=1977534
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-84a5d956c1 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-84a5d956c1 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-84a5d956c1
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1977534
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-535d01eecb has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-535d01eecb *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-535d01eecb
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1977534
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2021-07-10 00:48:46
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-535d01eecb has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1977534
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-84a5d956c1 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com