[Bug 545004] New: Review Request: wqy-microhei-fonts - compact Chinese font

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: wqy-microhei-fonts - compact Chinese font

https://bugzilla.redhat.com/show_bug.cgi?id=545004

Summary: Review Request: wqy-microhei-fonts - compact Chinese
                    font
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---

Spec URL:
http://petersen.fedorapeople.org/wqy-microhei-fonts/wqy-microhei-fonts.spec
SRPM URL:
http://petersen.fedorapeople.org/wqy-microhei-fonts/wqy-microhei-fonts-0.2.0...
Description: Compact Chinese font derived from Droid Fallback

[Bug 545004] Review Request: wqy-microhei-fonts - compact Chinese font

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=545004

--- Comment #1 from Qianqian Fang   2009-12-08 09:33:36 EDT ---
the spec file looks fine. Only two comments:

1. in the description, you may want to say "Compact Chinese/CJK font derived
from Droid font family", as it contains the Latin glyphs (with hinting/kerning)
from Droid Sans and Droid Sans Mono.

2. You may want to add the AUTHORS.txt file to the %doc record.

I plan to add a fontconfig file in the next release. I guess when that comes,
you just define a new fontconf variable and adjust SOURCE1 accordingly.

[Bug 545004] Review Request: wqy-microhei-fonts - compact Chinese font

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=545004

Peng Huang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Peng Huang  2010-02-01 02:49:08 EST ---
rpmlint is NOT silent for SRPM and for RPM

[phuang@phuang-notebook wqy]$ rpmlint
wqy-microhei-fonts-0.2.0-0.1.beta.fc12.src.rpm
wqy-microhei-fonts.src: E: no-description-tag
wqy-microhei-fonts.src: W: strange-permission wqy-microhei-0.2.0-beta.tar.gz
0600
wqy-microhei-fonts.src: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab:
line 6)
1 packages and 0 specfiles checked; 1 errors, 2 warnings.

[phuang@phuang-notebook noarch]$ rpmlint
wqy-microhei-fonts-0.2.0-0.1.beta.f12.noarch.rpm
wqy-microhei-fonts.noarch: E: no-description-tag
wqy-microhei-fonts.noarch: W: incoherent-version-in-changelog 0.2.0-0.1.beta
['0.2.0-0.1.beta.f12', '0.2.0-0.1.beta.f12']
wqy-microhei-fonts.noarch: W: file-not-utf8
/usr/share/doc/wqy-microhei-fonts-0.2.0/README.txt
1 packages and 0 specfiles checked; 1 errors, 2 warnings.

[Bug 545004] Review Request: wqy-microhei-fonts - compact Chinese font

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=545004

--- Comment #3 from Jens Petersen  2010-02-02 02:28:09 EST ---
(In reply to comment #1)
> in the description, you may want to say "Compact Chinese/CJK font derived
>
> from Droid font family", as it contains the Latin glyphs (with hinting/kerning)
> from Droid Sans and Droid Sans Mono.

Oops thanks, adding some description.
> You may want to add the AUTHORS.txt file to the %doc record.

Hmm, I skipped it intentionally since it is 356kB:
if there was a short summary would be happy to include it.

(In reply to comment #2)
> wqy-microhei-fonts.src: E: no-description-tag

see above
> wqy-microhei-fonts.src: W: strange-permission wqy-microhei-0.2.0-beta.tar.gz
> 0600

chromium bug ;)
> wqy-microhei-fonts.src: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab:
> line 6)

fixing
> wqy-microhei-fonts.noarch: W: incoherent-version-in-changelog 0.2.0-0.1.beta
> ['0.2.0-0.1.beta.f12', '0.2.0-0.1.beta.f12']

I think this can be waved.
> wqy-microhei-fonts.noarch: W: file-not-utf8
> /usr/share/doc/wqy-microhei-fonts-0.2.0/README.txt

Qianqian: would be nice if you could fix this upstream.

I'll convert to utf-8.

Spec URL:
http://petersen.fedorapeople.org/wqy-microhei-fonts/wqy-microhei-fonts.spec
SRPM URL:
http://petersen.fedorapeople.org/wqy-microhei-fonts/wqy-microhei-fonts-0.2.0...

[Bug 545004] Review Request: wqy-microhei-fonts - compact Chinese font

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=545004

--- Comment #4 from Peng Huang  2010-02-02 02:53:15 EST ---
+ package builds in mock (rawhide noarch).
http://koji.fedoraproject.org/koji/taskinfo?taskID=1958256
+ rpmlint is NOT silent for SRPM and for RPM.
wqy-microhei-fonts.noarch: W: incoherent-version-in-changelog 0.2.0-0.1.beta
['0.2.0-0.2.beta.f12', '0.2.0-0.2.beta.f12']
It is OK.

+ source files match upstream url
a124c5c6606f4f3b733d3477380e9d2f  wqy-microhei-0.2.0-beta.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ update-gtk-immodules scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Desktop files installed correctly.
+ Package
* Provides:
config(wqy-microhei-fonts) = 0.2.0-0.2.beta.f12
font(:lang=aa)  
font(:lang=ab)  
font(:lang=af)  
font(:lang=an)  
font(:lang=ast)  
font(:lang=av)  
font(:lang=ay)  
font(:lang=ba)  
font(:lang=be)  
font(:lang=bg)  
font(:lang=bi)  
font(:lang=bin)  
font(:lang=br)  
font(:lang=bs)  
font(:lang=bua)  
font(:lang=ca)  
font(:lang=ce)  
font(:lang=ch)  
font(:lang=chm)  
font(:lang=co)  
font(:lang=crh)  
font(:lang=cs)  
font(:lang=csb)  
font(:lang=cu)  
font(:lang=cv)  
font(:lang=cy)  
font(:lang=da)  
font(:lang=de)  
font(:lang=el)  
font(:lang=en)  
font(:lang=eo)  
font(:lang=es)  
font(:lang=et)  
font(:lang=eu)  
font(:lang=fi)  
font(:lang=fil)  
font(:lang=fj)  
font(:lang=fo)  
font(:lang=fr)  
font(:lang=fur)  
font(:lang=fy)  
font(:lang=gd)  
font(:lang=gl)  
font(:lang=gn)  
font(:lang=gv)  
font(:lang=ho)  
font(:lang=hr)  
font(:lang=hsb)  
font(:lang=ht)  
font(:lang=hu)  
font(:lang=ia)  
font(:lang=id)  
font(:lang=ie)  
font(:lang=ig)  
font(:lang=ik)  
font(:lang=io)  
font(:lang=is)  
font(:lang=it)  
font(:lang=ja)  
font(:lang=jv)  
font(:lang=kaa)  
font(:lang=ki)  
font(:lang=kj)  
font(:lang=kk)  
font(:lang=kl)  
font(:lang=ko)  
font(:lang=ku-tr)  
font(:lang=kum)  
font(:lang=kv)  
font(:lang=kwm)  
font(:lang=ky)  
font(:lang=la)  
font(:lang=lb)  
font(:lang=lez)  
font(:lang=lg)  
font(:lang=li)  
font(:lang=lt)  
font(:lang=lv)  
font(:lang=mg)  
font(:lang=mh)  
font(:lang=mk)  
font(:lang=mn-mn)  
font(:lang=ms)  
font(:lang=mt)  
font(:lang=na)  
font(:lang=nb)  
font(:lang=nds)  
font(:lang=ng)  
font(:lang=nl)  
font(:lang=nn)  
font(:lang=no)  
font(:lang=nr)  
font(:lang=nso)  
font(:lang=ny)  
font(:lang=oc)  
font(:lang=om)  
font(:lang=os)  
font(:lang=pap-an)  
font(:lang=pap-aw)  
font(:lang=pl)  
font(:lang=pt)  
font(:lang=rm)  
font(:lang=rn)  
font(:lang=ru)  
font(:lang=rw)  
font(:lang=sah)  
font(:lang=sc)  
font(:lang=se)  
font(:lang=sel)  
font(:lang=sg)  
font(:lang=sh)  
font(:lang=sk)  
font(:lang=sl)  
font(:lang=sma)  
font(:lang=smj)  
font(:lang=smn)  
font(:lang=sn)  
font(:lang=so)  
font(:lang=sq)  
font(:lang=sr)  
font(:lang=ss)  
font(:lang=st)  
font(:lang=su)  
font(:lang=sv)  
font(:lang=sw)  
font(:lang=tg)  
font(:lang=tk)  
font(:lang=tl)  
font(:lang=tn)  
font(:lang=tr)  
font(:lang=ts)  
font(:lang=tt)  
font(:lang=ty)  
font(:lang=tyv)  
font(:lang=uk)  
font(:lang=uz)  
font(:lang=vo)  
font(:lang=vot)  
font(:lang=wa)  
font(:lang=wen)  
font(:lang=wo)  
font(:lang=xh)  
font(:lang=yap)  
font(:lang=za)  
font(:lang=zh-cn)  
font(:lang=zh-sg)  
font(:lang=zh-tw)  
font(:lang=zu)  
font(wenquanyimicrohei)  
font(wenquanyimicroheimono)  
font(文泉驛微米黑)  
font(文泉驛等寬微米黑)  
font(文泉驿微米黑)  
font(文泉驿等宽微米黑)  
wqy-microhei-fonts = 0.2.0-0.2.beta.f12

+ Requires:
/bin/sh  
/bin/sh  
config(wqy-microhei-fonts) = 0.2.0-0.2.beta.f12
fontpackages-filesystem  
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1

Approved

[Bug 545004] Review Request: wqy-microhei-fonts - compact Chinese font

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=545004

Peng Huang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

[Bug 545004] Review Request: wqy-microhei-fonts - compact Chinese font

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=545004

Peng Huang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]

[Bug 545004] Review Request: wqy-microhei-fonts - compact Chinese font

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=545004

Jens Petersen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #5 from Jens Petersen  2010-02-02 04:14:47 EST ---
Thanks

New Package CVS Request
=======================
Package Name: wqy-microhei-fonts
Short Description: Compact Chinese font derived from Droid
Owners: petersen
Branches: F-11 F12 
InitialCC: phuang

[Bug 545004] Review Request: wqy-microhei-fonts - compact Chinese font

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=545004

Chen Lei  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Chen Lei  2010-02-05 23:00:24 EST ---
Missing setting Flag to fedora‑cvs? ? wqy-microhei-fonts is an excellent CJK
outline font.

[Bug 545004] Review Request: wqy-microhei-fonts - compact Chinese font

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=545004

Jens Petersen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

[Bug 545004] Review Request: wqy-microhei-fonts - compact Chinese font

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=545004

--- Comment #7 from Kevin Fenzi  2010-02-08 19:35:39 EST ---
CVS done (by process-cvs-requests.py).

[Bug 545004] Review Request: wqy-microhei-fonts - compact Chinese font

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=545004

Jens Petersen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

--- Comment #8 from Jens Petersen  2010-02-08 20:20:08 EST ---
Thanks for the review: package is imported and built.
Thanks to wenq.org for microhei.

http://koji.fedoraproject.org/koji/taskinfo?taskID=1970500

I think phuang is considering microhei as a potential
Chinese default font instead of zenhei.