[Bug 770134] New: Review Request: trac-workflowadmin-plugin - Web interface for workflow administration for Trac

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: trac-workflowadmin-plugin -  Web interface for workflow administration for Trac

https://bugzilla.redhat.com/show_bug.cgi?id=770134

Summary: Review Request: trac-workflowadmin-plugin -  Web
                    interface for workflow administration for Trac
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],
                    [e-mail]
    Classification: Fedora
      Story Points: ---
              Type: ---
        Regression: ---
        Mount Type: ---
     Documentation: ---

Spec URL:
http://averi.fedorapeople.org/RPMs/trac-workflowadmin-plugin/trac-workflowad...
SRPM URL:
http://averi.fedorapeople.org/RPMs/trac-workflowadmin-plugin/trac-workflowad...
Description: The plugin provides the editor for workflow and the diagram of
workflow using the Graphviz programs.

@Kevin, I've built you up a package already for testing purposes, it's
available at:

http://averi.fedorapeople.org/RPMs/trac-workflowadmin-plugin/trac-workflowad...

[Bug 770134] Review Request: trac-workflowadmin-plugin - Web interface for workflow administration for Trac

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=770134

Peter Borsa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]

[Bug 770134] Review Request: trac-workflowadmin-plugin - Web interface for workflow administration for Trac

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=770134

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]       |[e-mail]
               Flag|                            |fedora-review?

--- Comment #1 from Kevin Fenzi  2011-12-23 16:04:59 EST ---
Thanks. I'll look at reviewing this soon.

Can you look at the other review and adjust the source/version for svn ?

[Bug 770134] Review Request: trac-workflowadmin-plugin - Web interface for workflow administration for Trac

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=770134

--- Comment #2 from Andrea Veri  2011-12-23 16:59:42 EST ---
Updated files as per #769922 comments can be found at:

http://averi.fedorapeople.org/RPMs/trac-workflowadmin-plugin

[Bug 770134] Review Request: trac-workflowadmin-plugin - Web interface for workflow administration for Trac

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=770134

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #3 from Kevin Fenzi  2011-12-24 17:08:14 EST ---

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistant macro usage. 
OK - Meets Packaging Guidelines. 
OK - License (BSD)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good. 
OK - Package has a correct %clean section. 
OK - Package has correct buildroot
OK - Package is code or permissible content. 
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates. 
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output. 
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should function as described. 
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin

Issues:

1. Not a blocker, but you might ask upstream to include a copy of the BSD
license with the package.

2. rpmlint says: 
trac-workflowadmin-plugin.noarch: W: spelling-error Summary(en_US) workflow ->
work flow, work-flow, workforce
trac-workflowadmin-plugin.noarch: W: spelling-error %description -l en_US
workflow -> work flow, work-flow, workforce
trac-workflowadmin-plugin.noarch: W: no-documentation
trac-workflowadmin-plugin.src: W: spelling-error Summary(en_US) workflow ->
work flow, work-flow, workforce
trac-workflowadmin-plugin.src: W: spelling-error %description -l en_US workflow
-> work flow, work-flow, workforce
trac-workflowadmin-plugin.src: W: invalid-url Source0:
trac-workflowadmin-plugin-0.12.svn11020.tar.gz

all can be ignored.

I don't see any blockers here, so this package is APPROVED. 
Happy to co-maintain.

[Bug 770134] Review Request: trac-workflowadmin-plugin - Web interface for workflow administration for Trac

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=770134

Andrea Veri  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #4 from Andrea Veri  2011-12-25 13:45:59 EST ---
New Package SCM Request
=======================
Package Name: trac-workflowadmin-plugin
Short Description: Web interface for workflow administration for Trac 
Owners: averi kevin
Branches: f16 el6
InitialCC: averi kevin

[Bug 770134] Review Request: trac-workflowadmin-plugin - Web interface for workflow administration for Trac

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=770134

--- Comment #5 from Kevin Fenzi  2011-12-25 14:55:50 EST ---
Git done (by process-git-requests).

[Bug 770134] Review Request: trac-workflowadmin-plugin - Web interface for workflow administration for Trac

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=770134

Andrea Veri  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE
        Last Closed|                            |2011-12-28 07:52:56

--- Comment #6 from Andrea Veri  2011-12-28 07:52:56 EST ---
Built fine, closing ticket.

[Bug 770134] Review Request: trac-workflowadmin-plugin - Web interface for workflow administration for Trac

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=770134

--- Comment #7 from Fedora Update System  2011-12-28 13:41:53 EST ---
trac-workflowadmin-plugin-0.12-20111223svn11062.el6 has been submitted as an
update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/trac-workflowadmin-plugin-0.12-20111...

[Bug 770134] Review Request: trac-workflowadmin-plugin - Web interface for workflow administration for Trac

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=770134

--- Comment #8 from Fedora Update System  2012-01-15 18:20:48 EST ---
trac-workflowadmin-plugin-0.12-20111223svn11062.el6 has been pushed to the
Fedora EPEL 6 stable repository.