[Bug 1444522] New: Review Request: php-theseer-tokenizer - Library for converting tokenized PHP source code into XML
https://bugzilla.redhat.com/show_bug.cgi?id=1444522
Bug ID: 1444522 Summary: Review Request: php-theseer-tokenizer - Library for converting tokenized PHP source code into XML Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fedora@famillecollet.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://git.remirepo.net/cgit/rpms/php/theseer/php-theseer-tokenizer.git/pla... SRPM URL: http://rpms.remirepo.net/SRPMS/php-theseer-tokenizer-1.1.0-1.remi.src.rpm Description: A small library for converting tokenized PHP source code into XML and potentially other formats.
Fedora Account System Username: remi
https://bugzilla.redhat.com/show_bug.cgi?id=1444522
François Kooman fkooman@tuxed.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fkooman@tuxed.net Assignee|nobody@fedoraproject.org |fkooman@tuxed.net
https://bugzilla.redhat.com/show_bug.cgi?id=1444522
François Kooman fkooman@tuxed.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1444522
--- Comment #1 from François Kooman fkooman@tuxed.net --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "*No copyright* BSD (3 clause)", "Unknown or generated". 23 files have unknown license. Detailed output of licensecheck in /home/fedora/1444522-php-theseer- tokenizer/licensecheck.txt [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/php/TheSeer(php- theseer-directoryscanner)
*** This seems expected when multiple packages have the same vendor...
[x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary.
*** Aha! phpab is required by php-fedora-autoloader :-)
[x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described.
I didn't not check the functionality...
[x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files.
GitHub does not retain this information, so nothing can be done.
[x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
PHP: [x]: Run phpci static analyze on all php files. Note: phpCompatInfo version 5.0.6 DB version 1.19.0 built Mar 17 2017 07:03:16 CET static analyze results in /home/fedora/1444522-php- theseer-tokenizer/phpci.log
https://bugzilla.redhat.com/show_bug.cgi?id=1444522
François Kooman fkooman@tuxed.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags|fedora-review? |fedora-review+
--- Comment #2 from François Kooman fkooman@tuxed.net --- Approved!
https://bugzilla.redhat.com/show_bug.cgi?id=1444522
--- Comment #3 from Remi Collet fedora@famillecollet.com --- Thanks for the review!
New package requested on pkgdb.
https://bugzilla.redhat.com/show_bug.cgi?id=1444522
--- Comment #4 from Gwyn Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-theseer-tokenizer
https://bugzilla.redhat.com/show_bug.cgi?id=1444522
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- php-theseer-tokenizer-1.1.0-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-61fddee249
https://bugzilla.redhat.com/show_bug.cgi?id=1444522
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1444522
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- php-theseer-tokenizer-1.1.0-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-61fddee249
https://bugzilla.redhat.com/show_bug.cgi?id=1444522
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2017-05-05 09:33:41
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- php-theseer-tokenizer-1.1.0-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com