Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: libcue - CUE sheet parser library
https://bugzilla.redhat.com/show_bug.cgi?id=533803
Summary: Review Request: libcue - CUE sheet parser library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: lemenkov@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://peter.fedorapeople.org/libcue.spec SRPM URL: http://peter.fedorapeople.org/libcue-1.3.0-1.fc11.src.rpm Description: Libcue is intended to parse a so called cue sheet from a char string or a file pointer. For handling of the parsed data a convenient API is available.
rpmlint output:
[petro@Sulaco SPECS]$ rpmlint ../RPMS/ppc/libcue-* libcue.ppc: W: shared-lib-calls-exit /usr/lib/libcue.so.1.0.3 exit@GLIBC_2.0 libcue-devel.ppc: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 2 warnings.
koji scratchbuild for F-11:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1795571
This package is a requirement for CUE support in MPD.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=533803
Michael Schwendt mschwendt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mschwendt@gmail.com AssignedTo|nobody@fedoraproject.org |mschwendt@gmail.com Flag| |fedora-review?
--- Comment #1 from Michael Schwendt mschwendt@gmail.com 2009-11-14 04:19:05 EDT --- * "Group" tag of base package should be: System Environment/Libraries
* Source URL points at a web page instead of the source tarball. Use this (it follows the guidelines, too): http://downloads.sourceforge.net/libcue/libcue-%%7Bversion%7D.tar.bz2
%description Libcue is intended to parse a so called [...]
Correct English IMO would be: Libcue is intended for parsing a so-called [...]
W: shared-lib-calls-exit /usr/lib/libcue.so.1.0.3 exit@GLIBC_2.0
Not good, since this is a library. Libraries ought to return error values instead of terminating the process. This exit call is in a fatal error function inside the generated flex scanner code.
* Two source files rem.c and rem.h contain a BSD license header and the name of the current developer. According to Fedora's Licensing Guidelines, this must be reflected in the "License" tag plus a comment in the spec file:
# Files libcue/rem.{c,h} contain a BSD header License: GPLv2 and BSD
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licens...
The project's file "COPYING" comments on the two licences and explicitly acknowledges that the whole libcue project uses the GPLv2. Preferably, the current developer removes the ambiguity and explicitly applies the GPLv2 inside the rem.c/rem.h files, too.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=533803
--- Comment #2 from Peter Lemenkov lemenkov@gmail.com 2009-11-23 05:13:47 EDT --- Fi(In reply to comment #1)
- "Group" tag of base package should be: System Environment/Libraries
Fixed.
- Source URL points at a web page instead of the source tarball. Use this (it
follows the guidelines, too): http://downloads.sourceforge.net/libcue/libcue-%%7Bversion%7D.tar.bz2
Fixed.
%description Libcue is intended to parse a so called [...]
Correct English IMO would be: Libcue is intended for parsing a so-called [...]
Fixed.
W: shared-lib-calls-exit /usr/lib/libcue.so.1.0.3 exit@GLIBC_2.0
Not good, since this is a library. Libraries ought to return error values instead of terminating the process. This exit call is in a fatal error function inside the generated flex scanner code.
I'll sent a message upstream regarding this issue.
- Two source files rem.c and rem.h contain a BSD license header and the name of
the current developer. According to Fedora's Licensing Guidelines, this must be reflected in the "License" tag plus a comment in the spec file:
# Files libcue/rem.{c,h} contain a BSD header License: GPLv2 and BSD
Fixed.
http://peter.fedorapeople.org/libcue.spec http://peter.fedorapeople.org/libcue-1.3.0-2.fc12.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=533803
Michael Schwendt mschwendt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #3 from Michael Schwendt mschwendt@gmail.com 2009-11-23 05:36:23 EDT --- With those changes, libcue-1.3.0-2.fc12.src.rpm is good to go:
APPROVED
[...]
Note that in Fedora 10 and newer you can omit:
* the BuildRoot tag * removal of buildroot at beginning of %install * the entire %clean section
Plus in current Fedora 11 and later, there are automatic pkgconfig dependencies. So on those platforms, the "Requires: pkgconfig" is redundant.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=533803
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #4 from Peter Lemenkov lemenkov@gmail.com 2009-11-23 05:58:00 EDT --- Thanks!
(In reply to comment #3)
With those changes, libcue-1.3.0-2.fc12.src.rpm is good to go:
Note that in Fedora 10 and newer you can omit:
- the BuildRoot tag
- removal of buildroot at beginning of %install
- the entire %clean section
Plus in current Fedora 11 and later, there are automatic pkgconfig dependencies. So on those platforms, the "Requires: pkgconfig" is redundant.
I plan to provide libcue for EPEL too, so in order to simplify maintenance, I won't delete all these redundant tags, at least until EPEL will get our new rpm and support for EL-5 will be dropped :)
New Package CVS Request ======================= Package Name: libcue Short Description: Cue sheet parser library Owners: peter Branches: F-11 F-12 EL-4 EL-5 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=533803
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #5 from Kevin Fenzi kevin@tummy.com 2009-11-23 21:10:31 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=533803
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2009-11-24 01:52:36 EDT --- libcue-1.3.0-2.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/libcue-1.3.0-2.el5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=533803
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2009-11-24 01:52:42 EDT --- libcue-1.3.0-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/libcue-1.3.0-2.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=533803
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2009-11-24 01:52:47 EDT --- libcue-1.3.0-2.el4 has been submitted as an update for Fedora EPEL 4. http://admin.fedoraproject.org/updates/libcue-1.3.0-2.el4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=533803
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2009-11-24 01:52:52 EDT --- libcue-1.3.0-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/libcue-1.3.0-2.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=533803
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2009-11-24 14:24:18 EDT --- libcue-1.3.0-2.el4 has been pushed to the Fedora EPEL 4 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libcue'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-4/FEDORA-EPEL-2009-0899
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=533803
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2009-11-24 14:24:53 EDT --- libcue-1.3.0-2.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libcue'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0904
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=533803
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2009-11-25 10:13:10 EDT --- libcue-1.3.0-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libcue'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-12113
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=533803
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2009-11-25 10:33:31 EDT --- libcue-1.3.0-2.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libcue'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-12194
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=533803
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2009-11-30 23:15:21 EDT --- libcue-1.3.0-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=533803
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |1.3.0-2.fc12 Resolution| |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=533803
--- Comment #15 from Fedora Update System updates@fedoraproject.org 2009-11-30 23:22:09 EDT --- libcue-1.3.0-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=533803
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|1.3.0-2.fc12 |1.3.0-2.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=533803
--- Comment #16 from Fedora Update System updates@fedoraproject.org 2009-12-09 23:02:29 EDT --- libcue-1.3.0-2.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=533803
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|1.3.0-2.fc11 |1.3.0-2.el4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=533803
--- Comment #17 from Fedora Update System updates@fedoraproject.org 2009-12-09 23:03:06 EDT --- libcue-1.3.0-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=533803
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|1.3.0-2.el4 |1.3.0-2.el5
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla