[Bug 1854729] New: Review Request: nispor - API for network state query writtent in rust
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Bug ID: 1854729 Summary: Review Request: nispor - API for network state query writtent in rust Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fge@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://fedorapeople.org/~cathay4t/nispor/nispor.spec SRPM URL: https://fedorapeople.org/~cathay4t/nispor/nispor-0.1.0-1.fc33.src.rpm Description: Providing rust/python/varlink interface for network status query writtent in rust. Fedora Account System Username: cathay4t
The dependent rust crates are stored in: https://copr.fedorainfracloud.org/coprs/cathay4t/nispor/builds/
rust-pyo3 rust-pyo3cls rust-inventory rust-pyo3-derive-backend rust-indoc rust-ghost rust-inventory-impl rust-indoc-impl rust-unindent rust-ctor rust-rtnetlink rust-netlink-packet-route rust-netlink-proto rust-netlink-sys rust-netlink-packet-core rust-netlink-packet-utils
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
--- Comment #1 from Gris Ge fge@redhat.com --- The rust crates src rpm is created by this script:
```bash #!/bin/bash -ex
mkdir rust-$1 || true cd rust-$1 rust2rpm -s $1 cp *.crate ~/rpmbuild/SOURCES/ sed -i -e's/bcond_without/bcond_with/' rust-$1.spec sed -i -e'/%doc ../README.md/d' rust-$1.spec rpmbuild -bs rust-$1.spec scp ~/rpmbuild/SRPMS/rust-$1*.src.rpm gris-laptop:/tmp
```
Notes: * Disabled the `check` as it will introduce a long list of dependent crates. * Removed the `%doc ..README.md` as that is does not exists.
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
--- Comment #2 from Gris Ge fge@redhat.com --- New SRPM URL: https://fedorapeople.org/~cathay4t/nispor/nispor-0.1.1-1.fc33.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #3 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- -No license, no docs?
%files %doc AUTHORS CHANGELOG DEVEL.md README.md %license LICENSE %{_bindir}/npc %{_bindir}/npd %{_unitdir}/nispor.socket %{_unitdir}/nispor.service
%files -n python3-%{name} %license LICENSE %{python3_sitelib}/nispor.so
%files -n rust-%{name}-devel %license LICENSE %{cargo_registry}/%{name}-%{version_no_tilde}/
%files -n rust-%{name}+default-devel %ghost %{cargo_registry}/%{name}-%{version_no_tilde}/Cargo.toml
I can't build due to missing deps:
DEBUG util.py:621: Problem 1: nothing provides requested (crate(netlink-packet-route/default) >= 0.3.0 with crate(netlink-packet-route/default) < 0.4.0) DEBUG util.py:621: Problem 2: nothing provides requested (crate(netlink-sys/default) >= 0.3.0 with crate(netlink-sys/default) < 0.4.0) DEBUG util.py:621: Problem 3: nothing provides requested (crate(pyo3/extension-module) >= 0.11.1 with crate(pyo3/extension-module) < 0.12.0) DEBUG util.py:621: Problem 4: nothing provides requested (crate(pyo3/macros)
= 0.11.1 with crate(pyo3/macros) < 0.12.0)
DEBUG util.py:621: Problem 5: nothing provides requested (crate(rtnetlink/default) >= 0.3.0 with crate(rtnetlink/default) < 0.4.0)
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
--- Comment #4 from Gris Ge fge@redhat.com --- The dependent rust crates are stored in: https://copr.fedorainfracloud.org/coprs/cathay4t/nispor/builds/
I will add the license and etc.
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
--- Comment #5 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- (In reply to Gris Ge from comment #4)
The dependent rust crates are stored in: https://copr.fedorainfracloud.org/coprs/cathay4t/nispor/builds/
Shouldn't you open new Review Requests for these crates then? Otherwise it can't be built in Rawhide.
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
--- Comment #6 from Till Maas till@redhat.com --- It would be nice to have egg-info for the python module.
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
--- Comment #7 from Gris Ge fge@redhat.com --- (In reply to Till Maas from comment #6)
It would be nice to have egg-info for the python module.
The setuptool-rust can generate that file, but that would introduce another dependency which is no ideal for CentOS/RHEL.
I will try to write a simpler version of `setuptool-rust` for this, but not a priority.
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
--- Comment #8 from Gris Ge fge@redhat.com --- New SPEC file uploaded: https://fedorapeople.org/~cathay4t/nispor/nispor.spec
New SRPM: https://download.copr.fedorainfracloud.org/results/cathay4t/nispor/fedora-ra...
Changes: * Included license and documents.
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Gris Ge fge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ferferna@redhat.com Flags| |needinfo?(ferferna@redhat.c | |om)
--- Comment #9 from Gris Ge fge@redhat.com --- Hi Fernando,
Can you take review on this also?
Thank you.
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
--- Comment #10 from Fernando F. Mancera ferferna@redhat.com --- The SPEC file looks good to me. I am not sure if it is a good idea to have the dependent crates in a Copr repository. Will this force all the users to enable the copr repository before installing nispor?
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
--- Comment #11 from Gris Ge fge@redhat.com --- (In reply to Fernando F. Mancera from comment #10)
The SPEC file looks good to me. I am not sure if it is a good idea to have the dependent crates in a Copr repository. Will this force all the users to enable the copr repository before installing nispor?
The copr repo is just demonstration it works.
Packaging rust crates is rule of Fedora rawhide. And for Fedora stable rpm, it will just use the compiled package built from the Fedora rawhide buildroot.
The rust package is static linking, once compiled, it does not has runtime dependency besides glibc.
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Fernando F. Mancera ferferna@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ferferna@redhat.c |needinfo+ |om) |
--- Comment #12 from Fernando F. Mancera ferferna@redhat.com --- (In reply to Gris Ge from comment #11)
(In reply to Fernando F. Mancera from comment #10)
The SPEC file looks good to me. I am not sure if it is a good idea to have the dependent crates in a Copr repository. Will this force all the users to enable the copr repository before installing nispor?
The copr repo is just demonstration it works.
Packaging rust crates is rule of Fedora rawhide. And for Fedora stable rpm, it will just use the compiled package built from the Fedora rawhide buildroot.
The rust package is static linking, once compiled, it does not has runtime dependency besides glibc.
Oh, in that case, it looks good to me. Thanks for explaining.
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Gris Ge fge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo+ |needinfo?(fge@redhat.com)
--- Comment #13 from Gris Ge fge@redhat.com --- Will create new package request for dependent rust crates.
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Gris Ge fge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1860781
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1860781 [Bug 1860781] Review Request: rust-netlink-packet-core - core package for netlink rust binding
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Gris Ge fge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1860784
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1860784 [Bug 1860784] Review Request: rust-netlink-packet-route - rust binding for netlink route protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Gris Ge fge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1860785
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1860785 [Bug 1860785] Review Request: rust-netlink-packet-utils - Utils of rust netlink binding
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Gris Ge fge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1860787
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1860787 [Bug 1860787] Review Request: rust-netlink-proto - Netlink protocol constants for rust netlink binding
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Gris Ge fge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1860790
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1860790 [Bug 1860790] Review Request: rust-netlink-sys - The system tools(sockets, aync, etc) for rust binding
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Gris Ge fge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1860792
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1860792 [Bug 1860792] Review Request: rust-rtnetlink - The rtnetlink interface for rust netlink binding
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Gris Ge fge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1860794
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1860794 [Bug 1860794] Review Request: rust-ctor - Module initialization/global constructor functions for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Gris Ge fge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1860796
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1860796 [Bug 1860796] Review Request: rust-unindent - Compile time tool for indoc's indentation
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Gris Ge fge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1860797
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1860797 [Bug 1860797] Review Request: rust-indoc-impl - procedural macro for indented string literals
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Gris Ge fge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1860798
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1860798 [Bug 1860798] Review Request: rust-inventory-impl - Implementation of macros for the `inventory` crate
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Gris Ge fge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1860800
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1860800 [Bug 1860800] Review Request: rust-ghost - Define your own PhantomData and similarly behaved unit types in rust
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Gris Ge fge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1860801
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1860801 [Bug 1860801] Review Request: rust-indoc - procedural macro for indented string literals
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Gris Ge fge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1860802
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1860802 [Bug 1860802] Review Request: rust-pyo3-derive-backend - implementation of the proc macro attributes of pyo3
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Gris Ge fge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1860803
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1860803 [Bug 1860803] Review Request: rust-inventory - Rust typed distributed plugin registration.
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Gris Ge fge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1860805
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1860805 [Bug 1860805] Review Request: rust-pyo3cls - Proc macros for rust-pyo3 package
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Gris Ge fge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1860806
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1860806 [Bug 1860806] Review Request: rust-pyo3 - Rust bindings for the Python interpreter
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Gris Ge fge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(fge@redhat.com) |
--- Comment #14 from Gris Ge fge@redhat.com --- Dependent rust crates package created at:
https://bugzilla.redhat.com/buglist.cgi?bug_id=1854729&bug_id_type=andde...
They could be grouped into two: * rust-rtnetlink and its dependencies * rust-pyo3 and its dependencies
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Gris Ge fge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: nispor - |Review Request: nispor - |API for network state query |API for network state query |writtent in rust |written in rust
https://bugzilla.redhat.com/show_bug.cgi?id=1854729 Bug 1854729 depends on bug 1860794, which changed state.
Bug 1860794 Summary: Review Request: rust-ctor - Module initialization/global constructor functions for Rust https://bugzilla.redhat.com/show_bug.cgi?id=1860794
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NOTABUG
https://bugzilla.redhat.com/show_bug.cgi?id=1854729 Bug 1854729 depends on bug 1860800, which changed state.
Bug 1860800 Summary: Review Request: rust-ghost - Define your own PhantomData and similarly behaved unit types in rust https://bugzilla.redhat.com/show_bug.cgi?id=1860800
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |WONTFIX
https://bugzilla.redhat.com/show_bug.cgi?id=1854729 Bug 1854729 depends on bug 1860796, which changed state.
Bug 1860796 Summary: Review Request: rust-unindent - Compile time tool for indoc's indentation https://bugzilla.redhat.com/show_bug.cgi?id=1860796
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |WONTFIX
https://bugzilla.redhat.com/show_bug.cgi?id=1854729 Bug 1854729 depends on bug 1860797, which changed state.
Bug 1860797 Summary: Review Request: rust-indoc-impl - procedural macro for indented string literals https://bugzilla.redhat.com/show_bug.cgi?id=1860797
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |WONTFIX
https://bugzilla.redhat.com/show_bug.cgi?id=1854729 Bug 1854729 depends on bug 1860798, which changed state.
Bug 1860798 Summary: Review Request: rust-inventory-impl - Implementation of macros for the `inventory` crate https://bugzilla.redhat.com/show_bug.cgi?id=1860798
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |WONTFIX
https://bugzilla.redhat.com/show_bug.cgi?id=1854729 Bug 1854729 depends on bug 1860801, which changed state.
Bug 1860801 Summary: Review Request: rust-indoc - procedural macro for indented string literals https://bugzilla.redhat.com/show_bug.cgi?id=1860801
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |WONTFIX
https://bugzilla.redhat.com/show_bug.cgi?id=1854729 Bug 1854729 depends on bug 1860802, which changed state.
Bug 1860802 Summary: Review Request: rust-pyo3-derive-backend - implementation of the proc macro attributes of pyo3 https://bugzilla.redhat.com/show_bug.cgi?id=1860802
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |WONTFIX
https://bugzilla.redhat.com/show_bug.cgi?id=1854729 Bug 1854729 depends on bug 1860803, which changed state.
Bug 1860803 Summary: Review Request: rust-inventory - Rust typed distributed plugin registration. https://bugzilla.redhat.com/show_bug.cgi?id=1860803
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |WONTFIX
https://bugzilla.redhat.com/show_bug.cgi?id=1854729 Bug 1854729 depends on bug 1860805, which changed state.
Bug 1860805 Summary: Review Request: rust-pyo3cls - Proc macros for rust-pyo3 package https://bugzilla.redhat.com/show_bug.cgi?id=1860805
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |WONTFIX
https://bugzilla.redhat.com/show_bug.cgi?id=1854729 Bug 1854729 depends on bug 1860806, which changed state.
Bug 1860806 Summary: Review Request: rust-pyo3 - Rust bindings for the Python interpreter https://bugzilla.redhat.com/show_bug.cgi?id=1860806
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |WONTFIX
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Gris Ge fge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(zebob.m@gmail.com | |)
--- Comment #15 from Gris Ge fge@redhat.com --- New rpm SPEC uploaded: https://fedorapeople.org/~cathay4t/nispor/nispor.spec New srpm: https://download.copr.fedorainfracloud.org/results/cathay4t/nispor/fedora-ra...
Changes: * Upgrade to 0.3.0 * `python3-nmstate` now have egginfo files. * Removed the need of rust-pyo3. So currently, missing dependent rust-crates is rust-netlink and its subpackages.
Please also review these dependent rust-crates:
* Bug 1860781 Review Request: rust-netlink-packet-core * Bug 1860784 Review Request: rust-netlink-packet-route * Bug 1860785 Review Request: rust-netlink-packet-utils * Bug 1860787 Review Request: rust-netlink-proto * Bug 1860790 Review Request: rust-netlink-sys * Bug 1860792 Review Request: rust-rtnetlink
Since I am actively working with rust-netlink upstream, I will be the rpm maintainer of above packages also.
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(zebob.m@gmail.com | |) |
--- Comment #16 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - Add comments explaining why patches are needed
Patch1: 0001-varlink-Upgrade-to-rust-varlink-11.patch Patch2: 0002-Makefile-Better-handling-on-libdir.patch
- Please justify why you disabled the tests:
%bcond_with check
-
env SKIP_PYTHON_INSTALL=1 DESTDIR=%{buildroot} PREFIX=/usr \ LIBDIR=%{_libdir} make install
→
env SKIP_PYTHON_INSTALL=1 PREFIX=%{_prefix} \ LIBDIR=%{_libdir} %make_install
- Add license in these packages as well
%files -n python3-%{name} %license LICENSE %{python3_sitelib}/nispor*
%files -n rust-%{name}-devel %license LICENSE %{cargo_registry}/%{name}-%{version_no_tilde}/
- In order to avoid unintentional soname bump, we recommend not globbing the major soname version:
%{_libdir}/libnispor.so.0*
- Add arch specific info for your Requires
%package devel Summary: %{summary} Requires: nispor%{?_isa} = %{?epoch:%{epoch}:}%{version}-%{release}
-Error while installing
DEBUG util.py:621: Problem: conflicting requests DEBUG util.py:621: - nothing provides libnispor.so()(64bit) needed by nispor-devel-0.3.0-1.fc34.x86_64
Not sure what's causing this:
rpm -q --provides -p nispor-devel-0.3.0-1.fc34.x86_64.rpm | sort -f | uniq -c 21:19:36 1 nispor-devel = 0.3.0-1.fc34 1 nispor-devel(x86-64) = 0.3.0-1.fc34
rpm -q --requires -p nispor-devel-0.3.0-1.fc34.x86_64.rpm | sort -f | uniq -c 21:20:01 1 libnispor.so()(64bit) 1 nispor(x86-64) = 0.3.0-1.fc34 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1
It seems to me the library is badly compiled as it doesn't have a soname:
objdump -p libnispor.so.0.3.0 | grep SONAME
Could be why it isn't requiring libnispor.so()(64bit) instead of libnispor.so.0.3.0()(64bit)
- libnispor.so.0.3.0 is not marked as 0755:
-rw-r--r--. 1 bob bob 14M Aug 25 21:16 libnispor.so.0.3.0
Use:
chmod 0755 %{buildroot}%{_libdir}/libnispor.so.0.3.0
in install, but or use the patch I sent upstream to fix the Makefile, line 87:
install -v -D -m644 $(CLIB_SO_DEV_RELEASE) \ $(DESTDIR)$(LIBDIR)/$(CLIB_SO_FULL)
Should be 0755: https://github.com/nispor/nispor/pull/13
On a side note this allow you to reenable the debuginfo, now that the library is executable, debuginfo will be correctly generated.
- Also you should fix the Makefile to use "install -p" for files to keep the timestamps.
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
--- Comment #17 from Gris Ge fge@redhat.com --- Hi Robert-André Mauchin,
Thanks for the review.
Still fixing `libnispor.so()(64bit)` issue, the `SONAME` does not helps.
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Gris Ge fge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(zebob.m@gmail.com | |)
--- Comment #18 from Gris Ge fge@redhat.com --- New rpm SPEC uploaded: https://fedorapeople.org/~cathay4t/nispor/nispor.spec New srpm: https://download.copr.fedorainfracloud.org/results/cathay4t/nispor/fedora-ra...
Changes: * Upgrade to 0.4.0 * Add license file to `nispor-devel`, `python3-nispor` and `rust-nispor-devel`. * Fixed the SONAME which impact on the `nispor-devel` requirements. The root cause is %cargo_prep override upstream `.cargo/config.toml`. Workaround by merged upstream rustflags into %cargo_prep.
Thank you!
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(zebob.m@gmail.com | |) |
--- Comment #19 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- nispor.src:124: W: libdir-macro-in-noarch-package (main package) %{_libdir}/libnispor.so.* nispor.src:134: W: libdir-macro-in-noarch-package devel %{_libdir}/libnispor.so
These packages should be noarch since you shipping arched binary code in it.
python3-nispor.noarch: E: useless-provides python3dist(nispor) rust-nispor-devel.noarch: E: useless-provides crate(nispor) rust-nispor+default-devel.noarch: E: useless-provides crate(nispor/default)
Not exactly sure what is causing that error to show up, but in all cases,
Provides: python3dist(%{name}) = %{version} Provides: crate(%{name}) = %{version} Provides: crate(%{name}/default) = %{version}
this shouldn't be necessary, they should be autodetected.
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
--- Comment #20 from Gris Ge fge@redhat.com --- Thanks for the review.
I have updated the rpm SPEC: https://fedorapeople.org/~cathay4t/nispor/nispor.spec Source rpm: https://fedorapeople.org/~cathay4t/nispor/nispor-0.4.0-2.fc34.src.rpm
Copr repo for testing: https://copr.fedorainfracloud.org/coprs/cathay4t/nispor/
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #21 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
--- Comment #22 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nispor
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Gris Ge fge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(zebob.m@gmail.com | |)
--- Comment #23 from Gris Ge fge@redhat.com --- Hi Robert-André Mauchin,
Do you know how to include package into Fedora 33?
The rawhide build is named as f34.
https://bugzilla.redhat.com/show_bug.cgi?id=1854729 Bug 1854729 depends on bug 1860790, which changed state.
Bug 1860790 Summary: Review Request: rust-netlink-sys - The system tools(sockets, aync, etc) for rust binding https://bugzilla.redhat.com/show_bug.cgi?id=1860790
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |CURRENTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=1854729 Bug 1854729 depends on bug 1860787, which changed state.
Bug 1860787 Summary: Review Request: rust-netlink-proto - Netlink protocol constants for rust netlink binding https://bugzilla.redhat.com/show_bug.cgi?id=1860787
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |CURRENTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=1854729 Bug 1854729 depends on bug 1860785, which changed state.
Bug 1860785 Summary: Review Request: rust-netlink-packet-utils - Utils of rust netlink binding https://bugzilla.redhat.com/show_bug.cgi?id=1860785
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |CURRENTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=1854729 Bug 1854729 depends on bug 1860784, which changed state.
Bug 1860784 Summary: Review Request: rust-netlink-packet-route - rust binding for netlink route protocol https://bugzilla.redhat.com/show_bug.cgi?id=1860784
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |CURRENTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=1854729 Bug 1854729 depends on bug 1860781, which changed state.
Bug 1860781 Summary: Review Request: rust-netlink-packet-core - core package for netlink rust binding https://bugzilla.redhat.com/show_bug.cgi?id=1860781
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |CURRENTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=1854729 Bug 1854729 depends on bug 1860792, which changed state.
Bug 1860792 Summary: Review Request: rust-rtnetlink - The rtnetlink interface for rust netlink binding https://bugzilla.redhat.com/show_bug.cgi?id=1860792
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |CURRENTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=1854729
Gris Ge fge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Fixed In Version| |nispor-0.5.0-2.fc34 Resolution|--- |CURRENTRELEASE Flags|needinfo?(zebob.m@gmail.com | |) | Last Closed| |2020-09-07 07:52:19
--- Comment #24 from Gris Ge fge@redhat.com --- Never mind. I missed the deadline of Fedora 33.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com