[Bug 1786918] New: Review Request: restmbmaster - Rest API gateway to Modbus slaves

https://bugzilla.redhat.com/show_bug.cgi?id=1786918

Bug ID: 1786918
           Summary: Review Request: restmbmaster - Rest API gateway to
                    Modbus slaves
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: http://resnulli.us/restmbmaster/restmbmaster.spec
SRPM URL: http://resnulli.us/restmbmaster/restmbmaster-1-1.fc32.src.rpm
Description: This package contains a tool called restmbmaster which
is a simple daemon that allows user to access Modbus slaves
over Rest API. The slaves could be either connected over
serial line (Modbus RTU protocol), or over TCP (Modbus TCP protocol).
Fedora Account System Username: jirka

[Bug 1786918] Review Request: restmbmaster - Rest API gateway to Modbus slaves

https://bugzilla.redhat.com/show_bug.cgi?id=1786918

Dan Horák  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
           Doc Type|---                         |If docs needed, set a value
              Flags|                            |fedora-review?

--- Comment #1 from Dan Horák  ---
few rather cosmetic issues
- s/Source:/Source0:/
- you can use %{make_build} and %{make_install} instead of make + parameters in
%build and %install
- consider using %{name} in Source and %files instead of repeating
"restmbmaster"
- $RPM_BUILD_ROOT is being obsoleted, %{buildroot} is the modern equivalent
- drop the %config/%attr options for the unit file, the system unit file is not
a config file and the set attributes are the default ones anyway
- you might want to include /etc/restmbmaster/ directory in the package

[Bug 1786918] Review Request: restmbmaster - Rest API gateway to Modbus slaves

https://bugzilla.redhat.com/show_bug.cgi?id=1786918

--- Comment #2 from Jiri Pirko  ---
(In reply to Dan Horák from comment #1)
> few rather cosmetic issues
> s/Source:/Source0:/
> you can use %{make_build} and %{make_install} instead of make + parameters
>
> in %build and %install
> consider using %{name} in Source and %files instead of repeating
>
> "restmbmaster"
> $RPM_BUILD_ROOT is being obsoleted, %{buildroot} is the modern equivalent
> drop the %config/%attr options for the unit file, the system unit file is
>
> not a config file and the set attributes are the default ones anyway
> you might want to include /etc/restmbmaster/ directory in the package

Thanks Dan! I fixed all. Please check the original links.

[Bug 1786918] Review Request: restmbmaster - Rest API gateway to Modbus slaves

https://bugzilla.redhat.com/show_bug.cgi?id=1786918

Dan Horák  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #3 from Dan Horák  ---
formal review is here, see the notes explaining OK* and BAD statuses below:

OK      source files match upstream:
            b91074048a2cd4b092d25c845c2aaa543d26b9ab  restmbmaster-1.tar.gz
OK      package meets naming and versioning guidelines.
OK      specfile is properly named, is cleanly written and uses macros
consistently.
OK      dist tag is present.
OK      license field matches the actual license (GPLv2+)
OK      license is open source-compatible. License text included in package
OK      latest version is being packaged.
OK      BuildRequires are proper.
OK      compiler flags are appropriate.
OK      package builds in mock (Rawhide/ppc64le).
OK      debuginfo package looks complete.
OK      rpmlint is silent.
Ok      final provides and requires look sane.
N/A     %check is present and all tests pass.
OK      no shared libraries are added to the regular linker search paths.
OK      owns the directories it creates.
OK      doesn't own any directories it shouldn't.
OK      no duplicates in %files.
OK      file permissions are appropriate.
OK      no scriptlets present.
OK      code, not content.
OK      documentation is small, so no -docs subpackage is necessary.
OK      %docs are not necessary for the proper functioning of the package.
OK      no headers.
OK      no pkgconfig files.
OK      no libtool .la droppings.
OK      not a GUI app.

- IMO the URL tag shouldn't use the %{name} macro, it's useful when it's
directly usable/clickable, without macro expansion
- build throws following when packaging the docs, I guess only the
"example_configs" dir should be listed as %doc
...
cp: cannot stat 'restmbmaster/example_configs/': No such file or directory
...

The package is APPROVED.

[Bug 1786918] Review Request: restmbmaster - Rest API gateway to Modbus slaves

https://bugzilla.redhat.com/show_bug.cgi?id=1786918

--- Comment #4 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/restmbmaster

[Bug 1786918] Review Request: restmbmaster - Rest API gateway to Modbus slaves

https://bugzilla.redhat.com/show_bug.cgi?id=1786918

Jiri Pirko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2020-01-09 14:55:34