[Bug 228469] New: Review Request: hunspell-de - German hunspell dictionaries

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228469

Summary: Review Request: hunspell-de - German hunspell
                    dictionaries
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: http://people.redhat.com/caolanm/hunspell/hunspell-de.spec
SRPM URL: http://people.redhat.com/caolanm/hunspell/hunspell-de-0.20051213-1.src.rpm
Description: German hunspell dictionaries

Similar to 227811

[Bug 228469] Review Request: hunspell-de - German hunspell dictionaries

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hunspell-de - German hunspell dictionaries

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228469

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
OtherBugsDependingO|163776                      |163779
              nThis|                            |

------- Additional Comments From [e-mail]  2007-02-13 05:26 EST -------
- package meets naming guidelines
- package meets packaging guidelines 
- spec file legible, in am. english
- source matches upstream , sha1sum 
09beb35f8fd3753125535a920a1a001ce5b28fa8  de_DE-20051213.zip
de75be0efe486a69a24f13ec33be5bb0357dc599  de_CH-20051213.zip

- the package builds in mock for devel/x86_64, generates a noarch (which is
consistent with the fact that basically it includes only 3 text files)
- the license GPL stated in the tag is the same as the web site says
- there are only 2 files (word lists) + a short doc with instructions and
license clearance, so no need for -doc and no .la, .pc, static files
- no missing BR
- no locales
- not relocatable
- owns all files/directories that it creates, does not take ownership of other
files/dirs
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- rpmlint outputsilent
- code, not content
- no need for -docs as the only doc is just a 5K text file with the GPL license
in Welsh and English
- nothing in %doc affects runtime
- no need for .desktop file

APPROVED

PS: Maybe you could also include the de_AT dictionary files ? They seem to be
based roughly on the same word lists

[Bug 228469] Review Request: hunspell-de - German hunspell dictionaries

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hunspell-de - German hunspell dictionaries

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228469

------- Additional Comments From [e-mail]  2007-02-13 05:29 EST -------
Of course there is no Welsh, but German involved. Sorry.

[Bug 228469] Review Request: hunspell-de - German hunspell dictionaries

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hunspell-de - German hunspell dictionaries

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228469

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs+

[Bug 228469] Review Request: hunspell-de - German hunspell dictionaries

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hunspell-de - German hunspell dictionaries

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228469

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2007-02-14 05:02 EST -------
 27541 (hunspell-de): Build on target fedora-development-extras succeeded.

[Bug 228469] Review Request: hunspell-de - German hunspell dictionaries

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hunspell-de - German hunspell dictionaries

https://bugzilla.redhat.com/show_bug.cgi?id=228469

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora
            Version|devel                       |rawhide