[Bug 497800] New: Review Request: perl-Acme-PlayCode - Perl module for enhancement of code

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-Acme-PlayCode - Perl module for enhancement of code

https://bugzilla.redhat.com/show_bug.cgi?id=497800

Summary: Review Request: perl-Acme-PlayCode - Perl module for
                    enhancement of code
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---

Spec URL: http://mmaslano.fedorapeople.org/review/perl-Acme-PlayCode.spec
SRPM URL:
http://mmaslano.fedorapeople.org/review/perl-Acme-PlayCode-0.11-1.fc11.src.r...
Description: It aims to change the code to be better (to be worse if you want).

http://koji.fedoraproject.org/koji/taskinfo?taskID=1322216

[Bug 497800] Review Request: perl-Acme-PlayCode - Perl module for enhancement of code

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=497800

Chris Weyl  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]

[Bug 497800] Review Request: perl-Acme-PlayCode - Perl module for enhancement of code

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=497800

Chris Weyl  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

[Bug 497800] Review Request: perl-Acme-PlayCode - Perl module for enhancement of code

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=497800

--- Comment #1 from Chris Weyl   2009-04-27 22:01:49 EDT ---
Updating line-endings (such as via dos2unix) is generally done in %prep...
perl(Test::Pod) also needs to be included as a BR.

Do the two updates above and I'll approve :)

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1322216

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
0034e6c7961d2f9ed8b5e6ad60ac7333941d73d9 Acme-PlayCode-0.11.tar.gz
0034e6c7961d2f9ed8b5e6ad60ac7333941d73d9 Acme-PlayCode-0.11.tar.gz.srpm

Final provides / requires are sane:

0 packages and 1 specfiles checked; 0 errors, 0 warnings.
=====> perl-Acme-PlayCode-0.11-1.fc10.src.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-Acme-PlayCode-0.11-1.fc10.src.rpm
====> requires for perl-Acme-PlayCode-0.11-1.fc10.src.rpm
dos2unix  
perl(List::MoreUtils)  
perl(Module::Build)  
perl(Moose) >= 0.57
perl(MooseX::Object::Pluggable) >= 0.0008
perl(Path::Class) >= 0.16
perl(PPI) >= 1.201
perl(Test::More)

=====> perl-Acme-PlayCode-0.11-1.fc10.noarch.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-Acme-PlayCode-0.11-1.fc10.noarch.rpm
perl(Acme::PlayCode) = 0.11
perl-Acme-PlayCode = 0.11-1.fc10
perl(Acme::PlayCode::Plugin::Averything) = 0.10
perl(Acme::PlayCode::Plugin::DoubleToSingle) = 0.10
perl(Acme::PlayCode::Plugin::ExchangeCondition) = 0.10
perl(Acme::PlayCode::Plugin::NumberPlus) = 0.11
perl(Acme::PlayCode::Plugin::PrintComma) = 0.10
====> requires for perl-Acme-PlayCode-0.11-1.fc10.noarch.rpm
perl(Data::Dumper)  
perl(List::MoreUtils)  
perl(:MODULE_COMPAT_5.10.0)  
perl(Moose)  
perl(Moose::Role)  
perl(Path::Class)  
perl(PPI)  
perl(PPI::Token::Comment)  
perl(vars)

[Bug 497800] Review Request: perl-Acme-PlayCode - Perl module for enhancement of code

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=497800

--- Comment #2 from Marcela Maslanova   2009-04-28 03:24:53 EDT ---
Updated srpm
http://mmaslano.fedorapeople.org/review/perl-Acme-PlayCode-0.11-2.fc11.src.r...

I think dos2unix in prep is not needed but I moved it for you.

[Bug 497800] Review Request: perl-Acme-PlayCode - Perl module for enhancement of code

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=497800

--- Comment #3 from Chris Weyl   2009-05-03 13:38:22 EDT ---
Koji (success) http://koji.fedoraproject.org/koji/taskinfo?taskID=1334190

[Bug 497800] Review Request: perl-Acme-PlayCode - Perl module for enhancement of code

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=497800

--- Comment #4 from Chris Weyl   2009-05-03 13:43:05 EDT ---
Generally speaking, dos2unix (or the ever popular "sed -e 's/\r//'") doesn't
strictly belong in %prep, but it fits far better in there than it does in
%build.  Stripping dos-like EOL characters from source is as much preparing it
as is patching it, or removing errant execute bits, etc.  Absent a very
compelling reason, we wouldn't include a %patch in %build, would we?

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1334190

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
0034e6c7961d2f9ed8b5e6ad60ac7333941d73d9 Acme-PlayCode-0.11.tar.gz
0034e6c7961d2f9ed8b5e6ad60ac7333941d73d9 Acme-PlayCode-0.11.tar.gz.srpm

Final provides / requires are sane:

0 packages and 1 specfiles checked; 0 errors, 0 warnings.
=====> perl-Acme-PlayCode-0.11-2.fc12.noarch.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-Acme-PlayCode-0.11-2.fc12.noarch.rpm
perl(Acme::PlayCode) = 0.11
perl-Acme-PlayCode = 0.11-2.fc12
perl(Acme::PlayCode::Plugin::Averything) = 0.10
perl(Acme::PlayCode::Plugin::DoubleToSingle) = 0.10
perl(Acme::PlayCode::Plugin::ExchangeCondition) = 0.10
perl(Acme::PlayCode::Plugin::NumberPlus) = 0.11
perl(Acme::PlayCode::Plugin::PrintComma) = 0.10
====> requires for perl-Acme-PlayCode-0.11-2.fc12.noarch.rpm
perl(Data::Dumper)  
perl(List::MoreUtils)  
perl(:MODULE_COMPAT_5.10.0)  
perl(Moose)  
perl(Moose::Role)  
perl(Path::Class)  
perl(PPI)  
perl(PPI::Token::Comment)  
perl(vars)

=====> perl-Acme-PlayCode-0.11-2.fc12.src.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-Acme-PlayCode-0.11-2.fc12.src.rpm
====> requires for perl-Acme-PlayCode-0.11-2.fc12.src.rpm
dos2unix  
perl(List::MoreUtils)  
perl(Module::Build)  
perl(Moose) >= 0.57
perl(MooseX::Object::Pluggable) >= 0.0008
perl(Path::Class) >= 0.16
perl(PPI) >= 1.201
perl(Test::More)  
perl(Test::Pod)

APPROVED

[Bug 497800] Review Request: perl-Acme-PlayCode - Perl module for enhancement of code

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=497800

Chris Weyl  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

[Bug 497800] Review Request: perl-Acme-PlayCode - Perl module for enhancement of code

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=497800

Peter Lemenkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Bug 497800] Review Request: perl-Acme-PlayCode - Perl module for enhancement of code

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=497800

--- Comment #5 from Marcela Maslanova   2009-05-05 03:47:36 EDT ---
The position of dos2unix is arguable. In different review I was told to use it
in prep because it prepare the source :)
Thank you for your review. I own you some.

[Bug 497800] Review Request: perl-Acme-PlayCode - Perl module for enhancement of code

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=497800

Marcela Maslanova  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #6 from Marcela Maslanova   2009-05-05 03:48:46 EDT ---
New Package CVS Request
=======================
Package Name: perl-Acme-PlayCode
Short Description: Perl module for enhancement of code
Owners: mmaslano
Branches: F-11
InitialCC: perl-sig

[Bug 497800] Review Request: perl-Acme-PlayCode - Perl module for enhancement of code

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=497800

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #7 from Kevin Fenzi   2009-05-06 17:02:40 EDT ---
cvs done.

[Bug 497800] Review Request: perl-Acme-PlayCode - Perl module for enhancement of code

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=497800

Marcela Maslanova  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |CURRENTRELEASE