[Bug 565502] New: Review Request: python-recaptcha-client - A plugin for reCAPTCHA and reCAPTCHA Mailhide

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: python-recaptcha-client - A plugin for reCAPTCHA and reCAPTCHA Mailhide

https://bugzilla.redhat.com/show_bug.cgi?id=565502

Summary: Review Request: python-recaptcha-client - A plugin for
                    reCAPTCHA and reCAPTCHA Mailhide
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---

Spec URL:
http://fedorapeople.org/~sgallagh/packagereview/python-recaptcha-client.spec
SRPM URL:
http://fedorapeople.org/~sgallagh/packagereview/python-recaptcha-client-1.0....
Description:
Provides a CAPTCHA for Python using the reCAPTCHA service. Does not require any
imaging libraries because the CAPTCHA is served directly from reCAPTCHA. Also
allows you to securely obfuscate emails with Mailhide. This functionality
requires pycrypto. This library requires two types of API keys. If you'd like
to use the CAPTCHA, you'll need a key from http://recaptcha.net/api/getkey. For
Mailhide, you'll need a key from http://mailhide.recaptcha.net/apikey.

[Bug 565502] Review Request: python-recaptcha-client - A plugin for reCAPTCHA and reCAPTCHA Mailhide

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=565502

--- Comment #1 from Stephen Gallagher  2010-02-15 09:14:38 EST ---
Additional information: this feature is being packaged because it is a
dependency for the next major release of ReviewBoard (version 1.5), which is
already included in Fedora.

[Bug 565502] Review Request: python-recaptcha-client - A plugin for reCAPTCHA and reCAPTCHA Mailhide

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=565502

Dave Malcolm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Dave Malcolm  2010-02-15 17:13:05 EST ---
(Not sure I'll have time for a full review, am getting ready for PyCon; but
here are some things I spotted)

The URL seems to be for recaptcha as a whole, and I found it hard to find info
on the client; I suggest changing the URL field to this:
  http://pypi.python.org/pypi/recaptcha-client

Initial review of specfile seems sane, with some issues noted below:

Please do a scratch build in Koji.

Please run rpmlint on the packages; looks like the %description needs to be
line-wrapped, at least:

python-recaptcha-client.noarch: E: description-line-too-long Provides a CAPTCHA
for Python using the reCAPTCHA service. Does not require any imaging libraries
because the CAPTCHA is served directly from reCAPTCHA. Also allows you to
securely obfuscate emails with Mailhide. This functionality requires pycrypto.
This library requires two types of API keys. If you'd like to use the CAPTCHA,
you'll need a key from http://recaptcha.net/api/getkey. For Mailhide, you'll
need a key from http://mailhide.recaptcha.net/apikey.
python-recaptcha-client.noarch: W: invalid-license X11
python-recaptcha-client.noarch: W: no-documentation
1 packages and 0 specfiles checked; 1 errors, 2 warnings.

description-line-too-long: please fix this
python-recaptcha-client.noarch: W: invalid-license X11: is there any license
information on this code other that the reference in the setup.py and on the
pypi web site?
python-recaptcha-client.noarch: W: no-documentation:  I don't see any
documentation in the tarball, so I think this can be waived

BTW, which releases are you targetting?  Rawhide and EPEL5?

[Bug 565502] Review Request: python-recaptcha-client - A plugin for reCAPTCHA and reCAPTCHA Mailhide

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=565502

Thomas Spura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Thomas Spura  2010-02-15 17:45:51 EST ---
There are also some other issues:

- use %global and not %define
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over...

- Buildrequires/requires: python is added automatic

- Could you please be a bit more specific in %files?
  When you use %{python_sitelib}/recaptcha_client-*.egg-info and
%{python_sitelib}/recaptcha you are notified if the egg can't be build.

- Where is this spec file based on?
  When you run "rpmdev-newspec -t python python-recaptcha-client" you could use
that spec file as a starting point.

e.g. from %install
%{__python} setup.py install -O1 --skip-build --root %{buildroot}

You don't have this --skip-build in your spec. Please add this, because this is
part of convention in all python packages.
https://fedoraproject.org/wiki/Packaging:Python

[Bug 565502] Review Request: python-recaptcha-client - A plugin for reCAPTCHA and reCAPTCHA Mailhide

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=565502

Stephen Gallagher  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?

--- Comment #4 from Stephen Gallagher  2010-03-09 11:18:46 EST ---
Spec URL:
http://fedorapeople.org/~sgallagh/packagereview/python-recaptcha-client.spec
SRPM URL:
http://fedorapeople.org/~sgallagh/packagereview/python-recaptcha-client-1.0....

Koji scratch builds completed successfully:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2041826 (Fedora 13)

http://koji.fedoraproject.org/koji/taskinfo?taskID=2041845 (EPEL 5)

[Bug 565502] Review Request: python-recaptcha-client - A plugin for reCAPTCHA and reCAPTCHA Mailhide

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=565502

Dave Malcolm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?                   |

--- Comment #5 from Dave Malcolm  2010-03-11 11:30:24 EST ---
A few minor nits:
- remove the "# sitelib for noarch packages, sitearch for others (remove the
unneeded one)" comment, and just use sitelib.  FWIW, these aren't actually
needed in Fedora 13 onwards; see:
http://fedoraproject.org/wiki/Packaging/Python#Macros
on how to conditionalize them
- in the %build stanza, remove the comment about removing CFLAGS, and actually
remove the CFLAGS :)
- the comment in the %files stanza is probably redundant
- in future %changelog entries, it can be better to briefly say what the
changes were, rather than "specfile changes"
- the Summary says "A plugin for reCAPTCHA and reCAPTCHA Mailhide", and I find
this wording rather awkward.  If I'm reading it right "reCAPTCHA and reCAPTCHA
Mailhide" is the functionality being added, but what is the program to which
the functionality is being added?  If it's "python", then the normal wording
would be "Python module"

[Bug 565502] Review Request: python-recaptcha-client - A plugin for reCAPTCHA and reCAPTCHA Mailhide

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=565502

Stephen Gallagher  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(dmalcolm@redhat.c
                   |                            |om)

--- Comment #6 from Stephen Gallagher  2010-03-11 12:03:02 EST ---
Thanks for the review. Updated spec and srpm:

Spec URL:
http://fedorapeople.org/~sgallagh/packagereview/python-recaptcha-client.spec
SRPM URL:
http://fedorapeople.org/~sgallagh/packagereview/python-recaptcha-client-1.0....

Built successfully in Koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2046956

[Bug 565502] Review Request: python-recaptcha-client - A plugin for reCAPTCHA and reCAPTCHA Mailhide

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=565502

Dave Malcolm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|needinfo?(dmalcolm@redhat.c |fedora-review+
                   |om)                         |

--- Comment #7 from Dave Malcolm  2010-03-11 12:12:49 EST ---
Looking good, but you didn't rerun rpmlint; this shows a problem:
python-recaptcha-client.src:60: W: macro-in-%changelog %files
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

APPROVED, but please fix the above issue by escaping that reference to "%files"
to "%%files" when you import the package, and ensure that rpmlint is thus
clean.

[Bug 565502] Review Request: python-recaptcha-client - A plugin for reCAPTCHA and reCAPTCHA Mailhide

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=565502

Stephen Gallagher  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #8 from Stephen Gallagher  2010-03-11 12:22:43 EST ---
New Package CVS Request
=======================
Package Name: python-recaptcha-client
Short Description: Python module for reCAPTCHA and reCAPTCHA Mailhide
Owners: sgallagh
Branches: F-12 F-13 EL-5
InitialCC:

[Bug 565502] Review Request: python-recaptcha-client - A plugin for reCAPTCHA and reCAPTCHA Mailhide

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=565502

Jason Tibbitts  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]

--- Comment #9 from Jason Tibbitts  2010-03-11 14:28:01 EST ---
Somehow this review was never assigned to anyone.  Please take review tickets
when you intend to review them.

[Bug 565502] Review Request: python-recaptcha-client - A plugin for reCAPTCHA and reCAPTCHA Mailhide

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=565502

--- Comment #10 from Jason Tibbitts  2010-03-11 14:28:47 EST ---
CVS done (by process-cvs-requests.py).

[Bug 565502] Review Request: python-recaptcha-client - A plugin for reCAPTCHA and reCAPTCHA Mailhide

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=565502

--- Comment #11 from Dave Malcolm  2010-03-11 14:38:49 EST ---
(In reply to comment #9)
> Somehow this review was never assigned to anyone.  Please take review tickets
> when you intend to review them.

My bad; sorry about that

[Bug 565502] Review Request: python-recaptcha-client - A plugin for reCAPTCHA and reCAPTCHA Mailhide

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=565502

--- Comment #12 from Fedora Update System  2010-03-16 11:48:20 EDT ---
python-recaptcha-client-1.0.5-3.el5 has been submitted as an update for Fedora
EPEL 5.
http://admin.fedoraproject.org/updates/python-recaptcha-client-1.0.5-3.el5

[Bug 565502] Review Request: python-recaptcha-client - A plugin for reCAPTCHA and reCAPTCHA Mailhide

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=565502

Stephen Gallagher  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

[Bug 565502] Review Request: python-recaptcha-client - A plugin for reCAPTCHA and reCAPTCHA Mailhide

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=565502

--- Comment #13 from Fedora Update System  2010-04-01 22:41:20 EDT ---
python-recaptcha-client-1.0.5-3.el5 has been pushed to the Fedora EPEL 5 stable
repository.  If problems still persist, please make note of it in this bug
report.

[Bug 565502] Review Request: python-recaptcha-client - A plugin for reCAPTCHA and reCAPTCHA Mailhide

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=565502

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|                            |python-recaptcha-client-1.0
                   |                            |.5-3.el5
         Resolution|NEXTRELEASE                 |ERRATA