[Bug 1476564] New: Review Request: deepin-dbus-generator - Convert dbus interfaces to go-lang or qml wrapper code
https://bugzilla.redhat.com/show_bug.cgi?id=1476564
Bug ID: 1476564 Summary: Review Request: deepin-dbus-generator - Convert dbus interfaces to go-lang or qml wrapper code Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: sensor.wen@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
SPEC: https://raw.githubusercontent.com/FZUG/repo/master/rpms/deepin_project/deepi...
Description: Convert dbus interfaces to go-lang or qml wrapper code
Fedora Account System Username: mosquito
https://bugzilla.redhat.com/show_bug.cgi?id=1476564
Zamir SUN sztsian@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1465889 | |(DeepinDEPackageReview)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1465889 [Bug 1465889] Tracking: Deepin Desktop related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1476564
--- Comment #1 from sensor.wen@gmail.com --- SPEC: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x8... SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x8...
Release 0.6.6
https://bugzilla.redhat.com/show_bug.cgi?id=1476564
--- Comment #2 from sensor.wen@gmail.com --- SPEC: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x8... SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x8...
Release 0.6.6, Rebuild.
https://bugzilla.redhat.com/show_bug.cgi?id=1476564
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1476565
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1476565 [Bug 1476565] Review Request: golang-deepin-dbus-factory - Golang DBus factory for DDE
https://bugzilla.redhat.com/show_bug.cgi?id=1476564
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- Hello,
- let's rearrange these BR:
BuildRequires: gcc-go BuildRequires: golang(gopkg.in/check.v1) BuildRequires: golang(pkg.deepin.io/lib) BuildRequires: pkgconfig(glib-2.0) BuildRequires: pkgconfig(gobject-2.0) BuildRequires: pkgconfig(Qt5) BuildRequires: pkgconfig(Qt5Qml)
- the License is GPLv3+, not GPLv3
License: GPLv3+
- the Group: tag is not needed in Fedora, please remove it.
- Please just use %global repo go-dbus-generator, no need for project.
- Since this package depends on Go packages only available on certains arches, you should probably add the same ExclusiveArch as go:
ExclusiveArch: %{?go_arches:%{go_arches}}%{!?go_arches:%{ix86} x86_64 aarch64 %{arm}}
Otherwise you'll get build errors in Koji.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3 or later)", "Unknown or generated". 20 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/deepin-dbus-generator/review-deepin-dbus- generator/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in deepin- dbus-generator-debuginfo [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: deepin-dbus-generator-0.6.6-1.fc26.x86_64.rpm deepin-dbus-generator-debuginfo-0.6.6-1.fc26.x86_64.rpm deepin-dbus-generator-0.6.6-1.fc26.src.rpm deepin-dbus-generator.x86_64: W: spelling-error Summary(en_US) lang -> Lang, lag, slang deepin-dbus-generator.x86_64: W: spelling-error Summary(en_US) qml -> ml, q ml, QM deepin-dbus-generator.x86_64: W: spelling-error %description -l en_US dlib -> lib, glib, d lib deepin-dbus-generator.x86_64: W: incoherent-version-in-changelog 0.6.6-1.gitace6ac0 ['0.6.6-1.fc26', '0.6.6-1'] deepin-dbus-generator.x86_64: W: no-manual-page-for-binary dbus-generator deepin-dbus-generator.src: W: spelling-error Summary(en_US) lang -> Lang, lag, slang deepin-dbus-generator.src: W: spelling-error Summary(en_US) qml -> ml, q ml, QM deepin-dbus-generator.src: W: spelling-error %description -l en_US dlib -> lib, glib, d lib 3 packages and 0 specfiles checked; 0 errors, 8 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1476564
--- Comment #4 from sensor.wen@gmail.com --- Diff: https://github.com/FZUG/repo/commit/8a3e62571acfaa0b1889abc4e07185995ce0746d
Fixed, thanks.
https://bugzilla.redhat.com/show_bug.cgi?id=1476564
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #5 from Robert-André Mauchin zebob.m@gmail.com --- All good, package accepted.
https://bugzilla.redhat.com/show_bug.cgi?id=1476564
--- Comment #6 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/deepin-dbus-generator
https://bugzilla.redhat.com/show_bug.cgi?id=1476564
Zamir SUN sztsian@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sztsian@gmail.com Alias| |deepin-dbus-generator
https://bugzilla.redhat.com/show_bug.cgi?id=1476564
Zamir SUN sztsian@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2018-07-22 09:29:43
--- Comment #7 from Zamir SUN sztsian@gmail.com --- This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com