[Bug 1925223] New: Review Request: R-cachem - Cache R Objects with Automatic Pruning

https://bugzilla.redhat.com/show_bug.cgi?id=1925223

Bug ID: 1925223
           Summary: Review Request: R-cachem - Cache R Objects with
                    Automatic Pruning
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://spot.fedorapeople.org/R-cachem.spec
SRPM URL: https://spot.fedorapeople.org/R-cachem-1.0.2-1.fc33.src.rpm
Description: Key-value stores with automatic pruning. Caches can limit either
their total size or the age of the oldest object (or both), automatically
pruning objects to maintain the constraints.
Fedora Account System Username: spot

[Bug 1925223] Review Request: R-cachem - Cache R Objects with Automatic Pruning

https://bugzilla.redhat.com/show_bug.cgi?id=1925223

Tom "spot" Callaway  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value

--- Comment #1 from Tom "spot" Callaway  ---
Needed to update R-memoise

[Bug 1925223] Review Request: R-cachem - Cache R Objects with Automatic Pruning

https://bugzilla.redhat.com/show_bug.cgi?id=1925223

José Matos  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review+

--- Comment #2 from José Matos  ---
The license is correct and appropriated for Fedora.
The spec file is simple and correct.

fedora-review complains:
- Package have the default element marked as %%doc :DESCRIPTION
- Package requires R-core.
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE is not marked as %license
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/LicensingGuidelines/#_license_text

The last one can also be ignored since the file LICENSE it is not a license.
:-)

Recycling from a previous review "After reviewing so many packages the other
thing that shows up is that probably the %install section could get a macro on
R-rpm-macros since this chunk appears so many times:

mkdir -p %{buildroot}%{rlibdir}
%{_bindir}/R CMD INSTALL -l %{buildroot}%{rlibdir} %{packname}
test -d %{packname}/src && (cd %{packname}/src; rm -f *.o *.so)
rm -f %{buildroot}%{rlibdir}/R.css
"

In this case the chunk is similar:
mkdir -p $RPM_BUILD_ROOT%{_libdir}/R/library
%{_bindir}/R CMD INSTALL -l $RPM_BUILD_ROOT%{_libdir}/R/library %{packname}
test -d %{packname}/src && (cd %{packname}/src; rm -f *.o *.so)
rm -rf $RPM_BUILD_ROOT%{_libdir}/R/library/R.css

I should probably submit a patch to R-rpm-macros since this is tedious and
repetitive. :-)

The package is approved.

[Bug 1925223] Review Request: R-cachem - Cache R Objects with Automatic Pruning

https://bugzilla.redhat.com/show_bug.cgi?id=1925223

--- Comment #3 from Mohan Boddu  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/R-cachem

[Bug 1925223] Review Request: R-cachem - Cache R Objects with Automatic Pruning

https://bugzilla.redhat.com/show_bug.cgi?id=1925223

Tom "spot" Callaway  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2021-02-08 20:49:43

--- Comment #4 from Tom "spot" Callaway  ---
In rawhide.