https://bugzilla.redhat.com/show_bug.cgi?id=1360274
Bug ID: 1360274 Summary: Review Request: qt5-qtvirtualkeyboard - The Qt Virtual Keyboard Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: helio@kde.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://heliocastro.fedorapeople.org/qt5-qtvirtualkeyboard/qt5-qtvirtualkeyb... SRPM URL: https://heliocastro.fedorapeople.org/qt5-qtvirtualkeyboard/qt5-qtvirtualkeyb... Description: The Qt Virtual Keyboard project provides an input framework and reference keyboard frontend for Qt 5 on Linux Desktop/X11, Windows Desktop, and Boot2Qt targets. The input framework makes it easy to write custom input methods or to integrate 3rd party input engines. The input methods can be implemented in C++ or QML. Fedora Account System Username: heliocastro
https://bugzilla.redhat.com/show_bug.cgi?id=1360274
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rdieter@math.unl.edu Blocks| |928937 (qt-reviews) Assignee|nobody@fedoraproject.org |rdieter@math.unl.edu Flags| |fedora-review?
--- Comment #1 from Rex Dieter rdieter@math.unl.edu --- I can review today
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=928937 [Bug 928937] Qt-related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1360274
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #2 from Rex Dieter rdieter@math.unl.edu --- naming: ok
macros: ok
scriptlets: ok
sources: ok fa473ab9175483dd82aa4d27b9682715 qtvirtualkeyboard-opensource-src-5.7.0.tar.xz
licensing: ok
dependencies: mostly ok
1. SHOULD: I see: %{?_qt5:Requires: %{_qt5}%{?_isa} = %{_qt5_version}} but no matching BuildRequires: qt5-qtbase-private-devel (which is what we currently use to easily track these hard versioned dependencies). Please add that
Otherwise, relatively simple package, matches conventions and style of other existing qt5 packages.
APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1360274
--- Comment #3 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/qt5-qtvirtualkeyboard
https://bugzilla.redhat.com/show_bug.cgi?id=1360274
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |RAWHIDE Last Closed| |2016-08-01 10:54:54
--- Comment #4 from Rex Dieter rdieter@math.unl.edu --- imported and built for rawhide
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla