Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202529
Summary: Review Request: rt2500-(kmod-common) Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: kwizart@gmail.com QAContact: fedora-package-review@redhat.com
Spec URL: http://kwizart.free.fr/fedora/SPECS/rt2500.spec SRPM URL: http://kwizart.free.fr/fedora/5/SRPMS/rt2500-0.0.0.2006080806-3_FC5.src.rpm Description: User module and Diagnostic tools for Ralink Wireless devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: rt2500-(kmod-common)
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202529
------- Additional Comments From paul@all-the-johnsons.co.uk 2006-08-14 18:39 EST ------- BuildRequires: qt-devel >= 3.2.1
If you're only packing this for FC5/6/rawhide, you won't need this.
You will need to include desktop-file-utils
ExclusiveArch: i686 x86_64
Needs a note explaining why also needs a note why smp_mflags are not used on the make line
%install cd Utilitys
No.
If the file is in Utilitys from the BUILD directory, it should be
install Utilitys/foo $RPM_BUILD_DIR%{_bindir}/foo
You don't need to use cd
mkdir -p $RPM_BUILD_ROOT%{_datadir}/doc/rt2500 install -D -p -m 0644 THANKS CHANGELOG FAQ LICENSE $RPM_BUILD_ROOT%{_datadir}/doc/rt2500
These should be done in the %files section using %doc ie.
%doc THANKS CHANGELOG FAQ etc. If the mode is not already correct, %prep is the correct place to fix it.
cat > %{name}.desktop <<EOF
No Version tag
desktop-file-install --vendor livna
livna?
gtk-update-icon-cache -qf %{_datadir}/pixmaps/rt2500 &>/dev/null || : update-desktop-database &>/dev/null || :
Have a look at
http://fedoraproject.org/wiki/ScriptletSnippets#head-fc74f078205565f961f6d83...
for advice on this. You can't just assume gtk-update-icon-cache or update-desktop-database exist, they have to be checked and the package they come from included in the BRs
%{_datadir}/pixmaps/rt2500/RaConfig2500.xpm %{_datadir}/pixmaps/rt2500/adapter.xpm
No.
%{_datadir}/pixmaps/%{name}/
is all that is required
%doc %{_datadir}/doc/rt2500/*
See above
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: rt2500-(kmod-common)
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202529
------- Additional Comments From kwizart@gmail.com 2006-08-14 20:30 EST ------- updated version of the spec file: - drop qt-devel >= 3.2.1 * how to include desktop-file-utils? - drop exclusive arch, may build on i586, i686, x86_64 - maybe on pcc?(asking team) * what is a version tag example with applet desktop ? - dropped gtk-icon-cache (not high res directory - remplaced with ln rt2500/foo.xpm - doc ok!
What else may
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: rt2500-(kmod-common)
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202529
------- Additional Comments From kwizart@gmail.com 2006-08-15 08:51 EST ------- ... be corrected?
ppc (big endian) may be very buggy cf https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202528 dropped for testing? i586 is certainly good also...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: rt2500-(kmod-common)
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202529
kwizart@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |202528
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: rt2500-(kmod-common)
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202529
------- Additional Comments From kwizart@gmail.com 2006-08-17 21:34 EST ------- Spec URL: http://kwizart.free.fr/fedora/SPECS/rt2500.spec SRPM URL: http://kwizart.free.fr/fedora/5/SRPMS/rt2500-1.1.0.cvs2006081716-4_FC5.src.r... Description: Diagnostic tools for Ralink Wireless devices
rpmlint -1 success... (i686, debug, src)
There is still a problem with RaConfig2500 for asking root password with pam... ( Any info about this ? )
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: rt2500-(kmod-common)
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202529
------- Additional Comments From davidf@sjsoft.com 2006-09-23 15:47 EST ------- some of the install -D caused problems for me in the latest spec file - they seemed to be in the case where there is a file given with a directory destination (-D expects the full pathname as destination): mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/sysconfig/network-scripts install -D -p -m 0644 Module/ifcfg-ra0 $RPM_BUILD_ROOT%{_sysconfdir}/sysconfig/network-scripts
That -D (and several other similar) should be removed AFAICT
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: rt2500-(kmod-common)
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202529
kwizart@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |WONTFIX BugsThisDependsOn|202528 |
------- Additional Comments From kwizart@gmail.com 2006-10-02 19:53 EST ------- Review closed because rt2x00 can now be built, i'm using bug : https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202528 to request review of rt2x00-kmod and rt2x00-kmod-common.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: rt2500-(kmod-common)
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202529
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163776 | nThis| |
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla