Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-Catalyst-Plugin-Session-Store-FastMmap - FastMmap session storage backend
https://bugzilla.redhat.com/show_bug.cgi?id=462254
Summary: Review Request: perl-Catalyst-Plugin-Session-Store-FastMmap - FastMmap session storage backend Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: iarnell@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://www.xs4all.nl/~iarnell/fedora/perl-Catalyst-Plugin-Session-Store-Fast... SRPM URL: http://www.xs4all.nl/~iarnell/fedora/perl-Catalyst-Plugin-Session-Store-Fast... Description: Catalyst::Plugin::Session::Store::FastMmap is a fast session storage plugin for Catalyst that uses an mmap'ed file to act as a shared memory interprocess cache. It is based on Cache::FastMmap.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462254
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora-perl-devel-list@redh | |at.com Depends on| |462253
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462254
Chris Weyl cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |cweyl@alumni.drew.edu Flag| |fedora-review?
Bug 462254 depends on bug 462253, which changed state.
Bug 462253 Summary: Review Request: perl-Cache-FastMmap - Uses an mmap'ed file to act as a shared memory interprocess cache https://bugzilla.redhat.com/show_bug.cgi?id=462253
What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED
--- Comment #1 from Chris Weyl cweyl@alumni.drew.edu 2008-11-12 19:30:31 EDT --- Sorry for taking so long; I'd meant to pick up this review earlier but the Real Job has me busy lately :-)
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=929961
There are 2 missing BR's for tests, Test::Pod and Test::Pod::Coverage; both of these should be added as buildrequires. perl(Path::Class) appears twice in the requires, due to an explicit requires statement; this doesn't harm anything but I'd suggest dropping the explicit requires from the spec.
The rpmlint warning you really can't do anything about :-)
=====> perl-Catalyst-Plugin-Session-Store-FastMmap-0.05-1.fc9.noarch.rpm <===== ====> rpmlint perl-Catalyst-Plugin-Session-Store-FastMmap.noarch: W: filename-too-long-for-joliet perl-Catalyst-Plugin-Session-Store-FastMmap-0.05-1.fc9.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 1 warnings. ====> provides for perl-Catalyst-Plugin-Session-Store-FastMmap-0.05-1.fc9.noarch.rpm perl(Catalyst::Plugin::Session::Store::FastMmap) = 0.05 perl-Catalyst-Plugin-Session-Store-FastMmap = 0.05-1.fc9 ====> requires for perl-Catalyst-Plugin-Session-Store-FastMmap-0.05-1.fc9.noarch.rpm perl(:MODULE_COMPAT_5.10.0) perl(Cache::FastMmap) >= 1.13 perl(Catalyst::Plugin::Session) >= 0.09 perl(Catalyst::Utils) perl(File::Spec) perl(NEXT) perl(Path::Class) perl(Path::Class) perl(base) perl(strict)
Source matches upstream: a5c28758a3a212fcc0f374110bc7855c Catalyst-Plugin-Session-Store-FastMmap-0.05.tar.gz a5c28758a3a212fcc0f374110bc7855c Catalyst-Plugin-Session-Store-FastMmap-0.05.tar.gz.srpm
License (perl) is correct.
Make the requires/buildrequires changes at the top of this review, and I'll approve.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462254
--- Comment #2 from Iain Arnell iarnell@gmail.com 2008-11-12 21:53:13 EDT --- Thanks, Chris. New spec and srpm to enable the pod tests and remove the duplicate requires.
Spec URL: http://www.xs4all.nl/~iarnell/fedora/perl-Catalyst-Plugin-Session-Store-Fast... SRPM URL: http://www.xs4all.nl/~iarnell/fedora/perl-Catalyst-Plugin-Session-Store-Fast...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462254
Chris Weyl cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #3 from Chris Weyl cweyl@alumni.drew.edu 2008-11-13 00:13:39 EDT --- APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462254
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #4 from Iain Arnell iarnell@gmail.com 2008-11-13 00:32:34 EDT --- New Package CVS Request ======================= Package Name: perl-Catalyst-Plugin-Session-Store-FastMmap Short Description: FastMmap session storage backend Owners: iarnell Branches: F-9 F-10 InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462254
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #5 from Kevin Fenzi kevin@tummy.com 2008-11-14 00:35:54 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462254
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2008-11-14 12:23:35 EDT --- perl-Catalyst-Plugin-Session-Store-FastMmap-0.05-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/perl-Catalyst-Plugin-Session-Store-Fa...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462254
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2008-11-14 12:23:38 EDT --- perl-Catalyst-Plugin-Session-Store-FastMmap-0.05-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-Catalyst-Plugin-Session-Store-Fa...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462254
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2008-11-19 09:48:30 EDT --- perl-Catalyst-Plugin-Session-Store-FastMmap-0.05-2.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Catalyst-Plugin-Session-Store-FastMmap'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-9711
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462254
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2008-11-22 11:56:28 EDT --- perl-Catalyst-Plugin-Session-Store-FastMmap-0.05-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Catalyst-Plugin-Session-Store-FastMmap'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/f10/FEDORA-2008-10000
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462254
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution| |RAWHIDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462254
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2008-12-06 23:19:55 EDT --- perl-Catalyst-Plugin-Session-Store-FastMmap-0.05-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462254
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|RAWHIDE |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462254
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2008-12-06 23:21:12 EDT --- perl-Catalyst-Plugin-Session-Store-FastMmap-0.05-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462254
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
--- Comment #12 from Iain Arnell iarnell@gmail.com 2011-07-11 11:54:36 EDT --- Package Change Request ====================== Package Name: perl-Catalyst-Plugin-Session-Store-FastMmap New Branches: el6 Owners: iarnell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462254
--- Comment #13 from Jon Ciesla limb@jcomserv.net 2011-07-11 12:01:17 EDT --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org