https://bugzilla.redhat.com/show_bug.cgi?id=2364276
Bug ID: 2364276 Summary: Review Request: rust-nng-c-sys - Bindings nng C library Product: Fedora Version: rawhide URL: https://crates.io/crates/nng-c-sys Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: solomoncyj@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://solomoncyj.fedorapeople.org/reviews/rust-nng-c-sys/rust-nng-c-sys.sp... SRPM URL: https://solomoncyj.fedorapeople.org/reviews/rust-nng-c-sys/rust-nng-c-sys-1....
Description: Bindings nng C library.
Fedora Account System Username: solomoncyj
https://bugzilla.redhat.com/show_bug.cgi?id=2364276
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8999728 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2364276
solomoncyj@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2364277
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2364277 [Bug 2364277] Review Request: rust-nng-c - High level bindings nng C library
https://bugzilla.redhat.com/show_bug.cgi?id=2364276
solomoncyj@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2359652
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2359652 [Bug 2359652] Review Request: mission-center - Monitor your CPU, Memory, Disk, Network and GPU usage
https://bugzilla.redhat.com/show_bug.cgi?id=2364276
Ben Beasley code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |code@musicinmybrain.net
--- Comment #2 from Ben Beasley code@musicinmybrain.net --- I see some reason for caution here. This bundles mbedtls, which is a TLS implementation, so may require special handling under https://docs.fedoraproject.org/en-US/packaging-guidelines/CryptoPolicies/. As for any bundled library, there should also be a serious effort to patch build.rs to link the system copy at https://src.fedoraproject.org/rpms/mbedtls. Hopefully the differences between the packaged 3.6.3 and the bundled 2.28.9 aren’t too significant. On the bright side, successfully linking the system copy would avoid most of the extra scrutiny that would apply to this package for bundling a crypo implementation.
https://bugzilla.redhat.com/show_bug.cgi?id=2364276
--- Comment #3 from Ben Beasley code@musicinmybrain.net --- Note that when adjusting a -sys library to use the external/system copy of a library it normally bundles, it’s a good idea to also patch it (downstream-only) so that bindgen is a non-optional dependency and binding re-generation happens unconditionally (here, governed by the build-bindgen feature). You can still have the feature, but it shouldn’t actually control anything anymore. That makes sure that we don’t have issues with bindings that were based on the bundled version rather than the system version of the wrapped library.
https://bugzilla.redhat.com/show_bug.cgi?id=2364276
--- Comment #4 from solomoncyj@gmail.com --- Spec URL: https://solomoncyj.fedorapeople.org/reviews/rust-nng-c-sys/rust-nng-c-sys.sp... SRPM URL: https://solomoncyj.fedorapeople.org/reviews/rust-nng-c-sys/rust-nng-c-sys-1....
- Uncommitted changes
https://bugzilla.redhat.com/show_bug.cgi?id=2364276
--- Comment #5 from Ben Beasley code@musicinmybrain.net --- This appears to have test failures:
Running `/builddir/build/BUILD/rust-nng-c-sys-1.10.1-build/nng-c-sys-1.10.1/target/rpm/deps/features-d4796bb80a91967a` running 2 tests test should_verify_tls_feature_enabled ... FAILED test should_verify_http_feature_enabled ... FAILED failures: ---- should_verify_tls_feature_enabled stdout ---- thread 'should_verify_tls_feature_enabled' panicked at tests/features.rs:16:5: assertion `left == right` failed left: "mbed" right: "none" ---- should_verify_http_feature_enabled stdout ---- thread 'should_verify_http_feature_enabled' panicked at tests/features.rs:26:5: assertion `left == right` failed left: 0 right: 9 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace failures: should_verify_http_feature_enabled should_verify_tls_feature_enabled test result: FAILED. 0 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s error: test failed, to rerun pass `--test features` Running `/builddir/build/BUILD/rust-nng-c-sys-1.10.1-build/nng-c-sys-1.10.1/target/rpm/deps/version-c83374c773a5462f` running 1 test test should_verify_version ... FAILED failures: ---- should_verify_version stdout ---- thread 'should_verify_version' panicked at tests/version.rs:12:5: assertion `left == right` failed left: "1.8.0" right: "1.10.0" note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace failures: should_verify_version test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s error: test failed, to rerun pass `--test version`
https://bugzilla.redhat.com/show_bug.cgi?id=2364276
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com
--- Comment #6 from Fabio Valentini decathorpe@gmail.com --- Depending on what you need this for, you might be able to just remove + patch out the bundled mbedtls. It's apparently only required if the non-default "tls" feature is enabled in this crate.
https://bugzilla.redhat.com/show_bug.cgi?id=2364276
solomoncyj@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |CANTFIX Status|NEW |CLOSED Last Closed| |2026-01-03 12:43:28
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com