Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: rubygem-hawler - Hawler, the Ruby HTTP crawler
https://bugzilla.redhat.com/show_bug.cgi?id=530204
Summary: Review Request: rubygem-hawler - Hawler, the Ruby HTTP crawler Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: kanarip@kanarip.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://www.kanarip.com/custom/SPECS/rubygem-hawler.spec SRPM URL: http://www.kanarip.com/custom/f12/SRPMS/rubygem-hawler-0.3-2.fc12.src.rpm Description: Hawler, the Ruby HTTP crawler
The not-so-funny thing is, I don't know what kinda license this package is. I was hoping someone could help with that. The license file is at http://spoofed.org/files/hawler/src/COPYING
rpmlint again complains about that License, of course, and also some other warnings that do not make sense:
$ rpmlint /home/jmeeuwen/devel/rpmbuild/RPMS/noarch/rubygem-hawler-0.3-2.fc12.noarch.rpm rubygem-hawler.noarch: W: invalid-license Unknown rubygem-hawler.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/hawler-0.3/ri/Hawlee/get%3f-i.yaml %3f rubygem-hawler.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/hawler-0.3/ri/Hawlee/head%3f-i.yaml %3f rubygem-hawler.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/hawler-0.3/ri/Hawlee/harvest%3f-i.yaml %3f rubygem-hawler.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/hawler-0.3/ri/HawlerHelper/offsite%3f-c.yaml %3f rubygem-hawler.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/hawler-0.3/ri/Hawlee/analyze%3f-i.yaml %3f 1 packages and 0 specfiles checked; 0 errors, 6 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530204
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp Flag| |fedora-review?
--- Comment #1 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-10-24 12:46:20 EDT --- Some notes
* Unneeded macro - %ruby_sitelib is used nowhere.
* License - MIT. However please include the following file http://spoofed.org/files/hawler/src/COPYING in the srpm with the full URL and install this file (I think installing under %geminstdir is better), mark this as %doc
* %description - Are there any a bit more detailed description?
* Test - As this gem file contains test/ directory, please add %check section and execute some tests there.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530204
--- Comment #2 from Jeroen van Meeuwen kanarip@kanarip.com 2009-10-24 19:03:12 EDT --- (In reply to comment #1)
Some notes
- Unneeded macro
- %ruby_sitelib is used nowhere.
Removed
- License
- MIT. However please include the following file http://spoofed.org/files/hawler/src/COPYING in the srpm with the full URL and install this file (I think installing under %geminstdir is better), mark this as %doc
Fixed
- %description
- Are there any a bit more detailed description?
I c/p'ed an extra line from the README, not sure what else to put in there.
- Test
- As this gem file contains test/ directory, please add %check section and execute some tests there.
Two out of three tests require rubygem-hpricot, which is not in Fedora yet. Enabled the other test though.
New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-hawler.spec New SRPM: http://www.kanarip.com/custom/f12/SRPMS/rubygem-hawler-0.3-3.fc12.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530204
--- Comment #3 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-10-24 23:44:49 EDT --- Well, I have not checked your latest srpm yet, however: (In reply to comment #1)
- License
- MIT.
No, this is BSD, not MIT, sorry...
(In reply to comment #2)
(In reply to comment #1)
- Test
- As this gem file contains test/ directory, please add %check section and execute some tests there.
Two out of three tests require rubygem-hpricot, which is not in Fedora yet. Enabled the other test though.
- rubygem-hpricot is already in Fedora and actually the maintainer is me (if upgrade or bug fix is needed, please file a bug)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530204
--- Comment #4 from Jeroen van Meeuwen kanarip@kanarip.com 2009-10-25 07:42:25 EDT --- (In reply to comment #3)
Well, I have not checked your latest srpm yet, however: (In reply to comment #1)
- License
- MIT.
No, this is BSD, not MIT, sorry...
No problem; corrected in the new SPEC/SRPM.
(In reply to comment #2)
(In reply to comment #1)
- Test
- As this gem file contains test/ directory, please add %check section and execute some tests there.
Two out of three tests require rubygem-hpricot, which is not in Fedora yet. Enabled the other test though.
- rubygem-hpricot is already in Fedora and actually the maintainer is me (if upgrade or bug fix is needed, please file a bug)
Ha! How did I miss this! ;-) Enlisted myself as co-maintainer if you don't mind. Made it a BuildRequirement and enabled all three tests separately (as one of them would still fail but I want the output of all three in the build logs).
New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-hawler.spec New SRPM: http://www.kanarip.com/custom/f12/SRPMS/rubygem-hawler-0.3-4.fc12.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530204
--- Comment #5 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-10-25 12:41:14 EDT --- Created an attachment (id=366035) --> (https://bugzilla.redhat.com/attachment.cgi?id=366035) Patch to fix test failure
For -4:
* Requires ---------------------------------------- BuildRequires: rubygem(hpricot) ---------------------------------------- - Well, lib/hawlerhelper.rb actually requires hpricot, so it may be better that "Requires: rubygem(hpricot)" is added.
* Test (In reply to comment #4)
(as one of them would still fail but I want the output of all three in the build logs).
- The attached patch should fix test failure, provided that net connection is in active. Note that test/ts_hawlerhelper.rb still fails without net connection.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530204
--- Comment #6 from Jeroen van Meeuwen kanarip@kanarip.com 2009-11-01 08:05:39 EDT --- - Added Requires: rubygem(hpricot) - Added patch (but kept tests to not break the build if net connection is not available)
New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-hawler.spec New SRPM: http://www.kanarip.com/custom/f12/SRPMS/rubygem-hawler-0.3-5.fc12.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530204
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #7 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-11-01 13:08:41 EDT --- ----------------------------------------------------------- This package (rubygem-hawler) is APPROVED by mtasaka -----------------------------------------------------------
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530204
Jeroen van Meeuwen kanarip@kanarip.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #8 from Jeroen van Meeuwen kanarip@kanarip.com 2009-11-01 14:54:50 EDT --- New Package CVS Request ======================= Package Name: rubygem-hawler Short Description: Hawler, the ruby HTTP crawler Owners: kanarip Branches: EL-4 EL-5 F-11 F-12 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530204
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #9 from Kevin Fenzi kevin@tummy.com 2009-11-02 23:35:30 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530204
--- Comment #10 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-11-07 12:11:39 EDT --- Please submit push request on bodhi.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530204
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2009-11-07 17:02:32 EDT --- rubygem-hawler-0.3-5.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/rubygem-hawler-0.3-5.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530204
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2009-11-07 17:02:37 EDT --- rubygem-hawler-0.3-5.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/rubygem-hawler-0.3-5.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530204
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2009-11-10 12:47:21 EDT --- rubygem-hawler-0.3-5.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-hawler'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-11208
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530204
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2009-11-10 12:57:51 EDT --- rubygem-hawler-0.3-5.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-hawler'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-11298
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530204
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution| |NEXTRELEASE
--- Comment #15 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-11-21 09:14:53 EDT --- Closing.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530204
--- Comment #16 from Fedora Update System updates@fedoraproject.org 2009-12-22 14:54:12 EDT --- rubygem-hawler-0.3-5.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530204
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |0.3-5.fc12 Resolution|NEXTRELEASE |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530204
--- Comment #17 from Fedora Update System updates@fedoraproject.org 2009-12-22 14:55:35 EDT --- rubygem-hawler-0.3-5.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530204
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|0.3-5.fc12 |0.3-5.fc11
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla